From 7be379feed0eacc22f5017d9f4992ac605021248 Mon Sep 17 00:00:00 2001
From: dota17 <chenguopingdota@163.com>
Date: Thu, 19 Dec 2019 15:12:38 +0800
Subject: [PATCH] fix Reader bug and add testcase

---
 src/lib_json/json_reader.cpp |  2 +-
 src/test_lib_json/main.cpp   | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/src/lib_json/json_reader.cpp b/src/lib_json/json_reader.cpp
index 87483da60..9818b5bf2 100644
--- a/src/lib_json/json_reader.cpp
+++ b/src/lib_json/json_reader.cpp
@@ -467,7 +467,7 @@ bool Reader::readObject(Token& token) {
       Value numberName;
       if (!decodeNumber(tokenName, numberName))
         return recoverFromError(tokenObjectEnd);
-      name = String(numberName.asCString());
+      name = numberName.asString();
     } else {
       break;
     }
diff --git a/src/test_lib_json/main.cpp b/src/test_lib_json/main.cpp
index 6f4bbde04..6f5230450 100644
--- a/src/test_lib_json/main.cpp
+++ b/src/test_lib_json/main.cpp
@@ -2648,6 +2648,10 @@ struct ReaderTest : JsonTest::TestCase {
         new Json::Reader(Json::Features{}.strictMode()));
   }
 
+  void setFeatures(Json::Features& features) {
+    reader = std::unique_ptr<Json::Reader>(new Json::Reader(features));
+  }
+
   void checkStructuredErrors(
       const std::vector<Json::Reader::StructuredError>& actual,
       const std::vector<Json::Reader::StructuredError>& expected) {
@@ -2851,6 +2855,13 @@ JSONTEST_FIXTURE_LOCAL(ReaderTest, pushErrorTest) {
                                "See Line 1, Column 14 for detail.\n");
 }
 
+JSONTEST_FIXTURE_LOCAL(ReaderTest, allowNumericKeysTest) {
+  Json::Features features;
+  features.allowNumericKeys_ = true;
+  setFeatures(features);
+  checkParse(R"({ 123 : "abc" })");
+}
+
 struct CharReaderTest : JsonTest::TestCase {};
 
 JSONTEST_FIXTURE_LOCAL(CharReaderTest, parseWithNoErrors) {