Remove pstrg framework

The storage support has never been implemented and
there seems little/any real demand - heard lots of
interest expressed, but never materialized into
actual code. So remove it for now - someone can
restore and complete later if they want to pursue
it again.

Signed-off-by: Ralph Castain <rhc@pmix.org>

Author: rhc54

docs/developers/frameworks.rst

@@ -38,8 +38,6 @@ this writing |date|:
   during transmission
 * ``pstat``: Statistics, including reporting resource usage at the
   process, node, and disk levels
-* ``pstrg``: Storage system support for querying availability and
-  characteristics of file systems
 * ``ptl``: Transport Layer for client-server and tool-server
   communication
 

src/common/pmix_alloc.c

@@ -6,7 +6,7 @@
  * Copyright (c) 2016-2022 IBM Corporation.  All rights reserved.
  * Copyright (c) 2019      Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
- * Copyright (c) 2021-2023 Nanook Consulting.  All rights reserved.
+ * Copyright (c) 2021-2024 Nanook Consulting  All rights reserved.
  * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
@@ -25,7 +25,6 @@
 
 #include "src/common/pmix_attributes.h"
 #include "src/mca/bfrops/bfrops.h"
-#include "src/mca/pstrg/pstrg.h"
 #include "src/mca/ptl/base/base.h"
 #include "src/threads/pmix_threads.h"
 #include "src/util/pmix_argv.h"

src/common/pmix_query.c

@@ -6,7 +6,7 @@
  * Copyright (c) 2016-2022 IBM Corporation.  All rights reserved.
  * Copyright (c) 2019      Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
- * Copyright (c) 2021-2023 Nanook Consulting.  All rights reserved.
+ * Copyright (c) 2021-2024 Nanook Consulting  All rights reserved.
  * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
@@ -25,7 +25,6 @@
 
 #include "src/common/pmix_attributes.h"
 #include "src/mca/bfrops/bfrops.h"
-#include "src/mca/pstrg/pstrg.h"
 #include "src/mca/ptl/base/base.h"
 #include "src/threads/pmix_threads.h"
 #include "src/util/pmix_argv.h"
@@ -362,50 +361,6 @@ static void _local_relcb(void *cbdata)
     PMIX_RELEASE(cd);
 }
 
-static void nxtcbfunc(pmix_status_t status, pmix_list_t *results, void *cbdata)
-{
-    pmix_query_caddy_t *cd = (pmix_query_caddy_t *) cbdata;
-    size_t n;
-    pmix_kval_t *kv, *kvnxt;
-    pmix_status_t rc;
-
-    /* if they return success, then all queries were locally
-     * resolved, so construct the results for return */
-    if (PMIX_SUCCESS == status) {
-        cd->status = status;
-        cd->ninfo = pmix_list_get_size(results);
-        PMIX_INFO_CREATE(cd->info, cd->ninfo);
-        n = 0;
-        PMIX_LIST_FOREACH_SAFE (kv, kvnxt, results, pmix_kval_t) {
-            PMIX_LOAD_KEY(cd->info[n].key, kv->key);
-            rc = PMIx_Value_xfer(&cd->info[n].value, kv->value);
-            if (PMIX_SUCCESS != rc) {
-                cd->status = rc;
-                PMIX_INFO_FREE(cd->info, cd->ninfo);
-                break;
-            }
-            ++n;
-        }
-
-        if (NULL != cd->cbfunc) {
-            cd->cbfunc(cd->status, cd->info, cd->ninfo, cd->cbdata, _local_relcb, cd);
-        }
-    } else {
-        /* need to ask our host */
-        rc = request_help(cd);
-        if (PMIX_SUCCESS != rc) {
-            /* we have to return the error to the caller */
-            if (NULL != cd->cbfunc) {
-                cd->cbfunc(rc, NULL, 0, cd->cbdata, NULL, NULL);
-            }
-        }
-        cd->queries = NULL;
-        cd->nqueries = 0;
-        PMIX_RELEASE(cd);
-        return;
-    }
-}
-
 void pmix_parse_localquery(int sd, short args, void *cbdata)
 {
     pmix_query_caddy_t *cd = (pmix_query_caddy_t *) cbdata;
@@ -490,7 +445,7 @@ void pmix_parse_localquery(int sd, short args, void *cbdata)
                 if (PMIX_SUCCESS != rc) {
                     /* not in our gds */
                     PMIX_DESTRUCT(&cb);
-                    goto nextstep;
+                    goto complete;
                 }
             }
             /* need to retain this result */
@@ -503,12 +458,8 @@ void pmix_parse_localquery(int sd, short args, void *cbdata)
         }
     }
 
-nextstep:
-    /* pass the queries thru our active plugins with query
-     * interfaces to see if someone can resolve it */
-    rc = pmix_pstrg.query(queries, nqueries, &results, nxtcbfunc, cd);
-    if (PMIX_OPERATION_SUCCEEDED == rc) {
 complete:
+    if (PMIX_OPERATION_SUCCEEDED == rc) {
         /* if we get here, then all queries were locally
          * resolved, so construct the results for return */
         cd->status = PMIX_SUCCESS;

src/common/pmix_session.c

@@ -6,7 +6,7 @@
  * Copyright (c) 2016-2022 IBM Corporation.  All rights reserved.
  * Copyright (c) 2019      Research Organization for Information Science
  *                         and Technology (RIST).  All rights reserved.
- * Copyright (c) 2021-2023 Nanook Consulting.  All rights reserved.
+ * Copyright (c) 2021-2024 Nanook Consulting  All rights reserved.
  * Copyright (c) 2022      Triad National Security, LLC. All rights reserved.
  * $COPYRIGHT$
  *
@@ -25,7 +25,6 @@
 
 #include "src/common/pmix_attributes.h"
 #include "src/mca/bfrops/bfrops.h"
-#include "src/mca/pstrg/pstrg.h"
 #include "src/mca/ptl/base/base.h"
 #include "src/threads/pmix_threads.h"
 #include "src/util/pmix_argv.h"

src/include/pmix_globals.c

@@ -497,7 +497,6 @@ static void qcon(pmix_query_caddy_t *p)
     p->relcbfunc = NULL;
     p->credcbfunc = NULL;
     p->validcbfunc = NULL;
-    p->stqcbfunc = NULL;
 }
 static void qdes(pmix_query_caddy_t *p)
 {

src/include/pmix_globals.h

@@ -472,8 +472,6 @@ typedef struct {
 } pmix_iof_req_t;
 PMIX_CLASS_DECLARATION(pmix_iof_req_t);
 
-typedef void (*pmix_pstrg_query_cbfunc_t)(pmix_status_t status, pmix_list_t *results, void *cbdata);
-
 /* caddy for query requests */
 typedef struct {
     pmix_object_t super;
@@ -498,7 +496,6 @@ typedef struct {
     pmix_release_cbfunc_t relcbfunc;
     pmix_credential_cbfunc_t credcbfunc;
     pmix_validation_cbfunc_t validcbfunc;
-    pmix_pstrg_query_cbfunc_t stqcbfunc;
     void *cbdata;
 } pmix_query_caddy_t;
 PMIX_CLASS_DECLARATION(pmix_query_caddy_t);