Skip to content

Commit 3ddf3cc

Browse files
committed
Merge pull request #1758 from hjelmn/ob1_fixes
pml/ob1: bug fixes
2 parents 0efb1b5 + 5d0b467 commit 3ddf3cc

File tree

1 file changed

+5
-7
lines changed

1 file changed

+5
-7
lines changed

ompi/mca/pml/ob1/pml_ob1_sendreq.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* Copyright (c) 2008 UT-Battelle, LLC. All rights reserved.
1414
* Copyright (c) 2010 Oracle and/or its affiliates. All rights reserved.
1515
* Copyright (c) 2012 NVIDIA Corporation. All rights reserved.
16-
* Copyright (c) 2012-2015 Los Alamos National Security, LLC. All rights
16+
* Copyright (c) 2012-2016 Los Alamos National Security, LLC. All rights
1717
* reserved.
1818
* Copyright (c) 2015 Cisco Systems, Inc. All rights reserved.
1919
* $COPYRIGHT$
@@ -495,9 +495,6 @@ int mca_pml_ob1_send_request_start_copy( mca_pml_ob1_send_request_t* sendreq,
495495
if( OPAL_LIKELY(OMPI_SUCCESS == rc) ) {
496496
/* signal request completion */
497497
send_request_pml_complete(sendreq);
498-
499-
/* check for pending requests */
500-
MCA_PML_OB1_PROGRESS_PENDING(bml_btl);
501498
return OMPI_SUCCESS;
502499
}
503500

@@ -688,9 +685,6 @@ int mca_pml_ob1_send_request_start_rdma( mca_pml_ob1_send_request_t* sendreq,
688685
frag->cbfunc = mca_pml_ob1_rget_completion;
689686
/* do not store the local handle in the fragment. it will be released by mca_pml_ob1_free_rdma_resources */
690687

691-
/* save the fragment for get->put fallback */
692-
sendreq->rdma_frag = frag;
693-
694688
reg_size = bml_btl->btl->btl_registration_handle_size;
695689

696690
/* allocate space for get hdr + segment list */
@@ -699,9 +693,13 @@ int mca_pml_ob1_send_request_start_rdma( mca_pml_ob1_send_request_t* sendreq,
699693
MCA_BTL_DES_FLAGS_SIGNAL);
700694
if( OPAL_UNLIKELY(NULL == des) ) {
701695
/* NTH: no need to reset the converter here. it will be reset before it is retried */
696+
MCA_PML_OB1_RDMA_FRAG_RETURN(frag);
702697
return OMPI_ERR_OUT_OF_RESOURCE;
703698
}
704699

700+
/* save the fragment for get->put fallback */
701+
sendreq->rdma_frag = frag;
702+
705703
/* build match header */
706704
hdr = (mca_pml_ob1_rget_hdr_t *) des->des_segments->seg_addr.pval;
707705
/* TODO -- Add support for multiple segments for get */

0 commit comments

Comments
 (0)