From e8cb5959c63d41d08bf9873f5e7d5463c133bb2f Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Wed, 5 Mar 2025 13:55:05 -0700 Subject: [PATCH 1/2] fix nan comparison test --- quaddtype/tests/test_quaddtype.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/quaddtype/tests/test_quaddtype.py b/quaddtype/tests/test_quaddtype.py index 11cf767..38d32fb 100644 --- a/quaddtype/tests/test_quaddtype.py +++ b/quaddtype/tests/test_quaddtype.py @@ -72,8 +72,10 @@ def test_unary_ops(op, val, expected): def test_nan_and_inf(): - assert (QuadPrecision("nan") != QuadPrecision("nan")) == ( - QuadPrecision("nan") == QuadPrecision("nan")) + # NaN should not equal itself + assert QuadPrecision("nan") != QuadPrecision("nan") + + # Test infinity comparisons assert QuadPrecision("inf") > QuadPrecision("1e1000") assert QuadPrecision("-inf") < QuadPrecision("-1e1000") From ea3653af5d73a4a6d66f64f62d40867217d699d1 Mon Sep 17 00:00:00 2001 From: Nathan Goldbaum Date: Wed, 5 Mar 2025 14:01:59 -0700 Subject: [PATCH 2/2] turn off sanitizers in CI --- .github/workflows/ci.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d0d3249..29527e4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -81,12 +81,12 @@ jobs: then rm -r build fi - meson setup build -Db_sanitize=address,undefined + meson setup build python -m build --no-isolation --wheel -Cbuilddir=build --config-setting='compile-args=-v' -Csetup-args="-Dbuildtype=debug" find ./dist/*.whl | xargs python -m pip install - name: Run stringdtype tests working-directory: stringdtype run: | - ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes + pytest -s -vvv --color=yes pip uninstall -y pandas - ASAN_OPTIONS=detect_leaks=false LD_PRELOAD=/usr/lib/gcc/x86_64-linux-gnu/11/libasan.so pytest -s -vvv --color=yes + pytest -s -vvv --color=yes