Fix error handling in casts

ngoldbaum · ngoldbaum · commit ff238ae7c0e4 · 2023-02-28T14:14:44.000-07:00
diff --git a/stringdtype/stringdtype/src/casts.c b/stringdtype/stringdtype/src/casts.c
@@ -55,7 +55,7 @@ string_to_string(PyArrayMethod_Context *NPY_UNUSED(context),
     while (N--) {
         load_string(in, &s);
         os = (ss *)out;
-        if (ssdup(s, os) == -1) {
+        if (ssdup(s, os) < 0) {
             gil_error(PyExc_MemoryError, "ssdup failed");
             return -1;
         }
@@ -218,7 +218,7 @@ unicode_to_string(PyArrayMethod_Context *context, char *const data[],
             return -1;
         }
         ss *out_ss = (ss *)out;
-        if (ssnewemptylen(out_num_bytes, out_ss) == -1) {
+        if (ssnewemptylen(out_num_bytes, out_ss) < 0) {
             gil_error(PyExc_MemoryError, "ssnewemptylen failed");
             return -1;
         }

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ string_to_string(PyArrayMethod_Context *NPY_UNUSED(context),`
`55`	`55`	`while (N--) {`
`56`	`56`	`load_string(in, &s);`
`57`	`57`	`os = (ss *)out;`
`58`		`- if (ssdup(s, os) == -1) {`
	`58`	`+ if (ssdup(s, os) < 0) {`
`59`	`59`	`gil_error(PyExc_MemoryError, "ssdup failed");`
`60`	`60`	`return -1;`
`61`	`61`	`}`
`@@ -218,7 +218,7 @@ unicode_to_string(PyArrayMethod_Context context, char const data[],`
`218`	`218`	`return -1;`
`219`	`219`	`}`
`220`	`220`	`ss out_ss = (ss )out;`
`221`		`- if (ssnewemptylen(out_num_bytes, out_ss) == -1) {`
	`221`	`+ if (ssnewemptylen(out_num_bytes, out_ss) < 0) {`
`222`	`222`	`gil_error(PyExc_MemoryError, "ssnewemptylen failed");`
`223`	`223`	`return -1;`
`224`	`224`	`}`