respond to code review comments

ngoldbaum · ngoldbaum · commit b68746e052a3 · 2023-02-27T09:27:15.000-07:00
diff --git a/stringdtype/stringdtype/src/dtype.c b/stringdtype/stringdtype/src/dtype.c
@@ -183,6 +183,7 @@ stringdtype_clear_loop(void *NPY_UNUSED(traverse_context),
     while (size--) {
         if (data != NULL) {
             free(*(ss **)data);
+            *(ss **)data = NULL;
         }
         data += stride;
     }
@@ -199,7 +200,7 @@ stringdtype_get_clear_loop(void *NPY_UNUSED(traverse_context),
                            NpyAuxData **NPY_UNUSED(out_auxdata),
                            NPY_ARRAYMETHOD_FLAGS *flags)
 {
-    *flags = NPY_METH_REQUIRES_PYAPI | NPY_METH_NO_FLOATINGPOINT_ERRORS;
+    *flags = NPY_METH_NO_FLOATINGPOINT_ERRORS;
     *out_loop = &stringdtype_clear_loop;
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ stringdtype_clear_loop(void *NPY_UNUSED(traverse_context),`
`183`	`183`	`while (size--) {`
`184`	`184`	`if (data != NULL) {`
`185`	`185`	`free((ss *)data);`
	`186`	`+ (ss *)data = NULL;`
`186`	`187`	`}`
`187`	`188`	`data += stride;`
`188`	`189`	`}`
`@@ -199,7 +200,7 @@ stringdtype_get_clear_loop(void *NPY_UNUSED(traverse_context),`
`199`	`200`	`NpyAuxData **NPY_UNUSED(out_auxdata),`
`200`	`201`	`NPY_ARRAYMETHOD_FLAGS *flags)`
`201`	`202`	`{`
`202`		`- *flags = NPY_METH_REQUIRES_PYAPI \| NPY_METH_NO_FLOATINGPOINT_ERRORS;`
	`203`	`+ *flags = NPY_METH_NO_FLOATINGPOINT_ERRORS;`
`203`	`204`	`*out_loop = &stringdtype_clear_loop;`
`204`	`205`	`return 0;`
`205`	`206`	`}`