respond to code review comments

ngoldbaum · ngoldbaum · commit 69c229e14a28 · 2023-02-23T11:40:17.000-07:00
diff --git a/stringdtype/stringdtype/src/dtype.c b/stringdtype/stringdtype/src/dtype.c
@@ -173,6 +173,7 @@ stringdtype_clear_loop(void *NPY_UNUSED(traverse_context),
     while (size--) {
         if (data != NULL) {
             free(*(ss **)data);
+            *(ss **)data = NULL;
         }
         data += stride;
     }
@@ -189,7 +190,7 @@ stringdtype_get_clear_loop(void *NPY_UNUSED(traverse_context),
                            NpyAuxData **NPY_UNUSED(out_auxdata),
                            NPY_ARRAYMETHOD_FLAGS *flags)
 {
-    *flags = NPY_METH_REQUIRES_PYAPI | NPY_METH_NO_FLOATINGPOINT_ERRORS;
+    *flags = NPY_METH_NO_FLOATINGPOINT_ERRORS;
     *out_loop = &stringdtype_clear_loop;
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -173,6 +173,7 @@ stringdtype_clear_loop(void *NPY_UNUSED(traverse_context),`
`173`	`173`	`while (size--) {`
`174`	`174`	`if (data != NULL) {`
`175`	`175`	`free((ss *)data);`
	`176`	`+ (ss *)data = NULL;`
`176`	`177`	`}`
`177`	`178`	`data += stride;`
`178`	`179`	`}`
`@@ -189,7 +190,7 @@ stringdtype_get_clear_loop(void *NPY_UNUSED(traverse_context),`
`189`	`190`	`NpyAuxData **NPY_UNUSED(out_auxdata),`
`190`	`191`	`NPY_ARRAYMETHOD_FLAGS *flags)`
`191`	`192`	`{`
`192`		`- *flags = NPY_METH_REQUIRES_PYAPI \| NPY_METH_NO_FLOATINGPOINT_ERRORS;`
	`193`	`+ *flags = NPY_METH_NO_FLOATINGPOINT_ERRORS;`
`193`	`194`	`*out_loop = &stringdtype_clear_loop;`
`194`	`195`	`return 0;`
`195`	`196`	`}`