Skip to content

Commit a72b092

Browse files
committed
fix: Flowtype definitions for graphql-compose@3.0.0
1 parent 0277a7f commit a72b092

File tree

5 files changed

+112
-123
lines changed

5 files changed

+112
-123
lines changed

package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"devDependencies": {
2929
"babel-cli": "^6.26.0",
3030
"babel-eslint": "^8.2.1",
31-
"babel-jest": "^22.2.0",
31+
"babel-jest": "^22.2.2",
3232
"babel-plugin-transform-flow-strip-types": "^6.22.0",
3333
"babel-plugin-transform-object-rest-spread": "^6.26.0",
3434
"babel-plugin-transform-runtime": "^6.23.0",
@@ -42,8 +42,8 @@
4242
"eslint-plugin-prettier": "^2.6.0",
4343
"flow-bin": "^0.65.0",
4444
"graphql": "0.13.0",
45-
"graphql-compose": "^3.0.0-beta.3",
46-
"jest": "^22.2.1",
45+
"graphql-compose": "^3.0.0-beta.5",
46+
"jest": "^22.2.2",
4747
"prettier": "^1.10.2",
4848
"rimraf": "^2.6.2",
4949
"semantic-release": "^12.4.1"

src/__tests__/composeWithConnection-test.js

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,14 @@ describe('composeWithRelay', () => {
6464
it('should has ConnectionType as type', () => {
6565
expect(type).toBeTruthy();
6666
expect(tc.getFieldNames()).toEqual(expect.arrayContaining(['count', 'pageInfo', 'edges']));
67-
expect(tc.getFieldType('edges')).toBeInstanceOf(GraphQLNonNull);
68-
expect(tc.getFieldType('edges').ofType).toBeInstanceOf(GraphQLList);
67+
const edgesType: any = tc.getFieldType('edges');
68+
expect(edgesType).toBeInstanceOf(GraphQLNonNull);
69+
expect(edgesType.ofType).toBeInstanceOf(GraphQLList);
6970
});
7071
});
7172

7273
it('should apply first sort ID_ASC by default', async () => {
73-
rootQueryTC.setField(
74-
'userConnection',
75-
userTypeComposer.getResolver('connection').getFieldConfig()
76-
);
74+
rootQueryTC.setField('userConnection', userTypeComposer.getResolver('connection'));
7775
const schema = new GraphQLSchema({
7876
query: rootQueryTC.getType(),
7977
});
@@ -123,10 +121,7 @@ describe('composeWithRelay', () => {
123121
});
124122

125123
it('should able to change `sort` on AGE_ID_DESC', async () => {
126-
rootQueryTC.setField(
127-
'userConnection',
128-
userTypeComposer.getResolver('connection').getFieldConfig()
129-
);
124+
rootQueryTC.setField('userConnection', userTypeComposer.getResolver('connection'));
130125
const schema = new GraphQLSchema({
131126
query: rootQueryTC.getType(),
132127
});
@@ -178,10 +173,7 @@ describe('composeWithRelay', () => {
178173

179174
describe('fragments fields projection of graphql-compose', () => {
180175
it('should return object', async () => {
181-
rootQueryTC.setField(
182-
'userConnection',
183-
userTypeComposer.getResolver('connection').getFieldConfig()
184-
);
176+
rootQueryTC.setField('userConnection', userTypeComposer.getResolver('connection'));
185177
const schema = new GraphQLSchema({
186178
query: rootQueryTC.getType(),
187179
});
@@ -246,14 +238,11 @@ describe('composeWithRelay', () => {
246238

247239
rootQueryTC.setField(
248240
'userConnection',
249-
userTypeComposer
250-
.getResolver('connection')
251-
.wrapResolve(next => rp => {
252-
const result = next(rp);
253-
topResolveParams = rp;
254-
return result;
255-
})
256-
.getFieldConfig()
241+
userTypeComposer.getResolver('connection').wrapResolve(next => rp => {
242+
const result = next(rp);
243+
topResolveParams = rp;
244+
return result;
245+
})
257246
);
258247
const schema = new GraphQLSchema({
259248
query: rootQueryTC.getType(),
@@ -279,14 +268,11 @@ describe('composeWithRelay', () => {
279268

280269
rootQueryTC.setField(
281270
'userConnection',
282-
userTypeComposer
283-
.getResolver('connection')
284-
.wrapResolve(next => rp => {
285-
const result = next(rp);
286-
topResolveParams = rp;
287-
return result;
288-
})
289-
.getFieldConfig()
271+
userTypeComposer.getResolver('connection').wrapResolve(next => rp => {
272+
const result = next(rp);
273+
topResolveParams = rp;
274+
return result;
275+
})
290276
);
291277
const schema = new GraphQLSchema({
292278
query: rootQueryTC.getType(),

src/connectionResolver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ export type PageInfoType = {
6666
export function prepareConnectionResolver<TSource, TContext>(
6767
typeComposer: TypeComposer,
6868
opts: ComposeWithConnectionOpts
69-
): Resolver<TSource, TContext> {
69+
): Resolver {
7070
if (!typeComposer || typeComposer.constructor.name !== 'TypeComposer') {
7171
throw new Error('First arg for prepareConnectionResolver() should be instance of TypeComposer');
7272
}

src/types/__tests__/connectionType-test.js

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ describe('types/connectionType.js', () => {
2525

2626
it('should have field `node` with provided Type', () => {
2727
const tc = new TypeComposer(prepareEdgeType(userTypeComposer));
28-
expect(tc.getFieldType('node')).toBeInstanceOf(GraphQLNonNull);
29-
expect(tc.getFieldType('node').ofType).toBe(userTypeComposer.getType());
28+
const nodeType: any = tc.getFieldType('node');
29+
expect(nodeType).toBeInstanceOf(GraphQLNonNull);
30+
expect(nodeType.ofType).toBe(userTypeComposer.getType());
3031
});
3132

3233
it('should have field `cursor` with GraphQLNonNull(GraphQLString)', () => {
@@ -60,8 +61,9 @@ describe('types/connectionType.js', () => {
6061

6162
it('should have field `count` with provided Type', () => {
6263
const tc = new TypeComposer(prepareConnectionType(userTypeComposer));
63-
expect(tc.getFieldType('count')).toBeInstanceOf(GraphQLNonNull);
64-
expect(tc.getFieldType('count').ofType).toBe(GraphQLInt);
64+
const countType: any = tc.getFieldType('count');
65+
expect(countType).toBeInstanceOf(GraphQLNonNull);
66+
expect(countType.ofType).toBe(GraphQLInt);
6567
});
6668

6769
it('should have field `pageInfo` with GraphQLNonNull(PageInfoType)', () => {
@@ -74,8 +76,9 @@ describe('types/connectionType.js', () => {
7476

7577
it('should have field `edges` with GraphQLList(EdgeType)', () => {
7678
const tc = new TypeComposer(prepareConnectionType(userTypeComposer));
77-
expect(tc.getFieldType('edges')).toBeInstanceOf(GraphQLNonNull);
78-
expect(tc.getFieldType('edges').ofType).toBeInstanceOf(GraphQLList);
79+
const edgesType: any = tc.getFieldType('edges');
80+
expect(edgesType).toBeInstanceOf(GraphQLNonNull);
81+
expect(edgesType.ofType).toBeInstanceOf(GraphQLList);
7982

8083
const edges: any = getNamedType(tc.getFieldType('edges'));
8184
expect(edges.name).toEqual('UserEdge');

0 commit comments

Comments
 (0)