Merge pull request #375 from maxtruxa/issue-372

Implement UnsupportedResponseTypeError

Author: maxtruxa

lib/errors/unsupported-response-type-error.js

@@ -0,0 +1,39 @@
+'use strict';
+
+/**
+ * Module dependencies.
+ */
+
+var _ = require('lodash');
+var OAuthError = require('./oauth-error');
+var util = require('util');
+
+/**
+ * Constructor.
+ *
+ * "The authorization server does not supported obtaining an
+ * authorization code using this method."
+ *
+ * @see https://tools.ietf.org/html/rfc6749#section-4.1.2.1
+ */
+
+function UnsupportedResponseTypeError(message, properties) {
+  properties = _.assign({
+    code: 400,
+    name: 'unsupported_response_type'
+  }, properties);
+
+  OAuthError.call(this, message, properties);
+}
+
+/**
+ * Inherit prototype.
+ */
+
+util.inherits(UnsupportedResponseTypeError, OAuthError);
+
+/**
+ * Export constructor.
+ */
+
+module.exports = UnsupportedResponseTypeError;

lib/handlers/authorize-handler.js

@@ -11,6 +11,7 @@ var InvalidArgumentError = require('../errors/invalid-argument-error');
 var InvalidClientError = require('../errors/invalid-client-error');
 var InvalidRequestError = require('../errors/invalid-request-error');
 var InvalidScopeError = require('../errors/invalid-scope-error');
+var UnsupportedResponseTypeError = require('../errors/unsupported-response-type-error');
 var OAuthError = require('../errors/oauth-error');
 var Promise = require('bluebird');
 var promisify = require('promisify-any').use(Promise);
@@ -275,7 +276,7 @@ AuthorizeHandler.prototype.getResponseType = function(request) {
   }
 
   if (!_.has(responseTypes, responseType)) {
-    throw new InvalidRequestError('Invalid parameter: `response_type`');
+    throw new UnsupportedResponseTypeError('Unsupported response type: `response_type` is not supported');
   }
 
   return responseTypes[responseType];

test/integration/handlers/authorize-handler_test.js

@@ -12,6 +12,7 @@ var InvalidArgumentError = require('../../../lib/errors/invalid-argument-error')
 var InvalidClientError = require('../../../lib/errors/invalid-client-error');
 var InvalidRequestError = require('../../../lib/errors/invalid-request-error');
 var InvalidScopeError = require('../../../lib/errors/invalid-scope-error');
+var UnsupportedResponseTypeError = require('../../../lib/errors/unsupported-response-type-error');
 var Promise = require('bluebird');
 var Request = require('../../../lib/request');
 var Response = require('../../../lib/response');
@@ -382,7 +383,7 @@ describe('AuthorizeHandler integration', function() {
       return handler.handle(request, response)
         .then(should.fail)
         .catch(function() {
-          response.get('location').should.equal('http://example.com/cb?error=invalid_request&error_description=Invalid%20parameter%3A%20%60response_type%60&state=foobar');
+          response.get('location').should.equal('http://example.com/cb?error=unsupported_response_type&error_description=Unsupported%20response%20type%3A%20%60response_type%60%20is%20not%20supported&state=foobar');
         });
     });
 
@@ -417,7 +418,7 @@ describe('AuthorizeHandler integration', function() {
       return handler.handle(request, response)
         .then(should.fail)
         .catch(function() {
-          response.get('location').should.equal('http://example.com/cb?error=invalid_request&error_description=Invalid%20parameter%3A%20%60response_type%60&state=foobar');
+          response.get('location').should.equal('http://example.com/cb?error=unsupported_response_type&error_description=Unsupported%20response%20type%3A%20%60response_type%60%20is%20not%20supported&state=foobar');
         });
     });
 
@@ -998,8 +999,8 @@ describe('AuthorizeHandler integration', function() {
 
         should.fail();
       } catch (e) {
-        e.should.be.an.instanceOf(InvalidRequestError);
-        e.message.should.equal('Invalid parameter: `response_type`');
+        e.should.be.an.instanceOf(UnsupportedResponseTypeError);
+        e.message.should.equal('Unsupported response type: `response_type` is not supported');
       }
     });