Skip to content

Commit e7e2c00

Browse files
authored
Merge pull request #1960 from satra/fix/autotest
cleaned up interfaces
2 parents e1fb595 + dd55a92 commit e7e2c00

File tree

7 files changed

+31
-16
lines changed

7 files changed

+31
-16
lines changed

nipype/interfaces/afni/tests/test_auto_Autobox.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ def test_Autobox_inputs():
2020
),
2121
out_file=dict(argstr='-prefix %s',
2222
name_source='in_file',
23+
name_template='%s_autobox',
2324
),
2425
outputtype=dict(),
2526
padding=dict(argstr='-npad %d',

nipype/interfaces/ants/tests/test_auto_Registration.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,8 @@ def test_Registration_inputs():
104104
use_estimate_learning_rate_once=dict(),
105105
use_histogram_matching=dict(usedefault=True,
106106
),
107+
verbose=dict(argstr='-v',
108+
),
107109
winsorize_lower_quantile=dict(argstr='%s',
108110
usedefault=True,
109111
),

nipype/interfaces/fsl/__init__.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@
1919
SwapDimensions, PowerSpectrum, Reorient2Std,
2020
Complex, InvWarp, WarpUtils, ConvertWarp, WarpPoints,
2121
WarpPointsToStd, RobustFOV, CopyGeom, MotionOutliers)
22-
2322
from .epi import (PrepareFieldmap, TOPUP, ApplyTOPUP, Eddy, EPIDeWarp,
2423
SigLoss, EddyCorrect, EpiReg)
25-
2624
from .dti import (BEDPOSTX, XFibres, DTIFit,
2725
ProbTrackX, ProbTrackX2,
2826
VecReg, ProjThresh, FindTheBiggest, DistanceMap,
@@ -32,5 +30,6 @@
3230
SpatialFilter, UnaryMaths, BinaryMaths, MultiImageMaths,
3331
MaxnImage, MinImage, MedianImage, PercentileImage,
3432
AR1Image)
35-
3633
from .possum import B0Calc
34+
from .fix import (AccuracyTester, Classifier, Cleaner, FeatureExtractor,
35+
Training, TrainingSetCreator)

nipype/interfaces/fsl/fix.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -255,8 +255,8 @@ class CleanerInputSpec(CommandLineInputSpec):
255255
desc='cleanup motion confounds, looks for design.fsf for highpass filter cut-off',
256256
position=2)
257257

258-
highpass = traits.Float(argstr='-m -h %f',
259-
desc='cleanup motion confounds', value=100, position=2)
258+
highpass = traits.Float(100, argstr='-m -h %f', usedefault=True,
259+
desc='cleanup motion confounds', position=2)
260260

261261
aggressive = traits.Bool(argstr='-A',
262262
desc='Apply aggressive (full variance) cleanup, instead of the default less-aggressive (unique variance) cleanup.', position=3)

nipype/interfaces/fsl/tests/test_auto_RobustFOV.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66
def test_RobustFOV_inputs():
77
input_map = dict(args=dict(argstr='%s',
88
),
9+
brainsize=dict(argstr='-b %d',
10+
),
911
environ=dict(nohash=True,
1012
usedefault=True,
1113
),
@@ -21,6 +23,11 @@ def test_RobustFOV_inputs():
2123
name_source=['in_file'],
2224
name_template='%s_ROI',
2325
),
26+
out_transform=dict(argstr='-m %s',
27+
hash_files=False,
28+
name_source=['in_file'],
29+
name_template='%s_to_ROI',
30+
),
2431
output_type=dict(),
2532
terminal_output=dict(nohash=True,
2633
),
@@ -34,6 +41,7 @@ def test_RobustFOV_inputs():
3441

3542
def test_RobustFOV_outputs():
3643
output_map = dict(out_roi=dict(),
44+
out_transform=dict(),
3745
)
3846
outputs = RobustFOV.output_spec()
3947

nipype/interfaces/fsl/utils.py

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -70,25 +70,28 @@ class RobustFOVInputSpec(FSLCommandInputSpec):
7070
out_roi = File(desc="ROI volume output name", argstr="-r %s",
7171
name_source=['in_file'], hash_files=False,
7272
name_template='%s_ROI')
73-
brainsize = traits.Int(170, desc='size of brain in z-dimension (default 170mm/150mm)',
74-
argstr='-b %d', usedefault=False)
75-
out_transform = File(desc="Transformation matrix in_file to out_roi output name", argstr="-m %s",
73+
brainsize = traits.Int(desc=('size of brain in z-dimension (default '
74+
'170mm/150mm)'),
75+
argstr='-b %d')
76+
out_transform = File(desc=("Transformation matrix in_file to out_roi "
77+
"output name"),
78+
argstr="-m %s",
7679
name_source=['in_file'], hash_files=False,
77-
name_template='%s_to_ROI', usedefault=False, mandatatory=False)
80+
name_template='%s_to_ROI')
7881

7982

8083
class RobustFOVOutputSpec(TraitedSpec):
8184
out_roi = File(exists=True, desc="ROI volume output name")
82-
out_transform = File(exists=True, desc="Transformation matrix in_file to out_roi output name")
85+
out_transform = File(exists=True,
86+
desc=("Transformation matrix in_file to out_roi "
87+
"output name"))
8388

8489

8590
class RobustFOV(FSLCommand):
86-
"""robustfov command has been introduced in FSL5. It automatically crops an
87-
image removing lower head and neck.
88-
Input of brainsize in optional (default 170mm/150mm)
89-
Output of ROI and transformation matrix is optional.
90-
Interface is stable 5.0.0 to 5.0.9
91-
But default brainsize changed from 150mm to 170mm.
91+
"""Automatically crops an image removing lower head and neck.
92+
93+
Interface is stable 5.0.0 to 5.0.9, but default brainsize changed from
94+
150mm to 170mm.
9295
"""
9396

9497
_cmd = 'robustfov'

nipype/interfaces/utility/tests/test_auto_Merge.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ def test_Merge_inputs():
1111
),
1212
no_flatten=dict(usedefault=True,
1313
),
14+
ravel_inputs=dict(usedefault=True,
15+
),
1416
)
1517
inputs = Merge.input_spec()
1618

0 commit comments

Comments
 (0)