Skip to content

Commit bdd4d21

Browse files
committed
address ariel comment
1 parent ece338b commit bdd4d21

File tree

4 files changed

+8
-27
lines changed

4 files changed

+8
-27
lines changed

nipype/interfaces/dipy/base.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,11 @@
1010
from ..base import (traits, File, isdefined, LibraryBaseInterface,
1111
BaseInterfaceInputSpec, TraitedSpec)
1212

13+
# List of workflows to ignore
14+
SKIP_WORKFLOWS_LIST = ['Workflow', 'CombinedWorkflow']
15+
1316
HAVE_DIPY = True
17+
1418
try:
1519
import dipy
1620
from dipy.workflows.base import IntrospectiveArgumentParser
@@ -236,4 +240,4 @@ def get_dipy_workflows(module):
236240
return [(m, obj) for m, obj in inspect.getmembers(module)
237241
if inspect.isclass(obj) and
238242
issubclass(obj, module.Workflow) and
239-
m not in ['Workflow', 'CombinedWorkflow']]
243+
m not in SKIP_WORKFLOWS_LIST]

nipype/interfaces/dipy/reconstruction.py

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,18 +24,7 @@
2424

2525
IFLOGGER = logging.getLogger('nipype.interface')
2626

27-
if HAVE_DIPY and (LooseVersion('0.15') >= LooseVersion(dipy_version()) >= LooseVersion('0.16')):
28-
from dipy.workflows.reconst import (ReconstDkiFlow, ReconstCSAFlow,
29-
ReconstCSDFlow, ReconstMAPMRIFlow,
30-
ReconstDtiFlow)
31-
32-
DKIModel = dipy_to_nipype_interface("DKIModel", ReconstDkiFlow)
33-
MapmriModel = dipy_to_nipype_interface("MapmriModel", ReconstMAPMRIFlow)
34-
DTIModel = dipy_to_nipype_interface("DTIModel", ReconstDtiFlow)
35-
CSAModel = dipy_to_nipype_interface("CSAModel", ReconstCSAFlow)
36-
CSDModel = dipy_to_nipype_interface("CSDModel", ReconstCSDFlow)
37-
38-
elif HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('1.0'):
27+
if HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('0.15'):
3928
from dipy.workflows import reconst
4029

4130
l_wkflw = get_dipy_workflows(reconst)

nipype/interfaces/dipy/registration.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,8 @@
66

77
IFLOGGER = logging.getLogger('nipype.interface')
88

9-
if HAVE_DIPY and (LooseVersion('0.15') >= LooseVersion(dipy_version()) >= LooseVersion('0.16')):
109

11-
from dipy.workflows.align import ResliceFlow, SlrWithQbxFlow
12-
13-
Reslice = dipy_to_nipype_interface("Reslice", ResliceFlow)
14-
StreamlineRegistration = dipy_to_nipype_interface("StreamlineRegistration",
15-
SlrWithQbxFlow)
16-
17-
elif HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('1.0'):
10+
if HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('0.15'):
1811
from dipy.workflows import align
1912

2013
l_wkflw = get_dipy_workflows(align)

nipype/interfaces/dipy/tracks.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,15 @@
1818

1919

2020
if HAVE_DIPY and (LooseVersion('0.15') >= LooseVersion(dipy_version()) >= LooseVersion('0.16')):
21-
22-
from dipy.workflows.segment import RecoBundlesFlow, LabelsBundlesFlow
2321
try:
2422
from dipy.workflows.tracking import LocalFiberTrackingPAMFlow as DetTrackFlow
2523
except ImportError: # different name in 0.15
2624
from dipy.workflows.tracking import DetTrackPAMFlow as DetTrackFlow
2725

28-
RecoBundles = dipy_to_nipype_interface("RecoBundles", RecoBundlesFlow)
29-
LabelsBundles = dipy_to_nipype_interface("LabelsBundles",
30-
LabelsBundlesFlow)
3126
DeterministicTracking = dipy_to_nipype_interface("DeterministicTracking",
3227
DetTrackFlow)
3328

34-
elif HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('1.0'):
29+
if HAVE_DIPY and LooseVersion(dipy_version()) >= LooseVersion('0.15'):
3530
from dipy.workflows import segment, tracking
3631

3732
l_wkflw = get_dipy_workflows(segment) + get_dipy_workflows(tracking)

0 commit comments

Comments
 (0)