Skip to content

Commit b345ead

Browse files
committed
Merge remote-tracking branch 'upstream/master' into fix/frompy3
* upstream/master: STYLE: Autogenerated files ignored ENH: More end-of-line whitespace removed. ENH: Improve the removal of trailing whitespace updted changelog remove tests added info about composite transforms BUG: Restore registration interface failed multi-modal STYLE: Remove end of line trailing white space fixed doctests fixed syntax there is always only one composite transform - a list is not appropriate here Current ANTS doctests are only valid for unimodal registrations Revert "BUG: Registration interface failed multi-modal" better handling of errors when using caching out dir for epi_reg is compulsory but meaningless for nipype added circleCI and codacy badges fixed dir making adding tests adding further options to 3drefit
2 parents 012cf2d + 72a2f71 commit b345ead

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

61 files changed

+386
-328
lines changed

.gitignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,6 @@
1414
.pydevproject
1515
.idea/
1616
/documentation.zip
17-
.DS_Store
17+
.DS_Store
18+
nipype/testing/data/von-ray_errmap.nii.gz
19+
nipype/testing/data/von_errmap.nii.gz

.mailmap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Cindee Madison <cindee@berkeley.edu> cindeem
44
Chris Filo Gorgolewski <chris.gorgolewski@gmail.com> filo <filo@filo-Precision-M6500>
55
Chris Filo Gorgolewski <chris.gorgolewski@gmail.com> Krzysztof Gorgolewski <krzysztof.gorgolewski@gmail.com>
66
Erik Ziegler <erik.ziegler@ulg.ac.be> erikz <erik.ziegler@ulg.ac.be>
7-
Michael Waskom <mwaskom@stanford.edu> mwaskom <mwaskom@stanford.edu> Michael Waskom <mwaskom@mit.edu> mwaskom <mwaskom@mit.edu>
7+
Michael Waskom <mwaskom@stanford.edu> mwaskom <mwaskom@stanford.edu> Michael Waskom <mwaskom@mit.edu> mwaskom <mwaskom@mit.edu>
88
Gael Varoquaux <gael.varoquaux@normalesup.org> GaelVaroquaux
99
Gael Varoquaux <gael.varoquaux@normalesup.org> GaelVaroquaux <gael.varoquaux@noramlesup.org>
1010
Daniel Ginsburg <daniel.ginsburg@childrens.harvard.edu> danginsburg <daniel.ginsburg@childrens.harvard.edu>

CHANGES

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
Next release
22
============
33

4+
* ENH: New option in afni.3dRefit - zdel, ydel, zdel etc. (https://github.com/nipy/nipype/pull/1079)
5+
* FIX: ants.Registration composite transform outputs are no longer returned as lists (https://github.com/nipy/nipype/pull/1183)
46
* BUG: ANTs Registration interface failed with multi-modal inputs
57
(https://github.com/nipy/nipype/pull/1176) (https://github.com/nipy/nipype/issues/1175)
68
* FIX: Bug in XFibres5 (https://github.com/nipy/nipype/pull/1168)

Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
PYTHON ?= python
66
NOSETESTS ?= nosetests
77

8+
.PHONY: zipdoc sdist egg upload_to_pypi trailing-spaces clean-pyc clean-so clean-build clean-ctags clean in inplace test-code test-doc test-coverage test html specs check-before-commit check
9+
810
zipdoc: html
911
zip documentation.zip doc/_build/html
1012

@@ -26,7 +28,7 @@ upload_to_pypi: zipdoc
2628
python setup.py sdist --formats=zip,gztar upload
2729

2830
trailing-spaces:
29-
find . -name "*.py" | xargs perl -pi -e 's/[ \t]*$$//'
31+
find . -name "*[.py|.rst]" -type f | xargs perl -pi -e 's/[ \t]*$$//'
3032
@echo "Reverting test_docparse"
3133
git checkout nipype/utils/tests/test_docparse.py
3234

@@ -70,6 +72,7 @@ specs:
7072
@echo "Checking specs and autogenerating spec tests"
7173
python tools/checkspecs.py
7274

75+
check: check-before-commit # just a shortcut
7376
check-before-commit: specs trailing-spaces html test
7477
@echo "removed spaces"
7578
@echo "built docs"

README.rst

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,15 @@ NIPYPE: Neuroimaging in Python: Pipelines and Interfaces
55
.. image:: https://travis-ci.org/nipy/nipype.png?branch=master
66
:target: https://travis-ci.org/nipy/nipype
77

8+
.. image:: https://circleci.com/gh/nipy/nipype/tree/master.svg?style=svg
9+
:target: https://circleci.com/gh/nipy/nipype/tree/master
10+
811
.. image:: https://coveralls.io/repos/nipy/nipype/badge.png
912
:target: https://coveralls.io/r/nipy/nipype
1013

14+
.. image:: https://www.codacy.com/project/badge/182f27944c51474490b369d0a23e2f32
15+
:target: https://www.codacy.com/app/krzysztof-gorgolewski/nipy_nipype
16+
1117
.. image:: https://img.shields.io/pypi/v/nipype.svg
1218
:target: https://pypi.python.org/pypi/nipype/
1319
:alt: Latest Version
@@ -64,7 +70,7 @@ Website
6470
-------
6571

6672
Information specific to Nipype is located here::
67-
73+
6874
http://nipy.org/nipype
6975

7076

@@ -75,10 +81,10 @@ If you have a problem or would like to ask a question about how to do something
7581
to `NeuroStars.org <http://neurostars.org>`_ with a *nipype* tag. `NeuroStars.org <http://neurostars.org>`_ is a platform similar to StackOverflow but dedicated to neuroinformatics. All previous Nipype questions are available here::
7682

7783
http://neurostars.org/t/nipype/
78-
84+
7985

8086
To participate in the Nipype development related discussions please use the following mailing list::
81-
87+
8288
http://mail.python.org/mailman/listinfo/neuroimaging
8389

8490
Please add *[nipype]* to the subject line when posting on the mailing list.
@@ -90,7 +96,7 @@ Nipype structure
9096
Currently Nipype consists of the following files and directories:
9197

9298
INSTALL
93-
NIPYPE prerequisites, installation, development, testing, and
99+
NIPYPE prerequisites, installation, development, testing, and
94100
troubleshooting.
95101

96102
README

THANKS.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -86,15 +86,15 @@ Other contributors
8686
* Mike Trumpis
8787
* Karl Young
8888
* Tom Waite
89-
89+
9090
We would also like to thank `JetBrains <http://www.jetbrains.com/>`__ for providing `Pycharm <http://www.jetbrains.com/pycharm/>`__ licenses.
91-
91+
9292
Funding
9393
-------
9494
Satrajit Ghosh work on this project was partially funded by NIBIB R03 EB008673 (PI: Ghosh and Whitfield-Gabrieli) and by the `INCF <http://www.incf.org>`__ through a contract with TankThink Labs, LLC.
95-
Chris Burns was supported by NIMH grant 5R01MH081909-02 (PI: Desposito). Hans Jonson was supported by
96-
`2 U54 EB005149 - 06 Core 2b Huntington's Disease - Driving Biological Project <http://projectreporter.nih.gov/project_info_description.cfm?aid=8153616&icde=16158743&ddparam=&ddvalue=&ddsub=&cr=18&csb=PT&cs=ASC>`__,
97-
`S10 RR023392 Enterprise Storage In A Collaborative Neuroimaging Environment <http://projectreporter.nih.gov/project_info_description.cfm?aid=7209718&icde=16158552&ddparam=&ddvalue=&ddsub=&cr=1&csb=default&cs=ASC>`__,
98-
`R01 NS040068 Neurobiological Predictors of Huntington's Disease <http://projectreporter.nih.gov/project_info_description.cfm?aid=6266377&icde=16158103>`__,
95+
Chris Burns was supported by NIMH grant 5R01MH081909-02 (PI: Desposito). Hans Jonson was supported by
96+
`2 U54 EB005149 - 06 Core 2b Huntington's Disease - Driving Biological Project <http://projectreporter.nih.gov/project_info_description.cfm?aid=8153616&icde=16158743&ddparam=&ddvalue=&ddsub=&cr=18&csb=PT&cs=ASC>`__,
97+
`S10 RR023392 Enterprise Storage In A Collaborative Neuroimaging Environment <http://projectreporter.nih.gov/project_info_description.cfm?aid=7209718&icde=16158552&ddparam=&ddvalue=&ddsub=&cr=1&csb=default&cs=ASC>`__,
98+
`R01 NS040068 Neurobiological Predictors of Huntington's Disease <http://projectreporter.nih.gov/project_info_description.cfm?aid=6266377&icde=16158103>`__,
9999
and `UL1 TR000442 University of Iowa Clinical and Translational Science Program <http://projectreporter.nih.gov/project_info_description.cfm?aid=8467220&icde=16159156&ddparam=&ddvalue=&ddsub=&cr=1&csb=default&cs=ASC>`__.
100100

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ dependencies:
1818
- sudo apt-key adv --recv-keys --keyserver hkp://pgp.mit.edu:80 0xA5D32F012649A5A9
1919
- sudo apt-get update -y; sudo apt-get install -y fsl-core fsl-atlases
2020
- bash ~/nipype/tools/install_spm_mcr.sh
21-
- mkdir ~/.nipype && echo "[logging]" > ~/.nipype/nipype.cfg && echo "workflow_level = DEBUG" >> ~/.nipype/nipype.cfg && echo "interface_level = DEBUG" >> ~/.nipype/nipype.cfg && echo "filemanip_level = DEBUG" >> ~/.nipype/nipype.cfg
21+
- mkdir -p ~/.nipype && echo "[logging]" > ~/.nipype/nipype.cfg && echo "workflow_level = DEBUG" >> ~/.nipype/nipype.cfg && echo "interface_level = DEBUG" >> ~/.nipype/nipype.cfg && echo "filemanip_level = DEBUG" >> ~/.nipype/nipype.cfg
2222
test:
2323
override:
2424
- . /usr/share/fsl/5.0/etc/fslconf/fsl.sh && nosetests --with-doctest --logging-level=DEBUG --verbosity=3:

doc/README.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Discover available make targets::
1616
make help
1717

1818
Clean up previous build::
19-
19+
2020
make clean
2121

2222
Build html documentation::

doc/devel/gitwash/configure_git.rst

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,15 @@ Here is an example ``.gitconfig`` file::
1616
[user]
1717
name = Your Name
1818
email = you@yourdomain.example.com
19-
19+
2020
[alias]
2121
ci = commit -a
2222
co = checkout
2323
st = status -a
2424
stat = status -a
2525
br = branch
2626
wdiff = diff --color-words
27-
27+
2828
[core]
2929
editor = vim
3030

@@ -33,7 +33,7 @@ Here is an example ``.gitconfig`` file::
3333

3434
You can edit this file directly or you can use the ``git config --global``
3535
command::
36-
36+
3737
git config --global user.name "Your Name"
3838
git config --global user.email you@yourdomain.example.com
3939
git config --global alias.ci "commit -a"

doc/devel/gitwash/development_workflow.rst

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Workflow summary
2222
This way of working really helps to keep work well organized, and in
2323
keeping history as clear as possible.
2424

25-
See |emdash| for example |emdash| `linux git workflow`_.
25+
See |emdash| for example |emdash| `linux git workflow`_.
2626

2727
Making a new feature branch
2828
===========================
@@ -44,7 +44,7 @@ In git >1.7 you can ensure that the link is correctly set by using the
4444
``--set-upstream`` option::
4545

4646
git push --set-upstream origin my-new-feature
47-
47+
4848
From now on git_ will know that ``my-new-feature`` is related to the
4949
``my-new-feature`` branch in the github_ repo.
5050

@@ -83,7 +83,7 @@ In more detail
8383

8484
#. Check what the actual changes are with ``git diff`` (`git diff`_).
8585
#. Add any new files to version control ``git add new_file_name`` (see
86-
`git add`_).
86+
`git add`_).
8787
#. To commit all modified files into the local copy of your repo,, do
8888
``git commit -am 'A commit message'``. Note the ``-am`` options to
8989
``commit``. The ``m`` flag just signals that you're going to type a
@@ -92,7 +92,7 @@ In more detail
9292
description in the `tangled working copy problem`_. The `git commit`_ manual
9393
page might also be useful.
9494
#. To push the changes up to your forked repo on github_, do a ``git
95-
push`` (see `git push`).
95+
push`` (see `git push`).
9696

9797
Asking for code review
9898
======================
@@ -121,7 +121,7 @@ Asking for code review
121121
The generated comparison, is between your feature branch
122122
``my-new-feature``, and the place in ``master`` from which you branched
123123
``my-new-feature``. In other words, you can keep updating ``master``
124-
without interfering with the output from the comparison. More detail?
124+
without interfering with the output from the comparison. More detail?
125125
Note the three dots in the URL above (``master...my-new-feature``).
126126

127127
.. admonition:: Two vs three dots
@@ -165,7 +165,7 @@ When you are ready to ask for the merge of your code:
165165
Merging from trunk
166166
==================
167167

168-
This updates your code from the upstream `nipype github`_ repo.
168+
This updates your code from the upstream `nipype github`_ repo.
169169

170170
Overview
171171
--------

doc/devel/gitwash/git_development.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@ Contents:
1313
set_up_fork
1414
configure_git
1515
development_workflow
16-
16+

doc/devel/gitwash/git_resources.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ Tutorials and summaries
99

1010
* `github help`_ has an excellent series of how-to guides.
1111
* `learn.github`_ has an excellent series of tutorials
12-
* The `pro git book`_ is a good in-depth book on git.
12+
* The `pro git book`_ is a good in-depth book on git.
1313
* A `git cheat sheet`_ is a page giving summaries of common commands.
14-
* The `git user manual`_
14+
* The `git user manual`_
1515
* The `git tutorial`_
1616
* The `git community book`_
1717
* `git ready`_ |emdash| a nice series of tutorials

doc/devel/gitwash/set_up_fork.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
Set up your fork
55
==================
66

7-
First you follow the instructions for :ref:`forking`.
7+
First you follow the instructions for :ref:`forking`.
88

99
Overview
1010
========

doc/devel/index.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ conventions documented in the `NIPY Developers Guide
1515
:maxdepth: 2
1616

1717
writing_custom_interfaces
18-
gitwash/index
18+
gitwash/index
1919
architecture
2020
provenance
2121
software_using_nipype

0 commit comments

Comments
 (0)