using tmpdir.join where its possible (nibabel doesnt like py.path.local)

Author: djarecka

nipype/algorithms/tests/test_mesh_ops.py

@@ -15,14 +15,13 @@
 
 @pytest.mark.skipif(VTKInfo.no_tvtk(), reason="tvtk is not installed")
 def test_ident_distances(tmpdir):
-    tempdir = tmpdir.strpath
-    os.chdir(tempdir)
+    tmpdir.chdir() 
 
     in_surf = example_data('surf01.vtk')
     dist_ident = m.ComputeMeshWarp()
     dist_ident.inputs.surface1 = in_surf
     dist_ident.inputs.surface2 = in_surf
-    dist_ident.inputs.out_file = os.path.join(tempdir, 'distance.npy')
+    dist_ident.inputs.out_file = tmpdir.join('distance.npy')
     res = dist_ident.run()
     assert res.outputs.distance == 0.0
 
@@ -37,7 +36,7 @@ def test_trans_distances(tmpdir):
     from ...interfaces.vtkbase import tvtk
 
     in_surf = example_data('surf01.vtk')
-    warped_surf = os.path.join(tempdir, 'warped.vtk')
+    warped_surf = tmpdir.join('warped.vtk')
 
     inc = np.array([0.7, 0.3, -0.2])
 
@@ -53,7 +52,7 @@ def test_trans_distances(tmpdir):
     dist = m.ComputeMeshWarp()
     dist.inputs.surface1 = in_surf
     dist.inputs.surface2 = warped_surf
-    dist.inputs.out_file = os.path.join(tempdir, 'distance.npy')
+    dist.inputs.out_file = tmpdir.join('distance.npy')
     res = dist.run()
     assert np.allclose(res.outputs.distance, np.linalg.norm(inc), 4)
     dist.inputs.weighting = 'area'

nipype/interfaces/freesurfer/tests/test_model.py

@@ -15,8 +15,9 @@
 
 @pytest.mark.skipif(no_freesurfer(), reason="freesurfer is not installed")
 def test_concatenate(tmpdir):
+    tmpdir.chdir()
+
     tempdir = tmpdir.strpath
-    os.chdir(tempdir)
     in1 = os.path.join(tempdir, 'cont1.nii')
     in2 = os.path.join(tempdir, 'cont2.nii')
     out = 'bar.nii'

nipype/utils/tests/test_provenance.py

@@ -22,7 +22,7 @@ def test_provenance():
 
 def test_provenance_exists(tmpdir):
     tempdir = tmpdir.strpath
-    os.chdir(tempdir)
+    tmpdir.chdir()
     from nipype import config
     from nipype.interfaces.base import CommandLine
     provenance_state = config.get('execution', 'write_provenance')