Skip to content

Commit 9cc27ea

Browse files
author
Ben Cipollini
committed
Implement filename property; prep to get_/set_filename
1 parent 3ea27d1 commit 9cc27ea

File tree

1 file changed

+22
-6
lines changed

1 file changed

+22
-6
lines changed

nibabel/filebasedimages.py

Lines changed: 22 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -229,12 +229,10 @@ def get_header(self):
229229
DeprecationWarning, stacklevel=2)
230230
return self.header
231231

232-
def get_filename(self):
233-
''' Fetch the image filename
232+
@property
233+
def filename(self):
234234

235-
Parameters
236-
----------
237-
None
235+
''' Fetch the image filename
238236
239237
Returns
240238
-------
@@ -251,7 +249,8 @@ def get_filename(self):
251249
characteristic_type = self.files_types[0][0]
252250
return self.file_map[characteristic_type].filename
253251

254-
def set_filename(self, filename):
252+
@filename.setter
253+
def filename(self, filename):
255254
''' Sets the files in the object from a given filename
256255
257256
The different image formats may check whether the filename has
@@ -268,6 +267,23 @@ def set_filename(self, filename):
268267
'''
269268
self.file_map = self.__class__.filespec_to_file_map(filename)
270269

270+
def get_filename(self):
271+
""" Get filename from image
272+
273+
Please use the `filename` property instead of `get_filename`; we will
274+
deprecate this method in future versions of nibabel.
275+
"""
276+
return self.filename
277+
278+
def set_filename(self, filename):
279+
""" Set the image filename
280+
281+
Please use the `filename` property instead of `set_filename`; we will
282+
deprecate this method in future versions of nibabel.
283+
return self.filename
284+
"""
285+
self.filename = filename
286+
271287
@classmethod
272288
def from_filename(klass, filename):
273289
file_map = klass.filespec_to_file_map(filename)

0 commit comments

Comments
 (0)