FIX: LGTM alerts

FIX: LGTM error: Special method has incorrect signature

Too few parameters for special method __getitem__, which has 1 parameter, but should have 2, in class FileBasedImage.

https://lgtm.com/rules/7850093/

FIX: LGTM warning: Unnecessary 'else' clause in loop

This 'for' statement has a redundant 'else' as no 'break' is present in the body.

https://lgtm.com/rules/5980098/

FIX: LGTM warning: Variable defined multiple times

This assignment to 'patient_info' is unnecessary as it is redefined here before this value is used.

https://lgtm.com/rules/1800095/

FIX: LGTM recommendations: Unused import

Import of '...' is not used.

https://lgtm.com/rules/6770079/

Backport of gh-1043

Author: DimitriPapadopoulos

nibabel/cifti2/cifti2.py

@@ -1156,8 +1156,7 @@ def get_index_map(self, index):
             a2md = self._get_indices_from_mim(v)
             if index in a2md:
                 return v
-        else:
-            raise Cifti2HeaderError("Index not mapped")
+        raise Cifti2HeaderError("Index not mapped")
 
     def _validate_new_mim(self, value):
         if value.applies_to_matrix_dimension is None:

nibabel/cmdline/dicomfs.py

@@ -71,7 +71,7 @@ def get_paths(self):
         for study in dft.get_studies(self.dicom_path, self.followlinks):
             pd = paths.setdefault(study.patient_name_or_uid(), {})
             patient_info = 'patient information\n'
-            patient_info = f'name: {study.patient_name}\n'
+            patient_info += f'name: {study.patient_name}\n'
             patient_info += f'ID: {study.patient_id}\n'
             patient_info += f'birth date: {study.patient_birth_date}\n'
             patient_info += f'sex: {study.patient_sex}\n'

nibabel/filebasedimages.py

@@ -202,7 +202,7 @@ def __init__(self, header=None, extra=None, file_map=None):
     def header(self):
         return self._header
 
-    def __getitem__(self):
+    def __getitem__(self, key):
         """ No slicing or dictionary interface for images
         """
         raise TypeError("Cannot slice image objects.")

nibabel/pydicom_compat.py

@@ -23,7 +23,6 @@
 # Module has (apparently) unused imports; stop flake8 complaining
 # flake8: noqa
 
-import numpy as np
 from .deprecated import deprecate_with_version
 
 have_dicom = True

nisext/py3builder.py

@@ -1,9 +1,6 @@
 """ distutils utilities for porting to python 3 within 2-compatible tree """
 
 
-import sys
-import re
-
 try:
     from distutils.command.build_py import build_py_2to3
 except ImportError:

setup.py

@@ -10,7 +10,6 @@
 """Build helper."""
 
 import sys
-import os
 
 from setuptools import setup
 import versioneer

tools/make_tarball.py

@@ -4,8 +4,6 @@
 
 import commands
 import os
-import sys
-import shutil
 
 from  toollib import *
 

tools/mpkg_wrapper.py

@@ -16,8 +16,6 @@
 __docformat__ = 'restructuredtext'
 
 import sys
-import setuptools
-import bdist_mpkg
 
 def main():
     del sys.argv[0]