Skip to content

Commit 3aa7b13

Browse files
committed
Fix regression
1 parent 6022d3f commit 3aa7b13

File tree

3 files changed

+7
-9
lines changed

3 files changed

+7
-9
lines changed

Zend/Optimizer/dfa_pass.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1111,7 +1111,6 @@ static void zend_dfa_optimize_send_copies(zend_op_array *op_array, zend_ssa *ssa
11111111
if (ssa_var->no_val && !ssa_var->alias) {
11121112
/* Flag will be used by VM type spec handler */
11131113
opline->extended_value = 1;
1114-
// fprintf(stderr, "optimize\n");
11151114
}
11161115
}
11171116
}

Zend/Optimizer/sccp.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2201,8 +2201,6 @@ static int try_remove_definition(sccp_ctx *ctx, int var_num, zend_ssa_var *var,
22012201
}
22022202

22032203
if (opline->opcode == ZEND_SEND_VAR) {
2204-
opline->extended_value = 0;
2205-
zend_ssa_replace_op1_def_op1_use(ssa, ssa_op);
22062204
return 0;
22072205
}
22082206

@@ -2349,7 +2347,7 @@ static int replace_constant_operands(sccp_ctx *ctx) {
23492347
zend_op *opline = &op_array->opcodes[use];
23502348
zend_ssa_op *ssa_op = &ssa->ops[use];
23512349
if (opline->opcode == ZEND_SEND_VAR && ssa_op->op1_use == i && ssa_op->op1_def >= 0) {
2352-
// zend_ssa_replace_op1_def_op1_use(ssa, ssa_op);
2350+
zend_ssa_replace_op1_def_op1_use(ssa, ssa_op);
23532351
}
23542352
if (try_replace_op1(ctx, opline, ssa_op, i, value)) {
23552353
if (opline->opcode == ZEND_NOP) {

benchmark/benchmark.php

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,12 @@ function main() {
1313
global $storeResult;
1414

1515
$data = [];
16-
$data['Zend/bench.php'] = runBench(false);
16+
/* $data['Zend/bench.php'] = runBench(false);
1717
$data['Zend/bench.php JIT'] = runBench(true);
1818
$data['Symfony Demo 2.2.3'] = runSymfonyDemo(false);
19-
$data['Symfony Demo 2.2.3 JIT'] = runSymfonyDemo(true);
19+
$data['Symfony Demo 2.2.3 JIT'] = runSymfonyDemo(true);*/
2020
$data['Wordpress 6.2'] = runWordpress(false);
21-
$data['Wordpress 6.2 JIT'] = runWordpress(true);
21+
// $data['Wordpress 6.2 JIT'] = runWordpress(true);
2222
$result = json_encode($data, JSON_PRETTY_PRINT) . "\n";
2323

2424
fwrite(STDOUT, $result);
@@ -78,7 +78,7 @@ function runWordpress(bool $jit): array {
7878

7979
// Warmup
8080
runPhpCommand([$dir . '/index.php'], $dir);
81-
return runValgrindPhpCgiCommand([$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 50, repeat: 50);
81+
return runValgrindPhpCgiCommand([$dir . '/index.php'], cwd: $dir, jit: $jit, warmup: 2, repeat: 2);
8282
}
8383

8484
function runPhpCommand(array $args, ?string $cwd = null): ProcessResult {
@@ -97,11 +97,12 @@ function runValgrindPhpCgiCommand(
9797
'valgrind',
9898
'--tool=callgrind',
9999
'--dump-instr=yes',
100-
'--callgrind-out-file=/dev/null',
100+
//'--callgrind-out-file=/dev/null',
101101
'--',
102102
$phpCgi,
103103
'-T' . ($warmup ? $warmup . ',' : '') . $repeat,
104104
'-d max_execution_time=0',
105+
'-c', '/run/media/niels/MoreData/php-src',
105106
'-d opcache.enable=1',
106107
'-d opcache.jit_buffer_size=' . ($jit ? '128M' : '0'),
107108
'-d opcache.validate_timestamps=0',

0 commit comments

Comments
 (0)