ext/intl IntlChar::enumCharNames changes the signature to void.

Close phpGH-10904

Author: devnexen

NEWS

@@ -56,6 +56,7 @@ PHP                                                                        NEWS
   . Updated datefmt_set_timezone/IntlDateformatter::setTimezone returns type.
     (David Carlier).
   . Updated IntlBreakInterator::setText return type. (David Carlier)
+  . Updated IntlChar::enumCharNames return type. (David Carlier)
 
 - JSON:
   . Added json_validate(). (Juan Morales)

UPGRADING

@@ -87,6 +87,9 @@ PHP 8.3 UPGRADE NOTES
     now returns true on success, previously null was returned.
   . IntlBreakiterator::setText() now returns false on failure, previously
     null was returned.
+    now returns true on sucess, previously null was returned.
+  . IntlChar::enumCharNames is now returning a boolean.
+    Previously it returned null on success and false on failure.
 
 - MBString:
   . mb_strtolower, mb_strtotitle, and mb_convert_case implement conditional

ext/intl/uchar/uchar.c

@@ -309,11 +309,12 @@ IC_METHOD(enumCharNames) {
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (convert_cp(&start, string_start, int_start) == FAILURE || convert_cp(&limit, string_limit, int_limit) == FAILURE) {
-		RETURN_NULL();
+		RETURN_FALSE;
 	}
 
 	u_enumCharNames(start, limit, (UEnumCharNamesFn*)enumCharNames_callback, &context, nameChoice, &error);
 	INTL_CHECK_STATUS(error, NULL);
+	RETURN_TRUE;
 }
 /* }}} */
 

ext/intl/uchar/uchar.stub.php

@@ -3411,7 +3411,7 @@ public static function chr(int|string $codepoint): ?string {}
     public static function digit(int|string $codepoint, int $base = 10): int|false|null {}
 
     /** @tentative-return-type */
-    public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): ?bool {} // TODO return values just don't make sense
+    public static function enumCharNames(int|string $start, int|string $end, callable $callback, int $type = IntlChar::UNICODE_CHAR_NAME): bool {}
 
     /** @tentative-return-type */
     public static function enumCharTypes(callable $callback): void {}