From 13dcf04c6eb5d12d6bc8ddae0717266599e026f5 Mon Sep 17 00:00:00 2001
From: sashakboo <31510839+sashakboo@users.noreply.github.com>
Date: Wed, 21 Jun 2023 10:59:12 +0400
Subject: [PATCH] test for issue with nosetter.pascalcase-underscore

---
 .../Async/LazyProperty/LazyPropertyFixture.cs | 26 +++++++++++++++++++
 src/NHibernate.Test/LazyProperty/Book.cs      |  8 ++++++
 .../LazyProperty/LazyPropertyFixture.cs       | 26 +++++++++++++++++++
 .../LazyProperty/Mappings.hbm.xml             |  1 +
 4 files changed, 61 insertions(+)

diff --git a/src/NHibernate.Test/Async/LazyProperty/LazyPropertyFixture.cs b/src/NHibernate.Test/Async/LazyProperty/LazyPropertyFixture.cs
index e7714c07a49..29d43d99b04 100644
--- a/src/NHibernate.Test/Async/LazyProperty/LazyPropertyFixture.cs
+++ b/src/NHibernate.Test/Async/LazyProperty/LazyPropertyFixture.cs
@@ -67,6 +67,7 @@ protected override void OnSetUp()
 					Id = 1,
 					ALotOfText = "a lot of text ...",
 					Image = new byte[10],
+					NoSetterImage = new byte[10],
 					FieldInterceptor = "Why not that name?"
 				});
 				tx.Commit();
@@ -391,5 +392,30 @@ public async Task CanMergeTransientWithLazyPropertyInCollectionAsync()
 				Assert.That(book.Words.First().Content, Is.EqualTo(new byte[1] { 0 }));
 			}
 		}
+
+		[Test]
+		public async Task GetLazyPropertyWithNoSetterAccessor_PropertyShouldBeInitializedAsync()
+		{
+			using (ISession s = OpenSession())
+			{
+				var book = await (s.GetAsync<Book>(1));
+				var image = book.NoSetterImage;
+				// Fails. Property remains uninitialized after it has been accessed.
+				Assert.That(NHibernateUtil.IsPropertyInitialized(book, "NoSetterImage"), Is.True);
+			}
+		}
+
+		[Test]
+		public async Task GetLazyPropertyWithNoSetterAccessorTwice_ResultsAreSameObjectAsync()
+		{
+			using (ISession s = OpenSession())
+			{
+				var book = await (s.GetAsync<Book>(1));
+				var image = book.NoSetterImage;
+				var sameImage = book.NoSetterImage;
+				// Fails. Each call to a property getter returns a new object.
+				Assert.That(ReferenceEquals(image, sameImage), Is.True);
+			}
+		}
 	}
 }
diff --git a/src/NHibernate.Test/LazyProperty/Book.cs b/src/NHibernate.Test/LazyProperty/Book.cs
index 546df8a248b..3dcfe73c567 100644
--- a/src/NHibernate.Test/LazyProperty/Book.cs
+++ b/src/NHibernate.Test/LazyProperty/Book.cs
@@ -17,6 +17,14 @@ public virtual string ALotOfText
 
 		public virtual byte[] Image { get; set; }
 
+		private byte[] _NoSetterImage;
+
+		public virtual byte[] NoSetterImage
+		{
+			get { return _NoSetterImage; }
+			set { _NoSetterImage = value; }
+		}
+
 		public virtual string FieldInterceptor { get; set; }
 
 		public virtual IList<Word> Words { get; set; }
diff --git a/src/NHibernate.Test/LazyProperty/LazyPropertyFixture.cs b/src/NHibernate.Test/LazyProperty/LazyPropertyFixture.cs
index 5efb7d6e29d..5d53b202dff 100644
--- a/src/NHibernate.Test/LazyProperty/LazyPropertyFixture.cs
+++ b/src/NHibernate.Test/LazyProperty/LazyPropertyFixture.cs
@@ -55,6 +55,7 @@ protected override void OnSetUp()
 					Id = 1,
 					ALotOfText = "a lot of text ...",
 					Image = new byte[10],
+					NoSetterImage = new byte[10],
 					FieldInterceptor = "Why not that name?"
 				});
 				tx.Commit();
@@ -385,5 +386,30 @@ public void CanMergeTransientWithLazyPropertyInCollection()
 				Assert.That(book.Words.First().Content, Is.EqualTo(new byte[1] { 0 }));
 			}
 		}
+
+		[Test]
+		public void GetLazyPropertyWithNoSetterAccessor_PropertyShouldBeInitialized()
+		{
+			using (ISession s = OpenSession())
+			{
+				var book = s.Get<Book>(1);
+				var image = book.NoSetterImage;
+				// Fails. Property remains uninitialized after it has been accessed.
+				Assert.That(NHibernateUtil.IsPropertyInitialized(book, "NoSetterImage"), Is.True);
+			}
+		}
+
+		[Test]
+		public void GetLazyPropertyWithNoSetterAccessorTwice_ResultsAreSameObject()
+		{
+			using (ISession s = OpenSession())
+			{
+				var book = s.Get<Book>(1);
+				var image = book.NoSetterImage;
+				var sameImage = book.NoSetterImage;
+				// Fails. Each call to a property getter returns a new object.
+				Assert.That(ReferenceEquals(image, sameImage), Is.True);
+			}
+		}
 	}
 }
diff --git a/src/NHibernate.Test/LazyProperty/Mappings.hbm.xml b/src/NHibernate.Test/LazyProperty/Mappings.hbm.xml
index 91189c36e30..533576580cd 100644
--- a/src/NHibernate.Test/LazyProperty/Mappings.hbm.xml
+++ b/src/NHibernate.Test/LazyProperty/Mappings.hbm.xml
@@ -11,6 +11,7 @@
 		<property name="Name" />
 		<property name="ALotOfText" lazy="true" />
 		<property name="Image" lazy="true" />
+		<property name="NoSetterImage" access="nosetter.pascalcase-underscore" lazy="true" />
 		<property name="FieldInterceptor" />
     <bag name="Words" inverse="true" generic="true" cascade="all-delete-orphan" lazy="true" >
       <key column="ParentId" />