From 016a9cb467bbac2ee26bd11f2a492fbd5376a01f Mon Sep 17 00:00:00 2001 From: Roman Artiukhin Date: Wed, 17 Aug 2022 13:43:13 +0300 Subject: [PATCH] Simplify SqlGenerator.FromFragmentSeparator --- src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.cs | 29 +++----------------- 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.cs b/src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.cs index 20e05086d2a..b99dd2b9387 100644 --- a/src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.cs +++ b/src/NHibernate/Hql/Ast/ANTLR/SqlGenerator.cs @@ -183,8 +183,7 @@ protected virtual void FromFragmentSeparator(IASTNode a) return; } - var left = (FromElement)a; - var right = (FromElement)next; + var right = (FromElement) next; /////////////////////////////////////////////////////////////////////// // HACK ALERT !!!!!!!!!!!!!!!!!!!!!!!!!!!! @@ -210,34 +209,14 @@ protected virtual void FromFragmentSeparator(IASTNode a) { return; } - if (right.Type == ENTITY_JOIN) + + if (right.JoinSequence?.IsThetaStyle == false && right.JoinSequence.JoinCount != 0) { Out(" "); } - else if (right.RealOrigin == left || (right.RealOrigin != null && right.RealOrigin == left.RealOrigin)) - { - // right represents a joins originating from left; or - // both right and left reprersent joins originating from the same FromElement - if (right.JoinSequence != null && right.JoinSequence.IsThetaStyle) - { - Out(", "); - } - else - { - Out(" "); - } - } else { - if (right.JoinSequence?.IsThetaStyle == false && right.JoinSequence.JoinCount != 0) - { - Out(" "); - } - else - { - // these are just two unrelated table references - Out(", "); - } + Out(", "); } }