Skip to content

Commit f0b1c55

Browse files
committed
fixup! Initialize collections on demand
1 parent 6b8bb07 commit f0b1c55

File tree

2 files changed

+8
-24
lines changed

2 files changed

+8
-24
lines changed

src/NHibernate/Action/BulkOperationCleanupAction.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ public BulkOperationCleanupAction(ISessionImplementor session, ISet<string> quer
6666
{
6767
//from H3.2 TODO: cache the autodetected information and pass it in instead.
6868
_factory = session.Factory;
69-
_affectedEntityNames = new HashSet<string>();
70-
_affectedCollectionRoles = new HashSet<string>();
7169

7270
var tmpSpaces = new HashSet<string>(querySpaces);
7371
var acmd = _factory.GetAllClassMetadata();
@@ -157,15 +155,15 @@ public void ExecuteAfterTransactionCompletion(bool success)
157155

158156
private void EvictCollectionRegions()
159157
{
160-
if (_affectedCollectionRoles != null && _affectedCollectionRoles.Any())
158+
if (_affectedCollectionRoles != null)
161159
{
162160
_factory.EvictCollection(_affectedCollectionRoles);
163161
}
164162
}
165163

166164
private void EvictEntityRegions()
167165
{
168-
if (_affectedEntityNames != null && _affectedEntityNames.Any())
166+
if (_affectedEntityNames != null)
169167
{
170168
_factory.EvictEntity(_affectedEntityNames);
171169
}

src/NHibernate/Async/Action/BulkOperationCleanupAction.cs

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -75,18 +75,11 @@ private Task EvictCollectionRegionsAsync(CancellationToken cancellationToken)
7575
{
7676
return Task.FromCanceled<object>(cancellationToken);
7777
}
78-
try
79-
{
80-
if (_affectedCollectionRoles != null && _affectedCollectionRoles.Any())
81-
{
82-
return _factory.EvictCollectionAsync(_affectedCollectionRoles, cancellationToken);
83-
}
84-
return Task.CompletedTask;
85-
}
86-
catch (Exception ex)
78+
if (_affectedCollectionRoles != null)
8779
{
88-
return Task.FromException<object>(ex);
80+
return _factory.EvictCollectionAsync(_affectedCollectionRoles, cancellationToken);
8981
}
82+
return Task.CompletedTask;
9083
}
9184

9285
private Task EvictEntityRegionsAsync(CancellationToken cancellationToken)
@@ -95,18 +88,11 @@ private Task EvictEntityRegionsAsync(CancellationToken cancellationToken)
9588
{
9689
return Task.FromCanceled<object>(cancellationToken);
9790
}
98-
try
99-
{
100-
if (_affectedEntityNames != null && _affectedEntityNames.Any())
101-
{
102-
return _factory.EvictEntityAsync(_affectedEntityNames, cancellationToken);
103-
}
104-
return Task.CompletedTask;
105-
}
106-
catch (Exception ex)
91+
if (_affectedEntityNames != null)
10792
{
108-
return Task.FromException<object>(ex);
93+
return _factory.EvictEntityAsync(_affectedEntityNames, cancellationToken);
10994
}
95+
return Task.CompletedTask;
11096
}
11197

11298
#endregion

0 commit comments

Comments
 (0)