Skip to content

Commit f093f17

Browse files
committed
Review suggestion
1 parent effc1db commit f093f17

File tree

1 file changed

+7
-12
lines changed

1 file changed

+7
-12
lines changed

src/NHibernate/Criterion/PropertyExpression.cs

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -75,22 +75,17 @@ public override SqlString ToSqlString(ICriteria criteria, ICriteriaQuery criteri
7575
var otherColumnNames =
7676
CriterionUtil.GetColumnNamesAsSqlStringParts(_rhsPropertyName, _rhsProjection, criteriaQuery, criteria);
7777

78-
switch (columnNames.Length)
79-
{
80-
case 1:
81-
return new SqlString(columnNames[0], Op, otherColumnNames[0]);
82-
case 0:
83-
return SqlString.Empty;
84-
}
78+
if (columnNames.Length == 0)
79+
return SqlString.Empty;
80+
if (columnNames.Length == 1)
81+
return new SqlString(columnNames[0], Op, otherColumnNames[0]);
8582

8683
var sb = new SqlStringBuilder();
8784
sb.Add(StringHelper.OpenParen);
88-
89-
for (var i = 0; i < columnNames.Length; i++)
85+
sb.AddObject(columnNames[0]).Add(Op).AddObject(otherColumnNames[0]);
86+
for (var i = 1; i < columnNames.Length; i++)
9087
{
91-
if (i != 0)
92-
sb.Add(" and ");
93-
88+
sb.Add(" and ");
9489
sb.AddObject(columnNames[i]).Add(Op).AddObject(otherColumnNames[i]);
9590
}
9691
sb.Add(StringHelper.ClosedParen);

0 commit comments

Comments
 (0)