Restrict a test to SQL-Server.

Author: fredericDelaporte

src/NHibernate.Test/Async/NHSpecificTest/SqlConverterAndMultiQuery/Fixture.cs

@@ -10,6 +10,7 @@
 
 using NHibernate.Cfg;
 using NHibernate.Dialect;
+using NHibernate.Util;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.SqlConverterAndMultiQuery
@@ -27,9 +28,12 @@ protected override void Configure(Configuration configuration)
 
 		protected override bool AppliesTo(Dialect.Dialect dialect)
 		{
-			// MsSqlCe throws InvalidOperationException instead of a DbException for these tests, preventing
+			// If prepare_sql is enabled, with most databases prepare will fail with an InvalidOperationException,
+			// turned into ADOException by prepare code and then not passed to the exception converter.
+			// MsSqlCe throws InvalidOperationException during Prepare (even when disabled), preventing
 			// the test SqlConverter to do its job.
-			return !(Dialect is MsSqlCeDialect);
+			var prepareSql = PropertiesHelper.GetBoolean(Environment.PrepareSql, cfg.Properties, false);
+			return !(prepareSql || Dialect is MsSqlCeDialect);
 		}
 
 		[Test]

src/NHibernate.Test/NHSpecificTest/SqlConverterAndMultiQuery/Fixture.cs

@@ -1,5 +1,6 @@
 using NHibernate.Cfg;
-using NHibernate.Dialect;
+using NHibernate.Driver;
+using NHibernate.Engine;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.SqlConverterAndMultiQuery
@@ -14,11 +15,13 @@ protected override void Configure(Configuration configuration)
 			configuration.DataBaseIntegration(x => x.ExceptionConverter<SqlConverter>());
 		}
 
-		protected override bool AppliesTo(Dialect.Dialect dialect)
+		protected override bool AppliesTo(ISessionFactoryImplementor factory)
 		{
-			// MsSqlCe throws InvalidOperationException instead of a DbException for these tests, preventing
-			// the test SqlConverter to do its job.
-			return !(Dialect is MsSqlCeDialect);
+			// Test current implementation allows to test mmostly SQL Server. Other databases
+			// tend to (validly) send InvalidOperationException during prepare phase due to the closed
+			// connection, which get not converted. For testing other case, maybe a failure caused by a
+			// schema mismatch (like done in transaction tests) would be better.
+			return factory.ConnectionProvider.Driver is SqlClientDriver;
 		}
 
 		[Test]