NH-2207 - Enable tests for Sql2008ClientDriver

NH-1754 - More edge cases

Author: hazzik

src/NHibernate.Test/Async/NHSpecificTest/NH2207/SampleTest.cs

@@ -0,0 +1,107 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by AsyncGenerator.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+
+using System;
+using System.Data;
+using NHibernate.Dialect;
+using NHibernate.Driver;
+using NHibernate.Engine;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH2207
+{
+	using System.Threading.Tasks;
+	using System.Threading;
+	[TestFixture]
+	public class SampleTestAsync : BugTestCase
+	{
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return dialect is MsSql2008Dialect;
+		}
+
+		protected override bool AppliesTo(ISessionFactoryImplementor factory)
+		{
+			return factory.ConnectionProvider.Driver is Sql2008ClientDriver;
+		}
+
+		[Test]
+		public async Task WithoutUseNHSqlDataProviderWorkProperlyAsync()
+		{
+			var createTable = "CREATE TABLE TryDate([Id] [int] IDENTITY(1,1) NOT NULL,[MyDate] [date] NOT NULL)";
+			var dropTable = "DROP TABLE TryDate";
+			var insertTable = "INSERT INTO TryDate([MyDate]) VALUES(@p0)";
+			using(var sqlConnection = new System.Data.SqlClient.SqlConnection(cfg.Properties[Cfg.Environment.ConnectionString]))
+			{
+				await (sqlConnection.OpenAsync(CancellationToken.None));
+				using (var tx = sqlConnection.BeginTransaction())
+				{
+					var command = sqlConnection.CreateCommand();
+					command.Transaction = tx;
+					command.CommandText = createTable;
+					await (command.ExecuteNonQueryAsync(CancellationToken.None));
+					tx.Commit();
+				}
+
+				try
+				{
+					using (var tx = sqlConnection.BeginTransaction())
+					{
+						var command = sqlConnection.CreateCommand();
+						command.Transaction = tx;
+						command.CommandText = insertTable;
+						var dateParam = command.CreateParameter();
+						dateParam.ParameterName = "@p0";
+						dateParam.DbType = DbType.Date;
+						dateParam.SqlDbType = SqlDbType.Date;
+						dateParam.Value = DateTime.MinValue.Date;
+						command.Parameters.Add(dateParam);
+						await (command.ExecuteNonQueryAsync(CancellationToken.None));
+						tx.Commit();
+					}
+				}
+				finally
+				{
+					using (var tx = sqlConnection.BeginTransaction())
+					{
+						var command = sqlConnection.CreateCommand();
+						command.Transaction = tx;
+						command.CommandText = dropTable;
+						await (command.ExecuteNonQueryAsync(CancellationToken.None));
+						tx.Commit();
+					}
+				}
+			}
+		}
+
+		[Test]
+		public async Task Dates_Before_1753_Should_Not_Insert_NullAsync()
+		{
+			object savedId;
+			var expectedStoredValue = DateTime.MinValue.Date.AddDays(1).Date;
+			using (ISession session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var concrete = new DomainClass{Date = expectedStoredValue.AddMinutes(90)};
+				savedId = await (session.SaveAsync(concrete));
+				await (tx.CommitAsync());
+			}
+
+			using (ISession session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				var savedObj = await (session.GetAsync<DomainClass>(savedId));
+				Assert.That(savedObj.Date, Is.EqualTo(expectedStoredValue));
+				await (session.DeleteAsync(savedObj));
+				await (tx.CommitAsync());
+			}
+		}
+	}
+}

src/NHibernate.Test/Async/TypesTest/DateTypeTest.cs

@@ -57,6 +57,24 @@ public Task ReadWriteMinAsync()
 			}
 		}
 
+		[Test]
+		public Task ReadWriteYear750Async()
+		{
+			try
+			{
+				var expected = new DateTime(750, 5, 13);
+				if (Sfi.ConnectionProvider.Driver.MinDate > expected)
+				{
+					Assert.Ignore($"The driver does not support dates below {Sfi.ConnectionProvider.Driver.MinDate:O}");
+				}
+				return ReadWriteAsync(expected);
+			}
+			catch (Exception ex)
+			{
+				return Task.FromException<object>(ex);
+			}
+		}
+
 		private async Task ReadWriteAsync(DateTime expected, CancellationToken cancellationToken = default(CancellationToken))
 		{
 			// Add an hour to check it is correctly ignored once read back from db.

src/NHibernate.Test/NHSpecificTest/NH2207/SampleTest.cs

@@ -1,16 +1,23 @@
 using System;
 using System.Data;
 using NHibernate.Dialect;
+using NHibernate.Driver;
+using NHibernate.Engine;
 using NUnit.Framework;
 
 namespace NHibernate.Test.NHSpecificTest.NH2207
 {
-	[TestFixture, Ignore("Demostration of external issue")]
+	[TestFixture]
 	public class SampleTest : BugTestCase
 	{
 		protected override bool AppliesTo(Dialect.Dialect dialect)
 		{
-			return dialect as MsSql2008Dialect != null;
+			return dialect is MsSql2008Dialect;
+		}
+
+		protected override bool AppliesTo(ISessionFactoryImplementor factory)
+		{
+			return factory.ConnectionProvider.Driver is Sql2008ClientDriver;
 		}
 
 		[Test]
@@ -41,6 +48,7 @@ public void WithoutUseNHSqlDataProviderWorkProperly()
 						var dateParam = command.CreateParameter();
 						dateParam.ParameterName = "@p0";
 						dateParam.DbType = DbType.Date;
+						dateParam.SqlDbType = SqlDbType.Date;
 						dateParam.Value = DateTime.MinValue.Date;
 						command.Parameters.Add(dateParam);
 						command.ExecuteNonQuery();
@@ -56,10 +64,9 @@ public void WithoutUseNHSqlDataProviderWorkProperly()
 						command.CommandText = dropTable;
 						command.ExecuteNonQuery();
 						tx.Commit();
-					}					
+					}
 				}
 			}
-
 		}
 
 		[Test]
@@ -85,4 +92,4 @@ public void Dates_Before_1753_Should_Not_Insert_Null()
 			}
 		}
 	}
-}
+}

src/NHibernate.Test/TypesTest/DateTypeTest.cs

@@ -67,6 +67,17 @@ public void ReadWriteMin()
 			ReadWrite(expected);
 		}
 
+		[Test]
+		public void ReadWriteYear750()
+		{
+			var expected = new DateTime(750, 5, 13);
+			if (Sfi.ConnectionProvider.Driver.MinDate > expected)
+			{
+				Assert.Ignore($"The driver does not support dates below {Sfi.ConnectionProvider.Driver.MinDate:O}");
+			}
+			ReadWrite(expected);
+		}
+
 		private void ReadWrite(DateTime expected)
 		{
 			// Add an hour to check it is correctly ignored once read back from db.