Skip to content

Commit d18b50e

Browse files
committed
Minor fixes
1 parent db2155e commit d18b50e

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

src/NHibernate.Test/Linq/ByMethod/JoinTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ public void LeftJoinExtensionMethodWithOuterReferenceInWhereClauseOnly()
120120
}
121121
}
122122

123-
[KnownBug("GH-XXXX")]
123+
[KnownBug("GH-2379")]
124124
public void NestedLeftJoinExtensionMethodWithOuterReferenceInWhereClauseOnly()
125125
{
126126
using (var sqlSpy = new SqlLogSpy())
@@ -143,14 +143,13 @@ public void NestedLeftJoinExtensionMethodWithOuterReferenceInWhereClauseOnly()
143143
.Select(x => new { SerialNumber = x.animal2.SerialNumber })
144144
.ToList();
145145

146-
147146
var sql = sqlSpy.GetWholeLog();
148147
Assert.That(animals.Count, Is.EqualTo(1));
149148
Assert.That(GetTotalOccurrences(sql, "left outer join"), Is.EqualTo(1));
150149
}
151150
}
152151

153-
[KnownBug("GH-XXXX")]
152+
[KnownBug("GH-2738")]
154153
public void LeftJoinExtensionMethodWithNoUseOfOuterReference()
155154
{
156155
using (var sqlSpy = new SqlLogSpy())

src/NHibernate/Linq/GroupJoin/GroupJoinAggregateDetectionQueryModelVisitor.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ private GroupJoinAggregateDetectionQueryModelVisitor(IEnumerable<GroupJoinClause
1616
{
1717
_groupJoinClauses = new HashSet<GroupJoinClause>(groupJoinClauses);
1818
}
19-
2019
public static IsAggregatingResults Visit(IEnumerable<GroupJoinClause> groupJoinClause, QueryModel queryModel)
2120
{
2221
var visitor = new GroupJoinAggregateDetectionQueryModelVisitor(groupJoinClause);
@@ -30,7 +29,6 @@ public override void VisitWhereClause(WhereClause whereClause, QueryModel queryM
3029
var results = GroupJoinAggregateDetectionVisitor.Visit(_groupJoinClauses, whereClause.Predicate);
3130
AddResults(results);
3231
}
33-
3432
public override void VisitSelectClause(SelectClause selectClause, QueryModel queryModel)
3533
{
3634
var results = GroupJoinAggregateDetectionVisitor.Visit(_groupJoinClauses, selectClause.Selector);
@@ -43,7 +41,6 @@ public override void VisitOrdering(Ordering ordering, QueryModel queryModel, Ord
4341
AddResults(results);
4442
}
4543

46-
4744
private void AddResults(IsAggregatingResults results)
4845
{
4946
_nonAggregatingExpressions.AddRange(results.NonAggregatingExpressions);

0 commit comments

Comments
 (0)