Minor modification to how certain Connection & Command classes

are instantiated.  More code moved to DriverBase.

Added Oracle DataProvider to project.  Thanks to feilng for the contribution.


SVN: trunk@523

Author: Mike Doerfler

src/NHibernate/Driver/ByteFXDataDriver.cs

@@ -33,14 +33,14 @@ public ByteFXDataDriver()
 			commandType = System.Type.GetType("ByteFX.Data.MySqlClient.MySqlCommand, ByteFX.Data");
 		}
 
-		public override IDbConnection CreateConnection()
+		public override System.Type CommandType
 		{
-			return (IDbConnection) Activator.CreateInstance(connectionType);
+			get	{ return commandType; }
 		}
 
-		public override IDbCommand CreateCommand() 
+		public override System.Type ConnectionType
 		{
-			return (IDbCommand) Activator.CreateInstance(commandType);
+			get	{ return connectionType; }
 		}
 
 		public override bool UseNamedPrefixInSql 

src/NHibernate/Driver/DriverBase.cs

@@ -16,9 +16,18 @@ public DriverBase()
 
 		#region IDriver Members
 
-		public abstract IDbConnection CreateConnection();
+		public abstract System.Type CommandType {get; }
+		public abstract System.Type ConnectionType {get; }
 
-		public abstract IDbCommand CreateCommand();
+		public virtual IDbConnection CreateConnection() 
+		{
+			return (IDbConnection) Activator.CreateInstance(ConnectionType);
+		}
+
+		public virtual IDbCommand CreateCommand()
+		{
+			return (IDbCommand) Activator.CreateInstance(CommandType);
+		}
 
 		public abstract bool UseNamedPrefixInSql {get;}
 

src/NHibernate/Driver/FirebirdDriver.cs

@@ -18,14 +18,14 @@ public FirebirdDriver()
 			commandType = System.Type.GetType("FirebirdSql.Data.Firebird.FbCommand, FirebirdSql.Data.Firebird");
 		}
 
-		public override IDbConnection CreateConnection()
+		public override System.Type CommandType
 		{
-			return (IDbConnection) Activator.CreateInstance(connectionType);
+			get	{ return commandType; }
 		}
 
-		public override IDbCommand CreateCommand() 
+		public override System.Type ConnectionType
 		{
-			return (IDbCommand) Activator.CreateInstance(commandType);
+			get	{ return connectionType; }
 		}
 
 		public override bool UseNamedPrefixInSql 

src/NHibernate/Driver/IDriver.cs

@@ -36,6 +36,16 @@ namespace NHibernate.Driver
 	public interface IDriver
 	{
 
+		/// <summary>
+		/// The Type used to create an IDbConnection
+		/// </summary>
+		System.Type ConnectionType { get; }
+
+		/// <summary>
+		/// The Type used to create an IDbCommand
+		/// </summary>
+		System.Type CommandType { get; }
+
 		/// <summary>
 		/// Creates an uninitialized IDbConnection object for the specific Driver
 		/// </summary>

src/NHibernate/Driver/OdbcDriver.cs

@@ -15,6 +15,16 @@ public OdbcDriver()
 		{
 		}
 
+		public override System.Type CommandType
+		{
+			get	{ return typeof(System.Data.Odbc.OdbcCommand); }
+		}
+
+		public override System.Type ConnectionType
+		{
+			get	{ return typeof(System.Data.Odbc.OdbcConnection); }
+		}
+
 		public override IDbConnection CreateConnection()
 		{
 			return new System.Data.Odbc.OdbcConnection();

src/NHibernate/Driver/OleDbDriver.cs

@@ -15,6 +15,16 @@ public OleDbDriver()
 		{
 		}
 
+		public override System.Type CommandType
+		{
+			get	{ return typeof(System.Data.OleDb.OleDbCommand); }
+		}
+
+		public override System.Type ConnectionType
+		{
+			get	{ return typeof(System.Data.OleDb.OleDbConnection); }
+		}
+
 		public override IDbConnection CreateConnection()
 		{
 			return new System.Data.OleDb.OleDbConnection();

src/NHibernate/Driver/OracleClientDriver.cs

@@ -0,0 +1,48 @@
+using System;
+using System.Data;
+using System.Reflection;
+
+namespace NHibernate.Driver
+{
+	/// <summary>
+	/// A NHibernate Driver for using the Oracle DataProvider	
+	/// <see cref="System.Data.OracleClient.OracleConnection"/>.
+	/// </summary>
+	public class OracleClientDriver: DriverBase
+	{
+		private System.Type connectionType;
+		private System.Type commandType;
+
+		public OracleClientDriver()
+		{
+			connectionType = System.Type.GetType("System.Data.OracleClient.OracleConnection, System.Data.OracleClient, version=1.0.5000.0, Culture=neutral, PublicKeyToken=b77a5c561934e089");
+			commandType = System.Type.GetType("System.Data.OracleClient.OracleCommand, System.Data.OracleClient, version=1.0.5000.0, Culture=neutral, PublicKeyToken=b77a5c561934e089");
+		}
+
+		public override System.Type CommandType
+		{
+			get	{ return commandType; }
+		}
+
+		public override System.Type ConnectionType
+		{
+			get	{ return connectionType; }
+		}
+
+		public override bool UseNamedPrefixInSql 
+		{
+			get {return true;}
+		}
+
+		public override bool UseNamedPrefixInParameter 
+		{
+			get {return true;}
+		}
+
+		public override string NamedPrefix 	
+		{
+			get {return ":";}
+		}
+	}
+}
+

src/NHibernate/Driver/SqlClientDriver.cs

@@ -12,6 +12,16 @@ public SqlClientDriver()
 		{
 		}
 
+		public override System.Type CommandType
+		{
+			get	{ return typeof(System.Data.SqlClient.SqlCommand); }
+		}
+
+		public override System.Type ConnectionType
+		{
+			get	{ return typeof(System.Data.SqlClient.SqlConnection); }
+		}
+
 		public override IDbConnection CreateConnection()
 		{
 			return new System.Data.SqlClient.SqlConnection();