GH2201: Change order of deletes in EntityWithMutableCollection tests to avoid the StaleObjectStateException due Parties being loaded and deleted with the Contract in the One-to-Many case.

Author: David Ellingsworth

src/NHibernate.Test/Async/Immutable/EntityWithMutableCollection/AbstractEntityWithOneToManyTest.cs

@@ -1235,6 +1235,8 @@ public virtual async Task OneToManyCollectionOptimisticLockingWithUpdateAsync()
 			s = OpenSession();
 			t = s.BeginTransaction();
 			c = await (s.CreateCriteria<Contract>().UniqueResultAsync<Contract>());
+			await (s.DeleteAsync(c));
+
 			// If the entity uses a join mapping, DML queries require temp tables.
 			if (Dialect.SupportsTemporaryTables)
 				await (s.CreateQuery("delete from Party").ExecuteUpdateAsync());
@@ -1252,7 +1254,6 @@ public virtual async Task OneToManyCollectionOptimisticLockingWithUpdateAsync()
 				await (s.DeleteAsync(newParty));
 			}
 
-			await (s.DeleteAsync(c));
 			Assert.That(await (s.CreateCriteria<Contract>().SetProjection(Projections.RowCountInt64()).UniqueResultAsync<long>()), Is.EqualTo(0L));
 			Assert.That(await (s.CreateCriteria<Party>().SetProjection(Projections.RowCountInt64()).UniqueResultAsync<long>()), Is.EqualTo(0L));
 			await (t.CommitAsync());

src/NHibernate.Test/Immutable/EntityWithMutableCollection/AbstractEntityWithOneToManyTest.cs

@@ -1224,6 +1224,8 @@ public virtual void OneToManyCollectionOptimisticLockingWithUpdate()
 			s = OpenSession();
 			t = s.BeginTransaction();
 			c = s.CreateCriteria<Contract>().UniqueResult<Contract>();
+			s.Delete(c);
+
 			// If the entity uses a join mapping, DML queries require temp tables.
 			if (Dialect.SupportsTemporaryTables)
 				s.CreateQuery("delete from Party").ExecuteUpdate();
@@ -1241,7 +1243,6 @@ public virtual void OneToManyCollectionOptimisticLockingWithUpdate()
 				s.Delete(newParty);
 			}
 
-			s.Delete(c);
 			Assert.That(s.CreateCriteria<Contract>().SetProjection(Projections.RowCountInt64()).UniqueResult<long>(), Is.EqualTo(0L));
 			Assert.That(s.CreateCriteria<Party>().SetProjection(Projections.RowCountInt64()).UniqueResult<long>(), Is.EqualTo(0L));
 			t.Commit();