Skip to content

Commit bc4ac39

Browse files
committed
Code cleanup
1 parent 0911544 commit bc4ac39

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

src/NHibernate/Linq/Visitors/QueryModelVisitor.cs

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -302,12 +302,6 @@ public override void VisitAdditionalFromClause(AdditionalFromClause fromClause,
302302
{
303303
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(fromClause);
304304

305-
//var joinClause = fromClause as NhJoinClause;
306-
//if (joinClause != null)
307-
//{
308-
// VisitNhJoinClause(querySourceName, joinClause);
309-
//}
310-
//else
311305
if (fromClause.FromExpression is MemberExpression)
312306
{
313307
// It's a join
@@ -329,19 +323,21 @@ public override void VisitAdditionalFromClause(AdditionalFromClause fromClause,
329323
base.VisitAdditionalFromClause(fromClause, queryModel, index);
330324
}
331325

332-
private void VisitNhJoinClause(string querySourceName, NhJoinClause joinClause)
326+
public override void VisitNhJoinClause(NhJoinClause joinClause, QueryModel queryModel, int index)
333327
{
328+
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(joinClause);
329+
334330
var expression = HqlGeneratorExpressionVisitor.Visit(joinClause.FromExpression, VisitorParameters).AsExpression();
335331
var alias = _hqlTree.TreeBuilder.Alias(querySourceName);
336332

337333
HqlTreeNode hqlJoin;
338334
if (joinClause.IsInner)
339335
{
340-
hqlJoin = _hqlTree.TreeBuilder.Join(expression, @alias);
336+
hqlJoin = _hqlTree.TreeBuilder.Join(expression, alias);
341337
}
342338
else
343339
{
344-
hqlJoin = _hqlTree.TreeBuilder.LeftJoin(expression, @alias);
340+
hqlJoin = _hqlTree.TreeBuilder.LeftJoin(expression, alias);
345341
}
346342

347343
foreach (var withClause in joinClause.Restrictions)
@@ -449,12 +445,5 @@ public override void VisitNhWithClause(NhWithClause withClause, QueryModel query
449445
var expression = HqlGeneratorExpressionVisitor.Visit(withClause.Predicate, VisitorParameters).ToBooleanExpression();
450446
_hqlTree.AddWhereClause(expression);
451447
}
452-
453-
public override void VisitNhJoinClause(NhJoinClause joinClause, QueryModel queryModel, int index)
454-
{
455-
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(joinClause);
456-
457-
VisitNhJoinClause(querySourceName, joinClause);
458-
}
459448
}
460449
}

0 commit comments

Comments
 (0)