Old methods restored and marked as obsolete

Author: lnu

src/NHibernate.Test/DialectTest/MsSql2005DialectFixture.cs

@@ -199,7 +199,7 @@ public void GetIfExistsDropConstraintTest_without_schema()
 			string expected = "if exists (select 1 from sys.objects" +
 							  " where object_id = OBJECT_ID(N'[Bar]')" +
 							  " AND parent_object_id = OBJECT_ID('Foo'))";
-			string ifExistsDropConstraint = dialect.GetIfExistsDropConstraint(foo, "Bar", null);
+			string ifExistsDropConstraint = dialect.GetIfExistsDropConstraint(foo, "Bar");
 			System.Console.WriteLine(ifExistsDropConstraint);
 			Assert.AreEqual(expected, ifExistsDropConstraint);
 		}
@@ -213,14 +213,41 @@ public void GetIfExistsDropConstraintTest_For_Schema_other_than_dbo()
 			string expected = "if exists (select 1 from sys.objects" +
 							  " where object_id = OBJECT_ID(N'Other.[Bar]')" +
 							  " AND parent_object_id = OBJECT_ID('Other.Foo'))";
+			string ifExistsDropConstraint = dialect.GetIfExistsDropConstraint(foo, "Bar");
+			System.Console.WriteLine(ifExistsDropConstraint);
+			Assert.AreEqual(expected, ifExistsDropConstraint);
+		}
+
+
+		[Test]
+		public void GetIfExistsDropConstraintTest_without_schema_with_schemName_overload()
+		{
+			MsSql2005Dialect dialect = new MsSql2005Dialect();
+			Table foo = new Table("Foo");
+			string expected = "if exists (select 1 from sys.objects" +
+							  " where object_id = OBJECT_ID(N'[Bar]')" +
+							  " AND parent_object_id = OBJECT_ID('Foo'))";
 			string ifExistsDropConstraint = dialect.GetIfExistsDropConstraint(foo, "Bar", null);
 			System.Console.WriteLine(ifExistsDropConstraint);
 			Assert.AreEqual(expected, ifExistsDropConstraint);
 		}
 
+		[Test]
+		public void GetIfExistsDropConstraintTest_For_Schema_other_than_dbo_with_schemName_overload()
+		{
+			MsSql2005Dialect dialect = new MsSql2005Dialect();
+			Table foo = new Table("Foo");
+			foo.Schema = "Other";
+			string expected = "if exists (select 1 from sys.objects" +
+							  " where object_id = OBJECT_ID(N'Other.[Bar]')" +
+							  " AND parent_object_id = OBJECT_ID('Other.Foo'))";
+			string ifExistsDropConstraint = dialect.GetIfExistsDropConstraint(foo, "Bar", null);
+			System.Console.WriteLine(ifExistsDropConstraint);
+			Assert.AreEqual(expected, ifExistsDropConstraint);
+		}
 
 		[Test]
-		public void GetIfExistsDropConstraintTest_For_Schema_other_than_dbo_AndInGlobalConfiguration()
+		public void GetIfExistsDropConstraintTest_For_Schema_other_than_dbo_AndInGlobalConfiguration_with_schemName_overload()
 		{
 			MsSql2005Dialect dialect = new MsSql2005Dialect();
 			Table foo = new Table("Foo");

src/NHibernate/Dialect/Dialect.cs

@@ -711,11 +711,63 @@ public virtual string GetDropForeignKeyConstraintString(string constraintName)
 			return " drop constraint " + constraintName;
 		}
 
+
+		/// <summary>
+		/// The syntax that is used to check if a constraint does not exists before creating it
+		/// </summary>
+		/// <param name="table">The table.</param>
+		/// <param name="name">The name.</param>
+		/// <returns></returns>
+		[Obsolete("Can cause issues when a custom schema is defined(https://nhibernate.jira.com/browse/NH-1285). The new overload with the defaultSchema parameter should be used instead")]
+		public virtual string GetIfNotExistsCreateConstraint(Table table, string name)
+		{
+			return "";
+		}
+
+		/// <summary>
+		/// The syntax that is used to close the if for a constraint exists check, used
+		/// for dialects that requires begin/end for ifs
+		/// </summary>
+		/// <param name="table">The table.</param>
+		/// <param name="name">The name.</param>
+		/// <returns></returns>
+		[Obsolete("Can cause issues when a custom schema is defined(https://nhibernate.jira.com/browse/NH-1285). The new overload with the defaultSchema parameter should be used instead")]
+		public virtual string GetIfNotExistsCreateConstraintEnd(Table table, string name)
+		{
+			return "";
+		}
+
+		/// <summary>
+		/// The syntax that is used to check if a constraint exists before dropping it
+		/// </summary>
+		/// <param name="table">The table.</param>
+		/// <param name="name">The name.</param>
+		/// <returns></returns>
+		[Obsolete("Can cause issues when a custom schema is defined(https://nhibernate.jira.com/browse/NH-1285). The new overload with the defaultSchema parameter should be used instead")]
+		public virtual string GetIfExistsDropConstraint(Table table, string name)
+		{
+			return "";
+		}
+
+		/// <summary>
+		/// The syntax that is used to close the if for a constraint exists check, used
+		/// for dialects that requires begin/end for ifs
+		/// </summary>
+		/// <param name="table">The table.</param>
+		/// <param name="name">The name.</param>
+		/// <returns></returns>
+		[Obsolete("Can cause issues when a custom schema is defined(https://nhibernate.jira.com/browse/NH-1285). The new overload with the defaultSchema parameter should be used instead")]
+		public virtual string GetIfExistsDropConstraintEnd(Table table, string name)
+		{
+			return "";
+		}
+
 		/// <summary>
 		/// The syntax that is used to check if a constraint does not exists before creating it
 		/// </summary>
 		/// <param name="table">The table.</param>
 		/// <param name="name">The name.</param>
+		/// <param name="defaultSchema">The defaultSchema.</param>
 		/// <returns></returns>
 		public virtual string GetIfNotExistsCreateConstraint(Table table, string name, string defaultSchema)
 		{
@@ -728,6 +780,7 @@ public virtual string GetIfNotExistsCreateConstraint(Table table, string name, s
 		/// </summary>
 		/// <param name="table">The table.</param>
 		/// <param name="name">The name.</param>
+		/// <param name="defaultSchema">The defaultSchema.</param>
 		/// <returns></returns>
 		public virtual string GetIfNotExistsCreateConstraintEnd(Table table, string name, string defaultSchema)
 		{
@@ -739,6 +792,7 @@ public virtual string GetIfNotExistsCreateConstraintEnd(Table table, string name
 		/// </summary>
 		/// <param name="table">The table.</param>
 		/// <param name="name">The name.</param>
+		/// <param name="defaultSchema">The defaultSchema.</param>
 		/// <returns></returns>
 		public virtual string GetIfExistsDropConstraint(Table table, string name, string defaultSchema)
 		{
@@ -751,6 +805,7 @@ public virtual string GetIfExistsDropConstraint(Table table, string name, string
 		/// </summary>
 		/// <param name="table">The table.</param>
 		/// <param name="name">The name.</param>
+		/// <param name="defaultSchema">The defaultSchema.</param>
 		/// <returns></returns>
 		public virtual string GetIfExistsDropConstraintEnd(Table table, string name, string defaultSchema)
 		{