Skip to content

Commit aacfa53

Browse files
RogerKratzfredericDelaporte
authored andcommitted
Make sure dbcommand is disposed
1 parent c058080 commit aacfa53

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

src/NHibernate/AdoNet/GenericBatchingBatcher.cs

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
using System;
2-
using System.Collections.Generic;
1+
using System.Collections.Generic;
32
using System.Data;
43
using System.Data.Common;
54
using System.Text;
@@ -215,23 +214,24 @@ public int ExecuteNonQuery()
215214
return 0;
216215
}
217216

218-
var batcherCommand = _batcher.Driver.GenerateCommand(
217+
using (var batcherCommand = _batcher.Driver.GenerateCommand(
219218
_commandType,
220219
_sql.ToSqlString(),
221-
_sqlTypes.ToArray()
222-
);
223-
for (var i = 0; i < _parameters.Count; i++)
220+
_sqlTypes.ToArray()))
224221
{
225-
var parameter = _parameters[i];
226-
var cmdParam = batcherCommand.Parameters[i];
227-
cmdParam.Value = parameter.Value;
228-
cmdParam.Direction = parameter.Direction;
229-
cmdParam.Precision = parameter.Precision;
230-
cmdParam.Scale = parameter.Scale;
231-
cmdParam.Size = parameter.Size;
222+
for (var i = 0; i < _parameters.Count; i++)
223+
{
224+
var parameter = _parameters[i];
225+
var cmdParam = batcherCommand.Parameters[i];
226+
cmdParam.Value = parameter.Value;
227+
cmdParam.Direction = parameter.Direction;
228+
cmdParam.Precision = parameter.Precision;
229+
cmdParam.Scale = parameter.Scale;
230+
cmdParam.Size = parameter.Size;
231+
}
232+
_batcher.Prepare(batcherCommand);
233+
return batcherCommand.ExecuteNonQuery();
232234
}
233-
_batcher.Prepare(batcherCommand);
234-
return batcherCommand.ExecuteNonQuery();
235235
}
236236

237237
public void Clear()

0 commit comments

Comments
 (0)