Mark proxy assembly with IgnoresAccessChecksToAttribute to allow implementing non public interfaces

Author: hazzik

src/NHibernate/Proxy/FieldInterceptorProxyBuilder.cs

@@ -65,7 +65,16 @@ public static TypeInfo CreateProxyType(System.Type baseType)
 					nameof(baseType));
 			}
 
+#if NETFX || NETCOREAPP2_0
+			var assemblyNamesToIgnoreAccessCheck =
+				interfaces.Where(i => !i.IsVisible)
+				          .Select(i => i.Assembly.GetName().Name)
+				          .Distinct();
+			foreach (var a in assemblyNamesToIgnoreAccessCheck)
+				ProxyBuilderHelper.GenerateInstanceOfIgnoresAccessChecksToAttribute(assemblyBuilder, a);
+#else
 			interfaces.RemoveWhere(i => !i.IsVisible);
+#endif
 
 			var typeBuilder = moduleBuilder.DefineType(typeName, typeAttributes, parentType, interfaces.ToArray());
 

src/NHibernate/Proxy/NHibernateProxyBuilder.cs

@@ -27,6 +27,7 @@ internal class NHibernateProxyBuilder
 		private readonly IAbstractComponentType _componentIdType;
 		private readonly bool _overridesEquals;
 
+
 		public NHibernateProxyBuilder(MethodInfo getIdentifierMethod, MethodInfo setIdentifierMethod, IAbstractComponentType componentIdType, bool overridesEquals)
 		{
 			_getIdentifierMethod = getIdentifierMethod;
@@ -75,8 +76,17 @@ public TypeInfo CreateProxyType(System.Type baseType, IReadOnlyCollection<System
 				interfaces.Add(baseType);
 			}
 
+#if NETFX || NETCOREAPP2_0
+			var assemblyNamesToIgnoreAccessCheck =
+				interfaces.Where(i => !i.IsVisible)
+				          .Select(i => i.Assembly.GetName().Name)
+				          .Distinct();
+			foreach (var a in assemblyNamesToIgnoreAccessCheck)
+				ProxyBuilderHelper.GenerateInstanceOfIgnoresAccessChecksToAttribute(assemblyBuilder, a);
+#else
 			interfaces.RemoveWhere(i => !i.IsVisible);
-
+#endif
+			
 			var typeBuilder = moduleBuilder.DefineType(typeName, typeAttributes, parentType, interfaces.ToArray());
 
 			var lazyInitializerField = typeBuilder.DefineField("__lazyInitializer", LazyInitializerType, FieldAttributes.Private);

src/NHibernate/Proxy/ProxyBuilderHelper.cs

@@ -11,6 +11,7 @@
 using System.Linq;
 using System.Reflection;
 using System.Reflection.Emit;
+using System.Runtime.CompilerServices;
 using System.Runtime.Serialization;
 using System.Security;
 using NHibernate.Util;
@@ -21,6 +22,7 @@ internal static class ProxyBuilderHelper
 	{
 		private static readonly ConstructorInfo ObjectConstructor = typeof(object).GetConstructor(System.Type.EmptyTypes);
 		private static readonly ConstructorInfo SecurityCriticalAttributeConstructor = typeof(SecurityCriticalAttribute).GetConstructor(System.Type.EmptyTypes);
+		private static readonly ConstructorInfo IgnoresAccessChecksToAttributeConstructor = typeof(IgnoresAccessChecksToAttribute).GetConstructor(new[] {typeof(string)});
 
 		internal static readonly MethodInfo SerializableGetObjectDataMethod = typeof(ISerializable).GetMethod(nameof(ISerializable.GetObjectData));
 		internal static readonly MethodInfo SerializationInfoSetTypeMethod = ReflectHelper.GetMethod<SerializationInfo>(si => si.SetType(null));
@@ -174,6 +176,18 @@ internal static MethodBuilder GenerateMethodSignature(string name, MethodInfo me
 			return methodBuilder;
 		}
 
+		internal static void GenerateInstanceOfIgnoresAccessChecksToAttribute(
+			AssemblyBuilder assemblyBuilder,
+			string assemblyName)
+		{
+			// [assembly: System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute(assemblyName)]
+			var customAttributeBuilder = new CustomAttributeBuilder(
+				IgnoresAccessChecksToAttributeConstructor,
+				new object[] {assemblyName});
+
+			assemblyBuilder.SetCustomAttribute(customAttributeBuilder);
+		}
+
 		private static System.Type ResolveTypeConstraint(MethodInfo method, System.Type typeConstraint)
 		{
 			if (typeConstraint != null && typeConstraint.IsGenericType)

src/NHibernate/Util/IgnoresAccessChecksToAttribute.cs

@@ -0,0 +1,14 @@
+// ReSharper disable once CheckNamespace
+namespace System.Runtime.CompilerServices
+{
+	[AttributeUsage(AttributeTargets.Assembly, AllowMultiple = true)]
+	public class IgnoresAccessChecksToAttribute : Attribute
+	{
+		public string AssemblyName { get; }
+
+		public IgnoresAccessChecksToAttribute(string assemblyName)
+		{
+			AssemblyName = assemblyName;
+		}
+	}
+}