Skip to content

Commit 9df2fc4

Browse files
committed
Code cleanup
1 parent 66e6db7 commit 9df2fc4

File tree

1 file changed

+5
-16
lines changed

1 file changed

+5
-16
lines changed

src/NHibernate/Linq/Visitors/QueryModelVisitor.cs

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -164,12 +164,6 @@ public override void VisitAdditionalFromClause(AdditionalFromClause fromClause,
164164
{
165165
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(fromClause);
166166

167-
//var joinClause = fromClause as NhJoinClause;
168-
//if (joinClause != null)
169-
//{
170-
// VisitNhJoinClause(querySourceName, joinClause);
171-
//}
172-
//else
173167
if (fromClause.FromExpression is MemberExpression)
174168
{
175169
// It's a join
@@ -191,19 +185,21 @@ public override void VisitAdditionalFromClause(AdditionalFromClause fromClause,
191185
base.VisitAdditionalFromClause(fromClause, queryModel, index);
192186
}
193187

194-
private void VisitNhJoinClause(string querySourceName, NhJoinClause joinClause)
188+
public override void VisitNhJoinClause(NhJoinClause joinClause, QueryModel queryModel, int index)
195189
{
190+
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(joinClause);
191+
196192
var expression = HqlGeneratorExpressionVisitor.Visit(joinClause.FromExpression, VisitorParameters).AsExpression();
197193
var alias = _hqlTree.TreeBuilder.Alias(querySourceName);
198194

199195
HqlTreeNode hqlJoin;
200196
if (joinClause.IsInner)
201197
{
202-
hqlJoin = _hqlTree.TreeBuilder.Join(expression, @alias);
198+
hqlJoin = _hqlTree.TreeBuilder.Join(expression, alias);
203199
}
204200
else
205201
{
206-
hqlJoin = _hqlTree.TreeBuilder.LeftJoin(expression, @alias);
202+
hqlJoin = _hqlTree.TreeBuilder.LeftJoin(expression, alias);
207203
}
208204

209205
foreach (var withClause in joinClause.Restrictions)
@@ -311,12 +307,5 @@ public override void VisitNhWithClause(NhWithClause withClause, QueryModel query
311307
var expression = HqlGeneratorExpressionVisitor.Visit(withClause.Predicate, VisitorParameters).ToBooleanExpression();
312308
_hqlTree.AddWhereClause(expression);
313309
}
314-
315-
public override void VisitNhJoinClause(NhJoinClause joinClause, QueryModel queryModel, int index)
316-
{
317-
var querySourceName = VisitorParameters.QuerySourceNamer.GetName(joinClause);
318-
319-
VisitNhJoinClause(querySourceName, joinClause);
320-
}
321310
}
322311
}

0 commit comments

Comments
 (0)