NH-4034 - better naming for dependent session to handle from transaction commit.

Author: fredericDelaporte

src/NHibernate.Test/DebugSessionFactory.cs

@@ -2,6 +2,7 @@
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Data.Common;
+using System.Linq;
 using System.Threading;
 using log4net;
 using NHibernate.Cache;
@@ -57,9 +58,9 @@ public bool CheckSessionsWereClosed()
 				allClosed = CheckSessionWasClosed(session) && allClosed;
 				// Catches only session opened from another one while sharing the connection. Those
 				// opened without sharing the connection stay un-monitored.
-				foreach (var sharingSession in session.ConnectionManager.SessionsSharingManager)
+				foreach (var dependentSession in session.ConnectionManager.DependentSessions.ToList())
 				{
-					allClosed = CheckSessionWasClosed(sharingSession) && allClosed;
+					allClosed = CheckSessionWasClosed(dependentSession) && allClosed;
 				}
 			}
 

src/NHibernate/AdoNet/ConnectionManager.cs

@@ -42,10 +42,17 @@ public interface Callback
 		private readonly ISessionImplementor session;
 		private readonly ConnectionReleaseMode connectionReleaseMode;
 		private readonly IInterceptor interceptor;
-		private readonly List<ISessionImplementor> _sessionsSharingManager = new List<ISessionImplementor>();
+		private readonly List<ISessionImplementor> _dependentSessions = new List<ISessionImplementor>();
 
+		/// <summary>
+		/// The session responsible for the lifecycle of the connection manager.
+		/// </summary>
 		public ISessionImplementor Session => session;
-		public IReadOnlyCollection<ISessionImplementor> SessionsSharingManager => _sessionsSharingManager;
+
+		/// <summary>
+		/// The sessions using the connection manager of the session responsible for it.
+		/// </summary>
+		public IReadOnlyCollection<ISessionImplementor> DependentSessions => _dependentSessions;
 
 		[NonSerialized]
 		private bool _releasesEnabled = true;
@@ -70,12 +77,12 @@ public ConnectionManager(
 
 		public void AddSessionSharingManager(ISessionImplementor session)
 		{
-			_sessionsSharingManager.Add(session);
+			_dependentSessions.Add(session);
 		}
 
 		public void RemoveSessionSharingManager(ISessionImplementor session)
 		{
-			_sessionsSharingManager.Remove(session);
+			_dependentSessions.Remove(session);
 		}
 
 		public bool IsInActiveTransaction

src/NHibernate/Impl/SessionImpl.cs

@@ -318,9 +318,9 @@ public DbConnection Close()
 		public override void AfterTransactionCompletion(bool success, ITransaction tx)
 		{
 			if (!_transactionCoordinatorShared)
-				foreach (var sharingSession in ConnectionManager.SessionsSharingManager)
+				foreach (var dependentSession in ConnectionManager.DependentSessions)
 				{
-					sharingSession.AfterTransactionCompletion(success, tx);
+					dependentSession.AfterTransactionCompletion(success, tx);
 				}
 
 			using (new SessionIdLoggingContext(SessionId))
@@ -2112,18 +2112,18 @@ public override void AfterTransactionBegin(ITransaction tx)
 			}
 
 			if (!_transactionCoordinatorShared)
-				foreach (var sharingSession in ConnectionManager.SessionsSharingManager)
+				foreach (var dependentSession in ConnectionManager.DependentSessions)
 				{
-					sharingSession.AfterTransactionBegin(tx);
+					dependentSession.AfterTransactionBegin(tx);
 				}
 		}
 
 		public override void BeforeTransactionCompletion(ITransaction tx)
 		{
 			if (!_transactionCoordinatorShared)
-				foreach (var sharingSession in ConnectionManager.SessionsSharingManager)
+				foreach (var dependentSession in ConnectionManager.DependentSessions)
 				{
-					sharingSession.BeforeTransactionCompletion(tx);
+					dependentSession.BeforeTransactionCompletion(tx);
 				}
 
 			using (new SessionIdLoggingContext(SessionId))

src/NHibernate/Transaction/AdoNetWithDistributedTransactionFactory.cs

@@ -82,13 +82,13 @@ public void EnlistInDistributedTransactionIfNeeded(ISessionImplementor session)
 
 		private static void Cleanup(ISessionImplementor session)
 		{
-			foreach (var sharingSession in session.ConnectionManager.SessionsSharingManager.ToList())
+			foreach (var dependentSession in session.ConnectionManager.DependentSessions.ToList())
 			{
-				if (sharingSession.TransactionContext?.ShouldCloseSessionOnDistributedTransactionCompleted ?? false)
+				if (dependentSession.TransactionContext?.ShouldCloseSessionOnDistributedTransactionCompleted ?? false)
 					// This change the enumerated collection.
-					sharingSession.CloseSessionFromDistributedTransaction();
-				sharingSession.TransactionContext?.Dispose();
-				sharingSession.TransactionContext = null;
+					dependentSession.CloseSessionFromDistributedTransaction();
+				dependentSession.TransactionContext?.Dispose();
+				dependentSession.TransactionContext = null;
 			}
 			if (session.TransactionContext.ShouldCloseSessionOnDistributedTransactionCompleted)
 			{
@@ -145,12 +145,12 @@ void IEnlistmentNotification.Prepare(PreparingEnlistment preparingEnlistment)
 							{
 								using (sessionImplementor.ConnectionManager.FlushingFromDtcTransaction)
 								{
-									foreach (var sharingSession in sessionImplementor.ConnectionManager.SessionsSharingManager)
+									foreach (var dependentSession in sessionImplementor.ConnectionManager.DependentSessions)
 									{
-										if (sharingSession.FlushMode != FlushMode.Manual)
+										if (dependentSession.FlushMode != FlushMode.Manual)
 										{
-											logger.DebugFormat("[session-id={0}] Flushing from Dtc Transaction", sharingSession.SessionId);
-											sharingSession.Flush();
+											logger.DebugFormat("[session-id={0}] Flushing from Dtc Transaction", dependentSession.SessionId);
+											dependentSession.Flush();
 										}
 									}
 									if (sessionImplementor.FlushMode != FlushMode.Manual)

src/NHibernate/Transaction/AdoTransaction.cs

@@ -186,11 +186,11 @@ public void Commit()
 
 				log.Debug("Start Commit");
 
-				foreach (var sharingSession in session.ConnectionManager.SessionsSharingManager)
+				foreach (var dependentSession in session.ConnectionManager.DependentSessions)
 				{
-					if (sharingSession.FlushMode != FlushMode.Manual)
+					if (dependentSession.FlushMode != FlushMode.Manual)
 					{
-						sharingSession.Flush();
+						dependentSession.Flush();
 					}
 				}
 				if (session.FlushMode != FlushMode.Manual)