Document breaking change for NH-3119 and also fix PocoEntityTuplizer deserialization.

Author: cremor

releasenotes.txt

@@ -4,6 +4,11 @@ Build vNext
 ** Known BREAKING CHANGES from NH4.0.0.Alpha1 to 4.0.0.Alpha1
 
     Fixed mapping by code behaviour when map child subclasses (see NH-3135 and NH-3269)
+    
+    The constructor of AbstractComponentTuplizer now behaves like AbstractEntityTuplizer in the way
+    that it doesn't create the instantiator any more. Custom component tuplizers that derive
+    directly from AbstractComponentTuplizer need to add this line of code in their constructor:
+      instantiator = BuildInstantiator(component);
 
 
 Build 4.0.0.Alpha1

src/NHibernate/Tuple/Entity/PocoEntityTuplizer.cs

@@ -34,6 +34,14 @@ public class PocoEntityTuplizer : AbstractEntityTuplizer
 		internal void OnDeserialized(StreamingContext context)
 		{
 			SetReflectionOptimizer();
+
+			if (optimizer != null)
+			{
+				// Also set the InstantiationOptimizer on the deserialized PocoInstantiator.
+				((PocoInstantiator)Instantiator).SetOptimizer(optimizer.InstantiationOptimizer);
+			}
+
+			ClearOptimizerWhenUsingCustomAccessors();
 		}
 		protected void SetReflectionOptimizer()
 		{
@@ -62,10 +70,7 @@ public PocoEntityTuplizer(EntityMetamodel entityMetamodel, PersistentClass mappe
 
 			Instantiator = BuildInstantiator(mappedEntity);
 
-			if (hasCustomAccessors)
-			{
-				optimizer = null;
-			}
+			ClearOptimizerWhenUsingCustomAccessors();
 
 			proxyValidator = Cfg.Environment.BytecodeProvider.ProxyFactoryFactory.ProxyValidator;
 		}
@@ -316,5 +321,13 @@ public override EntityMode EntityMode
 		{
 			get { return EntityMode.Poco; }
 		}
+
+		protected void ClearOptimizerWhenUsingCustomAccessors()
+		{
+			if (hasCustomAccessors)
+			{
+				optimizer = null;
+			}
+		}
 	}
 }