NH-3720

* Ignore Boolean test for SQLite, Firebird, MySQL, and Oracle
* Ignore DateTime test for Oracle
* Improve DateTime test to suit SQLite

Author: hazzik

src/NHibernate.Test/NHSpecificTest/NH3377/Fixture.cs

@@ -2,6 +2,7 @@
 using NHibernate.Linq;
 using NUnit.Framework;
 using System;
+using NHibernate.Dialect;
 
 namespace NHibernate.Test.NHSpecificTest.NH3377
 {
@@ -10,34 +11,34 @@ public class Fixture : BugTestCase
 	{
 		protected override void OnSetUp()
 		{
-			using (ISession session = OpenSession())
-			using (ITransaction transaction = session.BeginTransaction())
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
 			{
 				var e1 = new Entity
-					         {
-						         Name = "Bob",
-								 Age = "17",
-								 Solde = "5.4"
-					         };
+				{
+					Name = "Bob",
+					Age = "17",
+					Solde = "5.4"
+				};
 				session.Save(e1);
 
 				var e2 = new Entity
-					         {
-						         Name = "Sally", 
-								 Age = "16"
-					         };
+				{
+					Name = "Sally",
+					Age = "16"
+				};
 				session.Save(e2);
 
 				var e3 = new Entity
 				{
-					Name = "True",
+					Name = "true",
 					Age = "10"
 				};
 				session.Save(e3);
 
 				var e4 = new Entity
 				{
-					Name = "20141013",
+					Name = "2014-10-13",
 					Age = "11"
 				};
 				session.Save(e4);
@@ -49,8 +50,8 @@ protected override void OnSetUp()
 
 		protected override void OnTearDown()
 		{
-			using (ISession session = OpenSession())
-			using (ITransaction transaction = session.BeginTransaction())
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
 			{
 				session.Delete("from System.Object");
 
@@ -62,53 +63,59 @@ protected override void OnTearDown()
 		[Test]
 		public void ShouldBeAbleToCallConvertToInt32FromStringParameter()
 		{
-			using (ISession session = OpenSession())
+			using (var session = OpenSession())
 			using (session.BeginTransaction())
 			{
-				var result = from e in session.Query<Entity>()
-							 where e.Name == "Bob"
-							 select Convert.ToInt32(e.Age);
+				var result = (from e in session.Query<Entity>()
+							  where e.Name == "Bob"
+							  select Convert.ToInt32(e.Age)).ToList();
 
-				Assert.AreEqual(1, result.Count());
-				Assert.AreEqual(17, result.First());
+				Assert.That(result, Has.Count.EqualTo(1));
+				Assert.That(result[0], Is.EqualTo(17));
 			}
 		}
 
 		[Test]
 		public void ShouldBeAbleToCallConvertToInt32FromStringParameterInMax()
 		{
-			using (ISession session = OpenSession())
+			using (var session = OpenSession())
 			using (session.BeginTransaction())
 			{
 				var result = session.Query<Entity>().Max(e => Convert.ToInt32(e.Age));
 
-				Assert.AreEqual(17, result);
+				Assert.That(result, Is.EqualTo(17));
 			}
 		}
 
 		[Test]
 		public void ShouldBeAbleToCallConvertToBooleanFromStringParameter()
 		{
+			if (Dialect is SQLiteDialect || Dialect is FirebirdDialect || Dialect is MySQLDialect || Dialect is Oracle8iDialect)
+				Assert.Ignore(Dialect.GetType() + " is not supported");
+
 			//NH-3720
-			using (ISession session = OpenSession())
+			using (var session = OpenSession())
 			using (session.BeginTransaction())
 			{
-				var result = session.Query<Entity>().Where(x => x.Name == Boolean.TrueString).Select(x => Convert.ToBoolean(x.Name)).Single();
+				var result = session.Query<Entity>().Where(x => x.Name == "true").Select(x => Convert.ToBoolean(x.Name)).Single();
 
-				Assert.AreEqual(true, result);
+				Assert.That(result, Is.True);
 			}
 		}
 
 		[Test]
 		public void ShouldBeAbleToCallConvertToDateTimeFromStringParameter()
 		{
+			if (Dialect is Oracle8iDialect)
+				Assert.Ignore(Dialect.GetType() + " is not supported");
+
 			//NH-3720
-			using (ISession session = OpenSession())
+			using (var session = OpenSession())
 			using (session.BeginTransaction())
 			{
-				var result = session.Query<Entity>().Where(x => x.Name == "20141013").Select(x => Convert.ToDateTime(x.Name)).Single();
+				var result = session.Query<Entity>().Where(x => x.Name == "2014-10-13").Select(x => Convert.ToDateTime(x.Name)).Single();
 
-				Assert.AreEqual(new DateTime(2014, 10, 13), result);
+				Assert.That(result, Is.EqualTo(new DateTime(2014, 10, 13)));
 			}
 		}
 	}