fix NH-1904

SVN: trunk@4682

Author: Davy Brion

src/NHibernate.Test/NHSpecificTest/NH1904/Fixture.cs

@@ -0,0 +1,40 @@
+using System;
+using System.Collections.Generic;
+
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.NH1904
+{
+	[TestFixture]
+	public class Fixture : BugTestCase
+	{
+		[Test]
+		public void ExecuteQuery()
+		{
+			using (ISession session = OpenSession())
+			using (ITransaction transaction = session.BeginTransaction())
+			{
+				Invoice invoice = new Invoice();
+				invoice.Issued = DateTime.Now;
+
+				session.Save(invoice);
+				transaction.Commit();
+			}
+
+			using (ISession session = OpenSession())
+			{
+				IList<Invoice> invoices = session.CreateCriteria<Invoice>().List<Invoice>();
+			}
+		}
+
+		protected override void OnTearDown()
+		{
+			base.OnTearDown();
+			using (ISession session = OpenSession())
+			{
+				session.CreateQuery("delete from Invoice").ExecuteUpdate();
+				session.Flush();
+			}
+		}
+	}
+}

src/NHibernate.Test/NHSpecificTest/NH1904/Mappings.hbm.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2"
+									 assembly="NHibernate.Test"
+									 namespace="NHibernate.Test.NHSpecificTest.NH1904">
+
+	<class name="Invoice">
+		<id name="ID" type="Int32">
+			<generator class="hilo" />
+		</id>
+		
+		<property name="Issued" type="DateTime" />
+	</class>
+
+</hibernate-mapping>

src/NHibernate.Test/NHSpecificTest/NH1904/Model.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace NHibernate.Test.NHSpecificTest.NH1904
+{
+	public class Invoice
+	{
+		public virtual int ID { get; private set; }
+		public virtual DateTime Issued { get; set; }
+
+		protected virtual DateTime issued { get; set; }
+	}
+}

src/NHibernate.Test/NHibernate.Test.csproj

@@ -556,6 +556,8 @@
     <Compile Include="NHSpecificTest\NH1898\SampleTest.cs" />
     <Compile Include="NHSpecificTest\NH1899\DomainClass.cs" />
     <Compile Include="NHSpecificTest\NH1899\SampleTest.cs" />
+    <Compile Include="NHSpecificTest\NH1904\Fixture.cs" />
+    <Compile Include="NHSpecificTest\NH1904\Model.cs" />
     <Compile Include="NHSpecificTest\NH1907\Fixture.cs" />
     <Compile Include="NHSpecificTest\NH1907\MyType.cs" />
     <Compile Include="NHSpecificTest\NH1908\Fixture.cs" />
@@ -1973,6 +1975,7 @@
     <EmbeddedResource Include="Criteria\Lambda\Mappings.hbm.xml" />
     <EmbeddedResource Include="CfgTest\Loquacious\EntityToCache.hbm.xml" />
     <Content Include="DynamicEntity\package.html" />
+    <EmbeddedResource Include="NHSpecificTest\NH1904\Mappings.hbm.xml" />
     <EmbeddedResource Include="FilterTest\SimpleFiltered.hbm.xml" />
     <EmbeddedResource Include="FilterTest\SimpleFilteredFiltersDefsOk.hbm.xml" />
     <EmbeddedResource Include="FilterTest\WrongFilterDefInClass.hbm.xml" />

src/NHibernate/Properties/BasicPropertyAccessor.cs

@@ -130,12 +130,17 @@ internal static BasicSetter GetSetterOrNull(System.Type type, string propertyNam
 				return null;
 			}
 
-			// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
-			// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
-			// stating that casing should be ignored so we get the same behavior for both structs and classes
-			PropertyInfo property =
-				type.GetProperty(propertyName,
-				                 BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly | BindingFlags.IgnoreCase);
+			BindingFlags bindingFlags = BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.DeclaredOnly;
+
+			if (type.IsValueType)
+			{
+				// the BindingFlags.IgnoreCase is important here because if type is a struct, the GetProperty method does
+				// not ignore case by default. If type is a class, it _does_ ignore case... we're better off explicitly
+				// stating that casing should be ignored so we get the same behavior for both structs and classes
+				bindingFlags = bindingFlags | BindingFlags.IgnoreCase;
+			}
+
+			PropertyInfo property = type.GetProperty(propertyName, bindingFlags);
 
 			if (property != null && property.CanWrite)
 			{