Skip to content

Commit 67d2640

Browse files
committed
Code review changes
1 parent 17f63ce commit 67d2640

File tree

4 files changed

+13
-33
lines changed

4 files changed

+13
-33
lines changed

src/NHibernate/Hql/Ast/ANTLR/Tree/BetweenOperatorNode.cs

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -69,21 +69,7 @@ private static void Check(IASTNode check, IASTNode first, IASTNode second)
6969
return;
7070
}
7171

72-
IType expectedType = null;
73-
if (first is SqlNode firstNode)
74-
{
75-
expectedType = firstNode.DataType;
76-
}
77-
78-
if (expectedType == null)
79-
{
80-
if (second is SqlNode secondNode)
81-
{
82-
expectedType = secondNode.DataType;
83-
}
84-
}
85-
86-
expectedTypeAwareNode.ExpectedType = expectedType;
72+
expectedTypeAwareNode.ExpectedType = (first as SqlNode)?.DataType ?? (second as SqlNode)?.DataType;
8773
}
8874
}
8975
}

src/NHibernate/Linq/Visitors/ExpressionParameterVisitor.cs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,10 +186,11 @@ protected override Expression VisitConstant(ConstantExpression expression)
186186

187187
private NamedParameter CreateParameter(ConstantExpression expression, object value, IType type)
188188
{
189-
var parameterName = "p" + (_parameters.Count + 1);
190-
return _collectionParameters.Contains(expression)
191-
? new NamedListParameter(parameterName, value, type)
192-
: new NamedParameter(parameterName, value, type);
189+
return new NamedParameter(
190+
"p" + (_parameters.Count + 1),
191+
value,
192+
type,
193+
_collectionParameters.Contains(expression));
193194
}
194195

195196
private static bool IsNullObject(ConstantExpression expression)

src/NHibernate/Param/NamedListParameter.cs

Lines changed: 0 additions & 13 deletions
This file was deleted.

src/NHibernate/Param/NamedParameter.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,23 @@ namespace NHibernate.Param
55
public class NamedParameter
66
{
77
public NamedParameter(string name, object value, IType type)
8+
: this(name, value, type, false)
9+
{
10+
}
11+
12+
internal NamedParameter(string name, object value, IType type, bool isCollection)
813
{
914
Name = name;
1015
Value = value;
1116
Type = type;
17+
IsCollection = isCollection;
1218
}
1319

1420
public string Name { get; private set; }
1521
public object Value { get; internal set; }
1622
public IType Type { get; internal set; }
1723

18-
public virtual bool IsCollection => false;
24+
public virtual bool IsCollection { get; }
1925

2026
public bool Equals(NamedParameter other)
2127
{

0 commit comments

Comments
 (0)