Provide a correct MaxAliasLength for various dialects

Author: fredericDelaporte

src/NHibernate.sln.DotSettings

@@ -19,6 +19,7 @@
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateConstants/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateInstanceFields/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="_" Suffix="" Style="aaBb" /&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateStaticReadonly/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="AaBb" /&gt;</s:String>
+	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ECSharpAttributeForSingleLineMethodUpgrade/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EAddAccessorOwnerDeclarationBracesMigration/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateBlankLinesAroundFieldToBlankLinesAroundProperty/@EntryIndexedValue">True</s:Boolean>
 	<s:Boolean x:Key="/Default/Environment/SettingsMigration/IsMigratorApplied/=JetBrains_002EReSharper_002EPsi_002ECSharp_002ECodeStyle_002ESettingsUpgrade_002EMigrateThisQualifierSettings/@EntryIndexedValue">True</s:Boolean>

src/NHibernate/Dialect/DB2Dialect.cs

@@ -272,6 +272,10 @@ public override string ForUpdateString
 			get { return " for read only with rs"; }
 		}
 
+		// As of DB2 9.5 documentation, limit is 128 bytes which with Unicode names could mean only 32 characters.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 32;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList => false;

src/NHibernate/Dialect/Dialect.cs

@@ -2282,10 +2282,10 @@ public virtual string LowercaseFunction
 			get { return "lower"; }
 		}
 
-		public virtual int MaxAliasLength
-		{
-			get { return 10; }
-		}
+		/// <summary>
+		/// The maximal length a SQL alias can have.
+		/// </summary>
+		public virtual int MaxAliasLength => 10;
 
 		/// <summary>
 		/// The syntax used to add a column to a table. Note this is deprecated

src/NHibernate/Dialect/FirebirdDialect.cs

@@ -520,6 +520,12 @@ private void RegisterTrigonometricFunctions()
 			RegisterFunction("tanh", new StandardSQLFunction("tanh", NHibernateUtil.Double));
 		}
 
+		// As of Firebird 2.5 documentation, limit is 30/31 (not all source are concordant), with some
+		// cases supporting more but considered as bugs and no more tolerated in v3.
+		// It seems it may be extended to 63 for Firebird v4.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 30;
+
 		#region Informational metadata
 
 		/// <summary>

src/NHibernate/Dialect/InformixDialect.cs

@@ -457,6 +457,10 @@ public override string GetAddForeignKeyConstraintString(string constraintName, s
 
 			return res.ToString();
 		}
+
+		// Informix 7 is said on Internet to be limited to 18. (http://www.justskins.com/forums/length-of-columns-names-143294.html)
+		/// <inheritdoc />
+		public override int MaxAliasLength => 18;
 	}
 
 	public class IfxViolatedConstraintExtracter : TemplatedViolatedConstraintNameExtracter

src/NHibernate/Dialect/InformixDialect0940.cs

@@ -146,5 +146,8 @@ public override bool SupportsLimitOffset
             get { return false; }
         }
 
+        // Informix 9 is said on Internet to be limited to 128. (http://www.justskins.com/forums/length-of-columns-names-143294.html)
+        /// <inheritdoc />
+        public override int MaxAliasLength => 128;
     };
-}
+}

src/NHibernate/Dialect/IngresDialect.cs

@@ -53,6 +53,11 @@ public IngresDialect()
 			DefaultProperties[Environment.ConnectionDriver] = "NHibernate.Driver.IngresDriver";
 		}
 
+		// Ingres 10.2 supports 256 bytes (so worst unicode case would mean 64 characters), but I am unable to find
+		// the limit for older versions, excepted many various sites mention a 32 length limit. Being conservative.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 32;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList => false;

src/NHibernate/Dialect/MsSql2000Dialect.cs

@@ -677,6 +677,10 @@ public override bool SupportsSqlBatches
 			get { return true; }
 		}
 
+		// SQL Server 2005 supports 128, unable to find the information about SQL Server 2000.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 128;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList => false;

src/NHibernate/Dialect/MsSqlCeDialect.cs

@@ -344,6 +344,10 @@ public override long TimestampResolutionInTicks
 			}
 		}
 
+		// SQL Server 3.5 supports 128.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 128;
+
 		#region Informational metadata
 
 		/// <summary>

src/NHibernate/Dialect/MySQLDialect.cs

@@ -514,6 +514,11 @@ public override long TimestampResolutionInTicks
 		/// </remarks>
 		public override bool SupportsConcurrentWritingConnectionsInSameTransaction => false;
 
+		// At least MySQL 5 is said to support 64 characters for columns, but 5.7 supports 256 for aliases.
+		// Unable to find the information about previous version, being conservative.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 64;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList => false;

src/NHibernate/Dialect/Oracle12cDialect.cs

@@ -3,7 +3,7 @@
 namespace NHibernate.Dialect
 {
 	/// <summary> 
-	/// A dialect specifically for use with Oracle 10g.
+	/// A dialect specifically for use with Oracle 12c. Assume 12.2 at least.
 	/// </summary>
 	/// <remarks>
 	/// The main difference between this dialect and <see cref="Oracle12cDialect"/>
@@ -38,5 +38,9 @@ public override SqlString GetLimitString(SqlString querySqlString, SqlString off
 
 			return result.ToSqlString();
 		}
+
+		// 128 since 12.2. https://stackoverflow.com/a/756569/1178314
+		/// <inheritdoc />
+		public override int MaxAliasLength => 128;
 	}
-}
+}

src/NHibernate/Dialect/Oracle8iDialect.cs

@@ -533,6 +533,10 @@ public override long TimestampResolutionInTicks
 			}
 		}
 
+		// 30 before 12.1. https://stackoverflow.com/a/756569/1178314
+		/// <inheritdoc />
+		public override int MaxAliasLength => 30;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList

src/NHibernate/Dialect/PostgreSQLDialect.cs

@@ -291,6 +291,10 @@ public override string CurrentTimestampSelectString
 			get { return "SELECT CURRENT_TIMESTAMP"; }
 		}
 
+		// Said to be 63 bytes at least since v8.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 63;
+
 		#region Overridden informational metadata
 
 		public override bool SupportsEmptyInList => false;

src/NHibernate/Dialect/SQLiteDialect.cs

@@ -395,6 +395,10 @@ public override bool SupportsForeignKeyConstraintInAlterTable
 		/// </remarks>
 		public override bool SupportsConcurrentWritingConnections => false;
 
+		// Said to be unlimited. http://sqlite.1065341.n5.nabble.com/Max-limits-on-the-following-td37859.html
+		/// <inheritdoc />
+		public override int MaxAliasLength => 100;
+
 		[Serializable]
 		protected class SQLiteCastFunction : CastFunction
 		{
@@ -407,4 +411,4 @@ protected override bool CastingIsRequired(string sqlType)
 			}
 		}
 	}
-}
+}

src/NHibernate/Dialect/SybaseASA9Dialect.cs

@@ -185,5 +185,9 @@ private static int GetAfterSelectInsertPoint(SqlString sql)
 			}
 			return 0;
 		}
+
+		// Not found documentation for this version, using the lowest from similar products.
+		/// <inheritdoc />
+		public override int MaxAliasLength => 30;
 	}
 }