Adding parameter type information for SQL log, that allow to detect issues with parameter types and length

SVN: trunk@4914

Author: ayende

src/NHibernate.Test/SqlTest/Identity/MsSQL/MSSQLIdentityInsertWithStoredProcsTest.cs

@@ -14,7 +14,7 @@ protected override bool AppliesTo(Dialect.Dialect dialect)
 
 		protected override string GetExpectedInsertOrgLogStatement(string orgName)
 		{
-			return string.Format("exec nh_organization_native_id_insert @p0;@p0 = '{0}'", orgName);
+			return string.Format("exec nh_organization_native_id_insert @p0;@p0 = '{0}' [Type: String ({1})]", orgName, orgName.Length);
 		}
 
 		protected override IList Mappings

src/NHibernate/AdoNet/Util/SqlStatementLogger.cs

@@ -93,14 +93,23 @@ public string GetCommandLineWithParameters(IDbCommand command)
 					}
 					appendComma = true;
 					p = (IDataParameter)command.Parameters[i];
-					output.Append(string.Format("{0} = {1}", p.ParameterName, GetParameterLogableValue(p)));
+					output.Append(string.Format("{0} = {1} [Type: {2}]", p.ParameterName, GetParameterLogableValue(p), GetParameterLogableType(p)));
 				}
 				outputText = output.ToString();
 			}
 			return outputText;
 		}
 
-		public string GetParameterLogableValue(IDataParameter parameter)
+	    private static string GetParameterLogableType(IDataParameter dataParameter)
+	    {
+            var p = dataParameter as IDbDataParameter;
+            if (p != null)
+                return p.DbType + " (" + p.Size + ")";
+	        return p.DbType.ToString();
+
+	    }
+
+	    public string GetParameterLogableValue(IDataParameter parameter)
 		{
 			if (parameter.Value == null || DBNull.Value.Equals(parameter.Value))
 			{