NH-2176 - added test variants with flushes. Temporarily enabling dtc for all to check if some db better handles dtc when there are explicit flushes.

Author: fredericDelaporte

src/NHibernate.Test/NHSpecificTest/DtcFailures/DtcFailuresFixture.cs

@@ -26,7 +26,7 @@ protected override string MappingsAssembly
 			=> "NHibernate.Test";
 
 		protected override bool AppliesTo(Dialect.Dialect dialect)
-			=> dialect.SupportsDistributedTransactions;
+			=> true || dialect.SupportsDistributedTransactions;
 
 		protected override void CreateSchema()
 		{
@@ -176,6 +176,42 @@ public void CanRollbackTransaction()
 			AssertNoPersons();
 		}
 
+		[Test]
+		public void CanRollbackTransactionWithFlush()
+		{
+			var tx = new TransactionScope();
+			var disposeCalled = false;
+			try
+			{
+				using (var s = sessions.OpenSession())
+				{
+					ForceEscalationToDistributedTx.Escalate(true); //will rollback tx
+					s.Save(new Person { CreatedAt = DateTime.Today });
+					s.Flush();
+					tx.Complete();
+				}
+				disposeCalled = true;
+				Assert.Throws<TransactionAbortedException>(tx.Dispose, "Scope disposal has not rollback and throw.");
+			}
+			finally
+			{
+				if (!disposeCalled)
+				{
+					try
+					{
+						tx.Dispose();
+					}
+					catch
+					{
+						// Ignore, if disposed has not been called, another exception has occurred in the try and
+						// we should avoid overriding it by the disposal failure.
+					}
+				}
+			}
+
+			AssertNoPersons();
+		}
+
 		[Test]
 		[Description("Another action inside the transaction do the rollBack outside nh-session-scope.")]
 		public void RollbackOutsideNh()
@@ -204,6 +240,35 @@ public void RollbackOutsideNh()
 			AssertNoPersons();
 		}
 
+		[Test]
+		[Description("Another action inside the transaction do the rollBack outside nh-session-scope.")]
+		public void RollbackOutsideNhWithFlush()
+		{
+			try
+			{
+				using (var txscope = new TransactionScope())
+				{
+					using (var s = sessions.OpenSession())
+					{
+						var person = new Person { CreatedAt = DateTime.Now };
+						s.Save(person);
+						s.Flush();
+					}
+					ForceEscalationToDistributedTx.Escalate(true); //will rollback tx
+
+					txscope.Complete();
+				}
+
+				Assert.Fail("Scope disposal has not rollback and throw.");
+			}
+			catch (TransactionAbortedException)
+			{
+				_log.Debug("Transaction aborted.");
+			}
+
+			AssertNoPersons();
+		}
+
 		[Test]
 		[Description("rollback inside nh-session-scope should not commit save and the transaction should be aborted.")]
 		public void TransactionInsertWithRollBackTask()
@@ -232,6 +297,35 @@ public void TransactionInsertWithRollBackTask()
 			AssertNoPersons();
 		}
 
+		[Test]
+		[Description("rollback inside nh-session-scope should not commit save and the transaction should be aborted.")]
+		public void TransactionInsertWithRollBackTaskWithFlush()
+		{
+			try
+			{
+				using (var txscope = new TransactionScope())
+				{
+					using (var s = sessions.OpenSession())
+					{
+						var person = new Person { CreatedAt = DateTime.Now };
+						s.Save(person);
+						ForceEscalationToDistributedTx.Escalate(true); //will rollback tx
+						person.CreatedAt = DateTime.Now;
+						s.Flush();
+					}
+					txscope.Complete();
+				}
+
+				Assert.Fail("Scope disposal has not rollback and throw.");
+			}
+			catch (TransactionAbortedException)
+			{
+				_log.Debug("Transaction aborted.");
+			}
+
+			AssertNoPersons();
+		}
+
 		[Test]
 		[Description(@"Two session in two txscope 
 (without an explicit NH transaction and without an explicit flush) 
@@ -405,6 +499,46 @@ public void CanDeleteItemInDtc()
 			AssertNoPersons();
 		}
 
+		[Test]
+		public void CanDeleteItemInDtcWithFlush()
+		{
+			object id;
+			using (var tx = new TransactionScope())
+			{
+				using (var s = sessions.OpenSession())
+				{
+					id = s.Save(new Person { CreatedAt = DateTime.Today });
+
+					ForceEscalationToDistributedTx.Escalate();
+
+					s.Flush();
+
+					tx.Complete();
+				}
+			}
+
+			using (var s = sessions.OpenSession())
+			using (s.BeginTransaction())
+			{
+				Assert.AreEqual(1, s.Query<Person>().Count(), "Entity not found in database.");
+			}
+
+			using (var tx = new TransactionScope())
+			{
+				using (var s = sessions.OpenSession())
+				{
+					ForceEscalationToDistributedTx.Escalate();
+
+					s.Delete(s.Get<Person>(id));
+					s.Flush();
+
+					tx.Complete();
+				}
+			}
+
+			AssertNoPersons();
+		}
+
 		[Test]
 		[Description("Open/Close a session inside a TransactionScope fails.")]
 		public void NH1744()
@@ -443,6 +577,25 @@ public void CanUseSessionOutsideOfScopeAfterScope()
 			}
 		}
 
+		[Test]
+		public void CanUseSessionOutsideOfScopeAfterScopeWithFlush()
+		{
+			using (var s = sessions.WithOptions().ConnectionReleaseMode(ConnectionReleaseMode.OnClose).OpenSession())
+			{
+				using (var tx = new TransactionScope())
+				{
+					s.Save(new Person { CreatedAt = DateTime.Today });
+
+					ForceEscalationToDistributedTx.Escalate();
+
+					s.Flush();
+					tx.Complete();
+				}
+
+				Assert.AreEqual(1, s.Query<Person>().Count(), "Entity not found in database.");
+			}
+		}
+
 		private void AssertNoPersons()
 		{
 			using (var s = sessions.OpenSession())