Fix unsaved-value for assigned identifiers

Revert NH-1914 (partially revert 3ccc965)

Author: fredericDelaporte

src/NHibernate.Test/Async/Extralazy/ExtraLazyFixture.cs

@@ -1,4 +1,4 @@
-//------------------------------------------------------------------------------
+//------------------------------------------------------------------------------
 // <auto-generated>
 //     This code was generated by AsyncGenerator.
 //

src/NHibernate.Test/Async/NHSpecificTest/GH1756/UnsavedValueNoneFixture.cs

@@ -0,0 +1,87 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated by AsyncGenerator.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+
+using System;
+using System.Linq;
+using NUnit.Framework;
+using NHibernate.Linq;
+
+namespace NHibernate.Test.NHSpecificTest.GH1756
+{
+	using System.Threading.Tasks;
+	[TestFixture]
+	public class UnsavedValueNoneFixtureAsync : BugTestCase
+	{
+		// disable second level cache enabled by default by the base class.
+		protected override string CacheConcurrencyStrategy => null;
+
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				var e1 = new Entity { Id = Guid.NewGuid(), Name = "Bob"};
+				session.Save(e1);
+
+				transaction.Commit();
+			}
+			Sfi.Statistics.IsStatisticsEnabled = true;
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				session.CreateQuery("delete from System.Object").ExecuteUpdate();
+
+				transaction.Commit();
+			}
+		}
+
+		[Test]
+		public async Task ShouldUpdateByDefaultAsync()
+		{
+			Entity e;
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				e = await (session.Query<Entity>().FirstAsync());
+				await (tx.CommitAsync());
+			}
+
+			e.Name = "Sally";
+			Sfi.Statistics.Clear();
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				await (session.SaveOrUpdateAsync(e));
+				await (tx.CommitAsync());
+			}
+
+			// Checks that no select has been done for verifying the entity state.
+			Assert.That(Sfi.Statistics.PrepareStatementCount, Is.EqualTo(1));
+		}
+
+		[Test]
+		public async Task ShouldFailByTryingToUpdateAsync()
+		{
+			var e = new Entity { Id = Guid.NewGuid(), Name = "Sally"};
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				await (session.SaveOrUpdateAsync(e));
+				Assert.That(tx.Commit, Throws.InstanceOf<StaleStateException>());
+			}
+		}
+	}
+}

src/NHibernate.Test/Async/NHSpecificTest/NH1914/Fixture.cs

@@ -0,0 +1,10 @@
+using System;
+
+namespace NHibernate.Test.NHSpecificTest.GH1756
+{
+	class Entity
+	{
+		public virtual Guid Id { get; set; }
+		public virtual string Name { get; set; }
+	}
+}

src/NHibernate.Test/NHSpecificTest/GH1756/Entity.cs

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<hibernate-mapping xmlns="urn:nhibernate-mapping-2.2" assembly="NHibernate.Test"
+                   namespace="NHibernate.Test.NHSpecificTest.GH1756">
+
+  <class name="Entity">
+    <id name="Id" generator="assigned" unsaved-value="none"/>
+    <property name="Name"/>
+  </class>
+
+</hibernate-mapping>

src/NHibernate.Test/NHSpecificTest/GH1756/Mappings.hbm.xml

@@ -0,0 +1,75 @@
+using System;
+using System.Linq;
+using NUnit.Framework;
+
+namespace NHibernate.Test.NHSpecificTest.GH1756
+{
+	[TestFixture]
+	public class UnsavedValueNoneFixture : BugTestCase
+	{
+		// disable second level cache enabled by default by the base class.
+		protected override string CacheConcurrencyStrategy => null;
+
+		protected override void OnSetUp()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				var e1 = new Entity { Id = Guid.NewGuid(), Name = "Bob"};
+				session.Save(e1);
+
+				transaction.Commit();
+			}
+			Sfi.Statistics.IsStatisticsEnabled = true;
+		}
+
+		protected override void OnTearDown()
+		{
+			using (var session = OpenSession())
+			using (var transaction = session.BeginTransaction())
+			{
+				session.CreateQuery("delete from System.Object").ExecuteUpdate();
+
+				transaction.Commit();
+			}
+		}
+
+		[Test]
+		public void ShouldUpdateByDefault()
+		{
+			Entity e;
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				e = session.Query<Entity>().First();
+				tx.Commit();
+			}
+
+			e.Name = "Sally";
+			Sfi.Statistics.Clear();
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				session.SaveOrUpdate(e);
+				tx.Commit();
+			}
+
+			// Checks that no select has been done for verifying the entity state.
+			Assert.That(Sfi.Statistics.PrepareStatementCount, Is.EqualTo(1));
+		}
+
+		[Test]
+		public void ShouldFailByTryingToUpdate()
+		{
+			var e = new Entity { Id = Guid.NewGuid(), Name = "Sally"};
+
+			using (var session = OpenSession())
+			using (var tx = session.BeginTransaction())
+			{
+				session.SaveOrUpdate(e);
+				Assert.That(tx.Commit, Throws.InstanceOf<StaleStateException>());
+			}
+		}
+	}
+}