Avoid log4net multiple configure calls

Author: bahusoid

src/NHibernate.Test/Hql/Ast/ParsingFixture.cs

@@ -74,7 +74,7 @@ namespace NHibernate.Test.Hql.Ast
 	//  [Test]
 	//  public void BasicQuery()
 	//  {
-	//    XmlConfigurator.Configure();
+	//    TestCase.ForceLogConfiguration();
 
 	//    string input = "select o.id, li.id from NHibernate.Test.CompositeId.Order o join o.LineItems li";// join o.LineItems li";
 
@@ -175,4 +175,4 @@ namespace NHibernate.Test.Hql.Ast
 	//    }
 	//  }
 	//}
-}
+}

src/NHibernate.Test/NHSpecificTest/NH1587/Fixture.cs

@@ -12,7 +12,7 @@ public class Fixture
 		[Test]
 		public void Bug()
 		{
-			XmlConfigurator.Configure(LogManager.GetRepository(typeof(Fixture).Assembly));
+			TestCase.ForceLogConfiguration();
 			var cfg = new Configuration();
 			if (TestConfigurationHelper.hibernateConfigFile != null)
 				cfg.Configure(TestConfigurationHelper.hibernateConfigFile);

src/NHibernate.Test/TestCase.cs

@@ -55,8 +55,13 @@ protected virtual string MappingsAssembly
 
 		static TestCase()
 		{
-			// Configure log4net here since configuration through an attribute doesn't always work.
-			XmlConfigurator.Configure(LogManager.GetRepository(typeof(TestCase).Assembly));
+			ForceLogConfiguration();
+		}
+
+		public static void ForceLogConfiguration()
+		{
+			//Makes sure that logger is initialized from assembly configuration attribute (see Log4NetConfigurator)
+			LogManager.GetRepository(typeof(TestCase).Assembly);
 		}
 
 		/// <summary>

src/NHibernate.Test/TypesTest/TypeFactoryFixture.cs

@@ -1,6 +1,5 @@
 using System;
 using log4net;
-using log4net.Repository.Hierarchy;
 using NHibernate.Type;
 using NUnit.Framework;
 
@@ -14,7 +13,7 @@ public class TypeFactoryFixture
 	{
 		public TypeFactoryFixture()
 		{
-			log4net.Config.XmlConfigurator.Configure(LogManager.GetRepository(typeof(TypeFactoryFixture).Assembly));
+			TestCase.ForceLogConfiguration();
 		}
 
 		private static readonly ILog log = LogManager.GetLogger(typeof(TypeFactoryFixture));