Removed unsupported clients for the generic batcher from tests

Author: maca88

src/NHibernate.Test/Ado/GenericBatchingBatcherFixture.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Linq;
-using log4net;
 using NHibernate.AdoNet;
 using NHibernate.Cfg;
 using NHibernate.Dialect;
@@ -24,6 +23,13 @@ protected override void Configure(Configuration configuration)
 			configuration.SetProperty(Environment.BatchSize, "1000");
 		}
 
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return !(dialect is FirebirdDialect) &&
+			       !(dialect is Oracle8iDialect) &&
+			       !(dialect is MsSqlCeDialect);
+		}
+
 		[Test]
 		public void MassiveInsertUpdateDeleteTest()
 		{

src/NHibernate.Test/Async/Ado/GenericBatchingBatcherFixture.cs

@@ -11,7 +11,6 @@
 using System;
 using System.Collections;
 using System.Linq;
-using log4net;
 using NHibernate.AdoNet;
 using NHibernate.Cfg;
 using NHibernate.Dialect;
@@ -37,6 +36,13 @@ protected override void Configure(Configuration configuration)
 			configuration.SetProperty(Environment.BatchSize, "1000");
 		}
 
+		protected override bool AppliesTo(Dialect.Dialect dialect)
+		{
+			return !(dialect is FirebirdDialect) &&
+			       !(dialect is Oracle8iDialect) &&
+			       !(dialect is MsSqlCeDialect);
+		}
+
 		[Test]
 		public async Task MassiveInsertUpdateDeleteTestAsync()
 		{

src/NHibernate/AdoNet/GenericBatchingBatcher.cs

@@ -10,7 +10,12 @@ namespace NHibernate.AdoNet
 {
 	/// <summary>
 	/// A generic batcher that will batch UPDATE/INSERT/DELETE commands by concatenating them with a semicolon.
-	/// Use this batcher only if there are no dedicated batchers in the given environment.
+	/// Use this batcher only if there are no dedicated batchers in the given environment. Unfortunately some
+	/// database clients do not support concatenating commands with a semicolon. Here are the known clients
+	/// that do not work with this batcher:
+	/// - FirebirdSql.Data.FirebirdClient
+	/// - Oracle.ManagedDataAccess
+	/// - System.Data.SqlServerCe
 	/// </summary>
 	public partial class GenericBatchingBatcher : AbstractBatcher
 	{
@@ -184,9 +189,6 @@ public int ExecuteNonQuery()
 				{
 					return 0;
 				}
-				// Npgsql will correctly prepare a multi SQL statement even if the parameter names are different
-				// for each statement. Npgsql internally parses the query and omits parameter names when comparing two queries
-				// in order to prevent having multiple prepared statements for the same query.
 				_batcher.Prepare(_batchCommand);
 				return _batchCommand.ExecuteNonQuery();
 			}

src/NHibernate/Async/AdoNet/GenericBatchingBatcher.cs

@@ -103,9 +103,6 @@ public async Task<int> ExecuteNonQueryAsync(CancellationToken cancellationToken)
 				{
 					return 0;
 				}
-				// Npgsql will correctly prepare a multi SQL statement even if the parameter names are different
-				// for each statement. Npgsql internally parses the query and omits parameter names when comparing two queries
-				// in order to prevent having multiple prepared statements for the same query.
 				await (_batcher.PrepareAsync(_batchCommand, cancellationToken)).ConfigureAwait(false);
 				return await (_batchCommand.ExecuteNonQueryAsync(cancellationToken)).ConfigureAwait(false);
 			}