Skip to content

Commit 14b67ac

Browse files
fixup! GH-1879 - Allow Coalesce and Conditional logic on entity properties and collections (LINQ)
Do additional minor cleanup
1 parent e943374 commit 14b67ac

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/NHibernate/Linq/ReWriters/ConditionalQueryReferenceExpander.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ public void Transform(ResultOperatorBase resultOperator)
7676

7777
protected override Expression VisitMember(MemberExpression node)
7878
{
79-
var result = (MemberExpression)base.VisitMember(node);
79+
var result = (MemberExpression) base.VisitMember(node);
8080
if (QueryReferenceCounter.CountReferences(result.Expression) > 1)
8181
{
8282
return ConditionalQueryReferenceMemberExpressionRewriter.Rewrite(result.Expression, node);
@@ -89,7 +89,7 @@ protected override Expression VisitMethodCall(MethodCallExpression node)
8989
var result = (MethodCallExpression)base.VisitMethodCall(node);
9090
var isExtension = node.Method.GetCustomAttributes<ExtensionAttribute>().Any();
9191
var methodObject = isExtension ? node.Arguments[0] : node.Object;
92-
92+
9393
if (methodObject != null && QueryReferenceCounter.CountReferences(methodObject) > 1)
9494
{
9595
return ConditionalQueryReferenceMethodCallExpressionRewriter.Rewrite(methodObject, node);
@@ -107,7 +107,7 @@ private QueryReferenceCounter(System.Type queryType)
107107
{
108108
_queryType = queryType;
109109
}
110-
110+
111111
protected override Expression VisitQuerySourceReference(QuerySourceReferenceExpression expression)
112112
{
113113
if (_queryType.IsAssignableFrom(expression.Type))

src/NHibernate/Linq/ReWriters/SubQueryConditionalExpander.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,16 +94,16 @@ protected override Expression VisitConditional(ConditionalExpression node)
9494
_nominate[_depth] = false;
9595
}
9696

97-
var newTest = this.Visit(node.Test);
97+
var newTest = Visit(node.Test);
9898
_nominate.Insert(++_depth, false);
99-
var newTrue = this.Visit(node.IfTrue);
99+
var newTrue = Visit(node.IfTrue);
100100
if (_nominate[_depth])
101101
{
102102
newTrue = BuildNewSubQuery(newTrue);
103103
Rewritten = true;
104104
}
105105
_nominate.Insert(_depth, false);
106-
var newFalse = this.Visit(node.IfFalse);
106+
var newFalse = Visit(node.IfFalse);
107107
if (_nominate[_depth])
108108
{
109109
newFalse = BuildNewSubQuery(newFalse);

0 commit comments

Comments
 (0)