Move in common overrides duplicated since connection manager own move.

Author: fredericDelaporte

src/NHibernate/Async/Impl/StatelessSessionImpl.cs

@@ -11,7 +11,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Data.Common;
 using System.Linq.Expressions;
 using NHibernate.Cache;
 using NHibernate.Collection;

src/NHibernate/Engine/ISessionImplementor.cs

@@ -274,8 +274,16 @@ public partial interface ISessionImplementor
 		bool IsOpen { get; }
 
 		/// <summary>
-		/// Is the <c>ISession</c> currently connected?
+		/// Is the session connected?
 		/// </summary>
+		/// <value>
+		/// <see langword="true" /> if the session is connected.
+		/// </value>
+		/// <remarks>
+		/// A session is considered connected if there is a <see cref="DbConnection"/> (regardless
+		/// of its state) or if the field <c>connect</c> is true. Meaning that it will connect
+		/// at the next operation that requires a connection.
+		/// </remarks>
 		bool IsConnected { get; }
 
 		FlushMode FlushMode { get; set; }

src/NHibernate/ISession.cs

@@ -191,8 +191,16 @@ public partial interface ISession : IDisposable
 		bool IsOpen { get; }
 
 		/// <summary>
-		/// Is the <c>ISession</c> currently connected?
+		/// Is the session connected?
 		/// </summary>
+		/// <value>
+		/// <see langword="true" /> if the session is connected.
+		/// </value>
+		/// <remarks>
+		/// A session is considered connected if there is a <see cref="DbConnection"/> (regardless
+		/// of its state) or if the field <c>connect</c> is true. Meaning that it will connect
+		/// at the next operation that requires a connection.
+		/// </remarks>
 		bool IsConnected { get; }
 
 		/// <summary>

src/NHibernate/IStatelessSession.cs

@@ -45,8 +45,16 @@ public partial interface IStatelessSession : IDisposable
 		bool IsOpen { get; }
 
 		/// <summary>
-		/// Is the <c>IStatelessSession</c> currently connected?
+		/// Is the session connected?
 		/// </summary>
+		/// <value>
+		/// <see langword="true" /> if the session is connected.
+		/// </value>
+		/// <remarks>
+		/// A session is considered connected if there is a <see cref="DbConnection"/> (regardless
+		/// of its state) or if the field <c>connect</c> is true. Meaning that it will connect
+		/// at the next operation that requires a connection.
+		/// </remarks>
 		bool IsConnected { get; }
 
 		/// <summary>

src/NHibernate/Impl/AbstractSessionImpl.cs

@@ -108,7 +108,16 @@ public ISessionFactoryImplementor Factory
 			protected set => _factory = value;
 		}
 
-		public abstract IBatcher Batcher { get; }
+		// 6.0 TODO: remove virtual.
+		/// <inheritdoc />
+		public virtual IBatcher Batcher
+		{
+			get
+			{
+				CheckAndUpdateSessionStatus();
+				return ConnectionManager.Batcher;
+			}
+		}
 		public abstract void CloseSessionFromSystemTransaction();
 
 		public virtual IList List(IQueryExpression queryExpression, QueryParameters parameters)
@@ -244,8 +253,13 @@ public virtual IQuery GetNamedSQLQuery(string name)
 			}
 		}
 
-		// 6.0 TODO: remove virtual.
+		// 6.0 TODO: remove virtual from below properties.
+		/// <inheritdoc />
 		public virtual ConnectionManager ConnectionManager { get; protected set; }
+		/// <inheritdoc />
+		public virtual bool IsConnected => ConnectionManager.IsConnected;
+		/// <inheritdoc />
+		public virtual DbConnection Connection => ConnectionManager.GetConnection();
 
 		public abstract IQueryTranslator[] GetQueries(IQueryExpression query, bool scalar);
 		public abstract EventListeners Listeners { get; }
@@ -254,11 +268,9 @@ public virtual IQuery GetNamedSQLQuery(string name)
 		public abstract IPersistenceContext PersistenceContext { get; }
 		public abstract CacheMode CacheMode { get; set; }
 		public abstract bool IsOpen { get; }
-		public abstract bool IsConnected { get; }
 		public abstract string FetchProfile { get; set; }
 		public abstract string BestGuessEntityName(object entity);
 		public abstract string GuessEntityName(object entity);
-		public abstract DbConnection Connection { get; }
 		public abstract int ExecuteNativeUpdate(NativeSQLQuerySpecification specification, QueryParameters queryParameters);
 		public abstract FutureCriteriaBatch FutureCriteriaBatch { get; protected internal set; }
 		public abstract FutureQueryBatch FutureQueryBatch { get; protected internal set; }

src/NHibernate/Impl/SessionImpl.cs

@@ -229,16 +229,6 @@ protected internal set
 			}
 		}
 
-		/// <summary></summary>
-		public override IBatcher Batcher
-		{
-			get
-			{
-				CheckAndUpdateSessionStatus();
-				return ConnectionManager.Batcher;
-			}
-		}
-
 		public ConnectionReleaseMode ConnectionReleaseMode
 		{
 			get { return connectionReleaseMode; }
@@ -1452,27 +1442,6 @@ public override void InitializeCollection(IPersistentCollection collection, bool
 			}
 		}
 
-		public override DbConnection Connection
-		{
-			get { return ConnectionManager.GetConnection(); }
-		}
-
-		/// <summary>
-		/// Gets if the ISession is connected.
-		/// </summary>
-		/// <value>
-		/// <see langword="true" /> if the ISession is connected.
-		/// </value>
-		/// <remarks>
-		/// An ISession is considered connected if there is an <see cref="DbConnection"/> (regardless
-		/// of its state) or if it the field <c>connect</c> is true.  Meaning that it will connect
-		/// at the next operation that requires a connection.
-		/// </remarks>
-		public override bool IsConnected
-		{
-			get { return ConnectionManager.IsConnected; }
-		}
-
 		/// <summary></summary>
 		public DbConnection Disconnect()
 		{

src/NHibernate/Impl/StatelessSessionImpl.cs

@@ -1,7 +1,6 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
-using System.Data.Common;
 using System.Linq.Expressions;
 using NHibernate.Cache;
 using NHibernate.Collection;
@@ -88,15 +87,6 @@ public override long Timestamp
 			get { throw new NotSupportedException(); }
 		}
 
-		public override IBatcher Batcher
-		{
-			get
-			{
-				CheckAndUpdateSessionStatus();
-				return ConnectionManager.Batcher;
-			}
-		}
-
 		public override void CloseSessionFromSystemTransaction()
 		{
 			Dispose(true);
@@ -333,11 +323,6 @@ public override bool IsOpen
 			get { return !IsClosed; }
 		}
 
-		public override bool IsConnected
-		{
-			get { return ConnectionManager.IsConnected; }
-		}
-
 		public override FlushMode FlushMode
 		{
 			get { return FlushMode.Commit; }
@@ -365,11 +350,6 @@ public override string GuessEntityName(object entity)
 			}
 		}
 
-		public override DbConnection Connection
-		{
-			get { return ConnectionManager.GetConnection(); }
-		}
-
 		public IStatelessSession SetBatchSize(int batchSize)
 		{
 			Batcher.BatchSize = batchSize;