Add tests

Author: Rulox

client/nginx.go

@@ -507,6 +507,7 @@ func (client *NginxClient) UpdateHTTPServers(upstream string, servers []Upstream
 	return toAdd, toDelete, toUpdate, nil
 }
 
+// haveSameParameters checks if a given server has the same parameters an NGINX server already present. Order matters
 func haveSameParameters(newServer UpstreamServer, serverNGX UpstreamServer) bool {
 	newServer.ID = serverNGX.ID
 
@@ -807,6 +808,7 @@ func (client *NginxClient) getIDOfStreamServer(upstream string, name string) (in
 	return -1, nil
 }
 
+// haveStreamSameParameters checks if a given stream server has the same parameters an NGINX server already present. Order matters
 func haveStreamSameParameters(newServer StreamUpstreamServer, serverNGX StreamUpstreamServer) bool {
 	newServer.ID = serverNGX.ID
 	if serverNGX.MaxConns != nil && newServer.MaxConns == nil {

client/nginx_test.go

@@ -353,3 +353,161 @@ func TestAddPortToServer(t *testing.T) {
 		}
 	}
 }
+
+func TestHaveSameParameters(t *testing.T) {
+	tests := []struct {
+		server    UpstreamServer
+		serverNGX UpstreamServer
+		expected  bool
+	}{
+		{
+			server:    UpstreamServer{},
+			serverNGX: UpstreamServer{},
+			expected:  true,
+		},
+		{
+			server:    UpstreamServer{ID: 2},
+			serverNGX: UpstreamServer{ID: 3},
+			expected:  true,
+		},
+		{
+			server: UpstreamServer{},
+			serverNGX: UpstreamServer{
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			expected: true,
+		},
+		{
+			server: UpstreamServer{
+				ID:          1,
+				Server:      "127.0.0.1",
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			serverNGX: UpstreamServer{
+				ID:          1,
+				Server:      "127.0.0.1",
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			expected: true,
+		},
+		{
+			server:    UpstreamServer{SlowStart: "10s"},
+			serverNGX: UpstreamServer{},
+			expected:  false,
+		},
+		{
+			server:    UpstreamServer{},
+			serverNGX: UpstreamServer{SlowStart: "10s"},
+			expected:  false,
+		},
+		{
+			server:    UpstreamServer{SlowStart: "20s"},
+			serverNGX: UpstreamServer{SlowStart: "10s"},
+			expected:  false,
+		},
+	}
+
+	for _, test := range tests {
+		result := haveSameParameters(test.server, test.serverNGX)
+		if result != test.expected {
+			t.Errorf("haveSameParameters(%v, %v) returned %v but expected %v", test.server, test.serverNGX, result, test.expected)
+		}
+	}
+}
+
+func TestHaveStreamSameParameters(t *testing.T) {
+	tests := []struct {
+		server    StreamUpstreamServer
+		serverNGX StreamUpstreamServer
+		expected  bool
+	}{
+		{
+			server:    StreamUpstreamServer{},
+			serverNGX: StreamUpstreamServer{},
+			expected:  true,
+		},
+		{
+			server:    StreamUpstreamServer{ID: 2},
+			serverNGX: StreamUpstreamServer{ID: 3},
+			expected:  true,
+		},
+		{
+			server: StreamUpstreamServer{},
+			serverNGX: StreamUpstreamServer{
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			expected: true,
+		},
+		{
+			server: StreamUpstreamServer{
+				ID:          1,
+				Server:      "127.0.0.1",
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			serverNGX: StreamUpstreamServer{
+				ID:          1,
+				Server:      "127.0.0.1",
+				MaxConns:    &defaultMaxConns,
+				MaxFails:    &defaultMaxFails,
+				FailTimeout: defaultFailTimeout,
+				SlowStart:   defaultSlowStart,
+				Backup:      &defaultBackup,
+				Weight:      &defaultWeight,
+				Down:        &defaultDown,
+			},
+			expected: true,
+		},
+		{
+			server:    StreamUpstreamServer{SlowStart: "10s"},
+			serverNGX: StreamUpstreamServer{},
+			expected:  false,
+		},
+		{
+			server:    StreamUpstreamServer{},
+			serverNGX: StreamUpstreamServer{SlowStart: "10s"},
+			expected:  false,
+		},
+		{
+			server:    StreamUpstreamServer{SlowStart: "20s"},
+			serverNGX: StreamUpstreamServer{SlowStart: "10s"},
+			expected:  false,
+		},
+	}
+
+	for _, test := range tests {
+		result := haveStreamSameParameters(test.server, test.serverNGX)
+		if result != test.expected {
+			t.Errorf("haveStreamSameParameters(%v, %v) returned %v but expected %v", test.server, test.serverNGX, result, test.expected)
+		}
+	}
+}