Add nginx status info to GetStats

Author: Jonathan Thurman

client/nginx.go

@@ -79,6 +79,7 @@ func (internalError *internalError) Wrap(err string) *internalError {
 // Stats represents NGINX Plus stats fetched from the NGINX Plus API.
 // https://nginx.org/en/docs/http/ngx_http_api_module.html
 type Stats struct {
+	Status            Status
 	Connections       Connections
 	HTTPRequests      HTTPRequests
 	SSL               SSL
@@ -88,6 +89,18 @@ type Stats struct {
 	StreamUpstreams   StreamUpstreams
 }
 
+// Status contains basic system status information
+type Status struct {
+	Version         string `json:"version"`
+	Build           string `json:"build"`
+	Address         string `json:"address"`
+	Generation      int    `json:"generation"`
+	LoadTimestamp   string `json:"load_timestamp"`
+	CurrentTime     string `json:"timestamp"`
+	ProcessID       int    `json:"pid"`
+	ParentProcessID int    `json:"ppid"`
+}
+
 // Connections represents connection related stats.
 type Connections struct {
 	Accepted uint64
@@ -658,6 +671,11 @@ func determineStreamUpdates(updatedServers []StreamUpstreamServer, nginxServers
 
 // GetStats gets connection, request, ssl, zone, stream zone, upstream and stream upstream related stats from the NGINX Plus API.
 func (client *NginxClient) GetStats() (*Stats, error) {
+	status, err := client.getStatus()
+	if err != nil {
+		return nil, fmt.Errorf("failed to get stats %v", err)
+	}
+
 	cons, err := client.getConnections()
 	if err != nil {
 		return nil, fmt.Errorf("failed to get stats: %v", err)
@@ -694,6 +712,7 @@ func (client *NginxClient) GetStats() (*Stats, error) {
 	}
 
 	return &Stats{
+		Status:            *status,
 		Connections:       *cons,
 		HTTPRequests:      *requests,
 		SSL:               *ssl,
@@ -704,6 +723,15 @@ func (client *NginxClient) GetStats() (*Stats, error) {
 	}, nil
 }
 
+func (client *NginxClient) getStatus() (*Status, error) {
+	var status Status
+	err := client.get("nginx", &status)
+	if err != nil {
+		return nil, fmt.Errorf("failed to get status: %v", err)
+	}
+	return &status, nil
+}
+
 func (client *NginxClient) getConnections() (*Connections, error) {
 	var cons Connections
 	err := client.get("connections", &cons)

tests/client_test.go

@@ -412,6 +412,32 @@ func TestStats(t *testing.T) {
 		t.Errorf("Error getting stats: %v", err)
 	}
 
+	// Status info
+	if stats.Status.Version == "" {
+		t.Error("Missing version string")
+	}
+	if stats.Status.Build == "" {
+		t.Error("Missing build string")
+	}
+	if stats.Status.Address != "127.0.0.1" {
+		t.Errorf("Bad status address: %v", stats.Status.Address)
+	}
+	if stats.Status.Generation < 1 {
+		t.Errorf("Bad config generation: %v", stats.Status.Generation)
+	}
+	if stats.Status.LoadTimestamp == "" {
+		t.Error("Missing load timestamp")
+	}
+	if stats.Status.CurrentTime == "" {
+		t.Error("Missing current timestamp")
+	}
+	if stats.Status.ProcessID < 1 {
+		t.Errorf("Bad process id: %v", stats.Status.ProcessID)
+	}
+	if stats.Status.ParentProcessID < 1 {
+		t.Errorf("Bad parent process id: %v", stats.Status.ParentProcessID)
+	}
+
 	if stats.Connections.Accepted < 1 {
 		t.Errorf("Bad connections: %v", stats.Connections)
 	}