From 5ebf8dbe2cacd936d62f21a221ef22ab25174188 Mon Sep 17 00:00:00 2001
From: Kate Osborn <k.osborn@f5.com>
Date: Tue, 16 May 2023 13:31:21 -0600
Subject: [PATCH] Set ResolvedRefs condition to true on HTTPRoutes

Previously, the ResolvedRefs condition was only set to False on HTTPRoutes
when one or more references could not be resolved. With this commit,
ResolvedRefs will be set to true when all references are resolved.
---
 docs/gateway-api-compatibility.md       |  7 +++++++
 internal/state/change_processor_test.go |  2 ++
 internal/state/conditions/conditions.go | 11 +++++++++++
 3 files changed, 20 insertions(+)

diff --git a/docs/gateway-api-compatibility.md b/docs/gateway-api-compatibility.md
index 0e27688a54..70e76e6a73 100644
--- a/docs/gateway-api-compatibility.md
+++ b/docs/gateway-api-compatibility.md
@@ -99,6 +99,13 @@ Fields:
 	* `conditions` - partially supported. Supported (Condition/Status/Reason):
     	*  `Accepted/True/Accepted`
     	*  `Accepted/False/NoMatchingListenerHostname`
+        *  `Accepted/False/UnsupportedValue`: Custom reason for when the HTTPRoute includes an invalid or unsupported value.
+        *  `Accepted/False/InvalidListener`: Custom reason for when the HTTPRoute references an invalid listener.
+        *  `ResolvedRefs/True/ResolvedRefs`
+        *  `ResolvedRefs/False/InvalidKind`
+        *  `ResolvedRefs/False/RefNotPermitted`
+        *  `ResolvedRefs/False/BackendNotFound`
+        *  `ResolvedRefs/False/UnsupportedValue`: Custom reason for when one of the HTTPRoute rules has a backendRef with an unsupported value.
 
 ### TLSRoute
 
diff --git a/internal/state/change_processor_test.go b/internal/state/change_processor_test.go
index ab313190f8..3d9217416d 100644
--- a/internal/state/change_processor_test.go
+++ b/internal/state/change_processor_test.go
@@ -342,6 +342,7 @@ var _ = Describe("ChangeProcessor", func() {
 											SectionName:   helpers.GetPointer[v1beta1.SectionName]("listener-80-1"),
 											Conditions: []conditions.Condition{
 												conditions.NewRouteInvalidListener(),
+												conditions.NewRouteResolvedRefs(),
 											},
 										},
 										{
@@ -349,6 +350,7 @@ var _ = Describe("ChangeProcessor", func() {
 											SectionName:   helpers.GetPointer[v1beta1.SectionName]("listener-443-1"),
 											Conditions: []conditions.Condition{
 												conditions.NewRouteInvalidListener(),
+												conditions.NewRouteResolvedRefs(),
 											},
 										},
 									},
diff --git a/internal/state/conditions/conditions.go b/internal/state/conditions/conditions.go
index e686386490..82fa772ef2 100644
--- a/internal/state/conditions/conditions.go
+++ b/internal/state/conditions/conditions.go
@@ -68,6 +68,7 @@ func DeduplicateConditions(conds []Condition) []Condition {
 func NewDefaultRouteConditions() []Condition {
 	return []Condition{
 		NewRouteAccepted(),
+		NewRouteResolvedRefs(),
 	}
 }
 
@@ -294,6 +295,16 @@ func NewRouteBackendRefUnsupportedValue(msg string) Condition {
 	}
 }
 
+// NewRouteResolvedRefs returns a Condition that indicates that all the references on the Route are resolved.
+func NewRouteResolvedRefs() Condition {
+	return Condition{
+		Type:    string(v1beta1.RouteConditionResolvedRefs),
+		Status:  metav1.ConditionTrue,
+		Reason:  string(v1beta1.RouteReasonResolvedRefs),
+		Message: "All references are resolved",
+	}
+}
+
 // NewGatewayClassInvalidParameters returns a Condition that indicates that the GatewayClass has invalid parameters.
 func NewGatewayClassInvalidParameters(msg string) Condition {
 	return Condition{