From 49f30157f9107341542074554905c38d2b56cd9f Mon Sep 17 00:00:00 2001 From: Kate Osborn Date: Fri, 16 Sep 2022 15:50:01 -0600 Subject: [PATCH] Handle AddToScheme errors Panic if the Kubernetes API AddToScheme() calls fail on init. --- internal/manager/manager.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/manager/manager.go b/internal/manager/manager.go index 14c5150c48..4e5167c069 100644 --- a/internal/manager/manager.go +++ b/internal/manager/manager.go @@ -7,6 +7,7 @@ import ( apiv1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" + utilruntime "k8s.io/apimachinery/pkg/util/runtime" ctlr "sigs.k8s.io/controller-runtime" "sigs.k8s.io/controller-runtime/pkg/client" "sigs.k8s.io/controller-runtime/pkg/manager" @@ -38,9 +39,8 @@ const ( var scheme = runtime.NewScheme() func init() { - // FIXME(pleshakov): handle errors returned by the calls bellow - _ = gatewayv1beta1.AddToScheme(scheme) - _ = apiv1.AddToScheme(scheme) + utilruntime.Must(gatewayv1beta1.AddToScheme(scheme)) + utilruntime.Must(apiv1.AddToScheme(scheme)) } func Start(cfg config.Config) error {