Skip to content

Commit e8b4983

Browse files
committed
More suggestions
1 parent b79f5d9 commit e8b4983

File tree

14 files changed

+39
-43
lines changed

14 files changed

+39
-43
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ The SBOM for the Docker image is available in the [GitHub Container](https://git
6868

6969
For example to retrieve the SBOM for `linux/amd64` and analyze it using [grype](https://github.com/anchore/grype) you can run the following command:
7070
```shell
71-
$ docker buildx imagetools inspect ghcr.io/nginxinc/nginx-kubernetes-gateway:edge --format '{{ json (index .SBOM "linux/amd64").SPDX }}' | grype
71+
docker buildx imagetools inspect ghcr.io/nginxinc/nginx-kubernetes-gateway:edge --format '{{ json (index .SBOM "linux/amd64").SPDX }}' | grype
7272
```
7373

7474
## Contacts

conformance/README.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,17 +52,17 @@ update-nkg-manifest Update the NKG deployment manifest image name and
5252

5353
### Step 1 - Create a kind Cluster
5454

55-
```shell
55+
```makefile
5656
make create-kind-cluster
5757
```
5858
### Step 2 - Install Nginx Kubernetes Gateway to configured kind cluster
5959

6060
#### *Option 1* Build and install Nginx Kubernetes Gateway from local to configured kind cluster
61-
```shell
61+
```makefile
6262
make install-nkg-local-build
6363
```
6464
#### *Option 2* Install Nginx Kubernetes Gateway from local already built image to configured kind cluster
65-
```shell
65+
```makefile
6666
make install-nkg-local-no-build
6767
```
6868
**Note:** You can optionally skip the actual *build* step. However, if choosing
@@ -82,36 +82,36 @@ this option, the following step *must* be completed manually *before* the build
8282
#### *Option 3* Install Nginx Kubernetes Gateway from edge to configured kind cluster
8383
You can also skip the build NKG image step and prepare the environment to instead use the `edge` image
8484

85-
```shell
85+
```makefile
8686
make install-nkg-edge
8787
```
8888

8989
### Step 3 - Build conformance test runner image
90-
```shell
90+
```makefile
9191
make build-test-runner-image
9292
```
9393

9494
### Step 4 - Run Gateway conformance tests
95-
```shell
95+
```makefile
9696
make run-conformance-tests
9797
```
9898

9999
### Step 5 - Cleanup the conformance test fixtures and uninstall Nginx Kubernetes Gateway
100-
```shell
100+
```makefile
101101
make cleanup-conformance-tests
102102
```
103-
```shell
103+
```makefile
104104
make uninstall-nkg
105105
```
106106

107107
### Step 6 - Revert changes to the NKG deployment manifest
108108
**Optional** Not required if using `edge` image
109109
**Warning**: `make undo-image-update` will hard reset changes to the deploy/manifests/deployment.yaml file!
110-
```shell
110+
```makefile
111111
make undo-image-update
112112
```
113113

114114
### Step 7 - Delete kind cluster
115-
```shell
115+
```makefile
116116
make delete-kind-cluster
117117
```

conformance/provisioner/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ How to deploy:
3535
```shell
3636
kubectl get pods -n nginx-gateway
3737
```
38-
```
38+
```console
3939
NAME READY STATUS RESTARTS AGE
4040
nginx-gateway-provisioner-6c9d9fdcb8-b2pf8 1/1 Running 0 11m
4141
```

docs/building-the-image.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,14 +13,12 @@ Before you can build the NGINX Kubernetes Gateway, make sure you have the follow
1313

1414
```shell
1515
git clone https://github.com/nginxinc/nginx-kubernetes-gateway.git
16-
```
17-
```shell
1816
cd nginx-kubernetes-gateway
1917
```
2018

2119
1. Build the image:
2220

23-
```shell
21+
```makefile
2422
make PREFIX=myregistry.example.com/nginx-kubernetes-gateway container
2523
```
2624

docs/developer/quickstart.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@ Follow these steps to set up your development environment.
2626

2727
```shell
2828
git clone https://github.com/<YOUR-USERNAME>/nginx-kubernetes-gateway.git
29-
```
30-
```shell
3129
cd nginx-kubernetes-gateway
3230
```
33-
```shell
31+
```makefile
3432
make deps
3533
```
3634

@@ -40,7 +38,7 @@ Follow these steps to set up your development environment.
4038

4139
To build the binary, run the make build command from the project's root directory:
4240
43-
```shell
41+
```makefile
4442
make build
4543
```
4644
@@ -50,7 +48,7 @@ This command will build the binary and output it to the `/build/.out` directory.
5048
5149
To build an NGINX Kubernetes Gateway container image from source run the following make command:
5250
53-
```shell
51+
```makefile
5452
make TAG=$(whoami) container
5553
```
5654
@@ -60,7 +58,7 @@ This will build the docker image `nginx-kubernetes-gateway:<your-user>`.
6058
6159
1. Create a `kind` cluster:
6260
63-
```shell
61+
```makefile
6462
make create-kind-cluster
6563
```
6664
@@ -91,7 +89,7 @@ To make sure NKG is running properly, try out the [examples](/examples).
9189
9290
To run all the unit tests, run the make unit-test command from the project's root directory:
9391

94-
```shell
92+
```makefile
9593
make unit-test
9694
```
9795

@@ -105,7 +103,7 @@ To run Gateway API conformance tests, please follow the instructions on [this](/
105103

106104
To lint the code, run the following make command from the project's root directory:
107105
108-
```shell
106+
```makefile
109107
make lint
110108
```
111109

docs/developer/testing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ promoting efficient refactoring and continuous development.
4444

4545
To run the unit tests, run the make unit-test command from the project's root directory:
4646

47-
```shell
47+
```makefile
4848
make unit-test
4949
```
5050

docs/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ This guide walks you through how to install NGINX Kubernetes Gateway on a generi
6666
```shell
6767
kubectl get pods -n nginx-gateway
6868
```
69-
```
69+
```console
7070
NAME READY STATUS RESTARTS AGE
7171
nginx-gateway-5d4f4c7db7-xk2kq 2/2 Running 0 112s
7272
```

docs/running-on-kind.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This guide walks you through how to run NGINX Kubernetes Gateway on a [kind](htt
1111

1212
Create a cluster with `kind`. You can follow their [instructions](https://kind.sigs.k8s.io/docs/user/quick-start/#creating-a-cluster), or run the following make command at the root of the repository:
1313

14-
```shell
14+
```makefile
1515
make create-kind-cluster
1616
```
1717

examples/advanced-routing/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ The cafe application consists of four Services: `coffee-v1-svc`, `coffee-v2-svc`
3838
```shell
3939
kubectl -n default get pods
4040
```
41-
```
41+
```console
4242
NAME READY STATUS RESTARTS AGE
4343
coffee-v1-75869cf7ff-vlfpq 1/1 Running 0 17m
4444
coffee-v2-67499ff985-2k6cc 1/1 Running 0 17m

examples/cafe-example/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ In this example we deploy NGINX Kubernetes Gateway, a simple web application, an
3333
```shell
3434
kubectl -n default get pods
3535
```
36-
```
36+
```console
3737
NAME READY STATUS RESTARTS AGE
3838
coffee-6f4b79b975-2sb28 1/1 Running 0 12s
3939
tea-6fb46d899f-fm7zr 1/1 Running 0 12s

examples/cross-namespace-routing/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ in a different namespace from our HTTPRoutes.
3434
```shell
3535
kubectl -n cafe get pods
3636
```
37-
```
37+
```console
3838
NAME READY STATUS RESTARTS AGE
3939
coffee-6f4b79b975-2sb28 1/1 Running 0 12s
4040
tea-6fb46d899f-fm7zr 1/1 Running 0 12s
@@ -113,7 +113,7 @@ You can also check the conditions of the HTTPRoutes `coffee` and `tea` to verify
113113
```shell
114114
kubectl describe httproute coffee
115115
```
116-
```
116+
```console
117117
Condtions:
118118
Message: Backend ref to Service cafe/coffee not permitted by any ReferenceGrant
119119
Observed Generation: 1
@@ -126,7 +126,7 @@ Condtions:
126126
```shell
127127
kubectl describe httproute tea
128128
```
129-
```
129+
```console
130130
Condtions:
131131
Message: Backend ref to Service cafe/tea not permitted by any ReferenceGrant
132132
Observed Generation: 1

examples/http-header-filter/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ headers to the request.
3434
```shell
3535
kubectl -n default get pods
3636
```
37-
```
37+
```console
3838
NAME READY STATUS RESTARTS AGE
3939
headers-6f4b79b975-2sb28 1/1 Running 0 12s
4040
```
@@ -63,7 +63,7 @@ is absent.
6363
```shell
6464
curl -s --resolve echo.example.com:$GW_PORT:$GW_IP http://echo.example.com:$GW_PORT/headers -H "My-Cool-Header:my-client-value" -H "My-Overwrite-Header:dont-see-this"
6565
```
66-
```
66+
```console
6767
Headers:
6868
header 'Accept-Encoding' is 'compress'
6969
header 'My-cool-header' is 'my-client-value, this-is-an-appended-value'

examples/https-termination/README.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ reference a Secret in a different Namespace.
3636
```shell
3737
kubectl -n default get pods
3838
```
39-
```
39+
```console
4040
NAME READY STATUS RESTARTS AGE
4141
coffee-6f4b79b975-2sb28 1/1 Running 0 12s
4242
tea-6fb46d899f-fm7zr 1/1 Running 0 12s
@@ -110,7 +110,7 @@ To get a redirect for coffee:
110110
```shell
111111
curl --resolve cafe.example.com:$GW_HTTP_PORT:$GW_IP http://cafe.example.com:$GW_HTTP_PORT/coffee --include
112112
```
113-
```
113+
```console
114114
HTTP/1.1 302 Moved Temporarily
115115
...
116116
Location: https://cafe.example.com:443/coffee
@@ -122,7 +122,7 @@ To get a redirect for tea:
122122
```shell
123123
curl --resolve cafe.example.com:$GW_HTTP_PORT:$GW_IP http://cafe.example.com:$GW_HTTP_PORT/tea --include
124124
```
125-
```
125+
```console
126126
HTTP/1.1 302 Moved Temporarily
127127
...
128128
Location: https://cafe.example.com:443/tea
@@ -139,7 +139,7 @@ To get coffee:
139139
```shell
140140
curl --resolve cafe.example.com:$GW_HTTPS_PORT:$GW_IP https://cafe.example.com:$GW_HTTPS_PORT/coffee --insecure
141141
```
142-
```
142+
```console
143143
Server address: 10.12.0.18:80
144144
Server name: coffee-7586895968-r26zn
145145
```
@@ -149,7 +149,7 @@ To get tea:
149149
```shell
150150
curl --resolve cafe.example.com:$GW_HTTPS_PORT:$GW_IP https://cafe.example.com:$GW_HTTPS_PORT/tea --insecure
151151
```
152-
```
152+
```console
153153
Server address: 10.12.0.19:80
154154
Server name: tea-7cd44fcb4d-xfw2x
155155
```
@@ -167,7 +167,7 @@ Now, if we try to access the application over HTTPS, we will get a connection re
167167
```shell
168168
curl --resolve cafe.example.com:$GW_HTTPS_PORT:$GW_IP https://cafe.example.com:$GW_HTTPS_PORT/coffee --insecure -vvv
169169
```
170-
```
170+
```console
171171
...
172172
curl: (7) Failed to connect to cafe.example.com port 443 after 0 ms: Connection refused
173173
```
@@ -178,7 +178,7 @@ You can also check the conditions of the Gateway `https` Listener to verify the
178178
```shell
179179
kubectl describe gateway gateway
180180
```
181-
```
181+
```console
182182
Name: https
183183
Conditions:
184184
Last Transition Time: 2023-06-26T20:23:56Z

examples/traffic-splitting/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ We will use `HTTPRoute` resources to split traffic between two versions of the a
3434
```shell
3535
kubectl -n default get pods
3636
```
37-
```
37+
```console
3838
NAME READY STATUS RESTARTS AGE
3939
coffee-v1-7c57c576b-rfjsh 1/1 Running 0 21m
4040
coffee-v2-698f66dc46-vcb6r 1/1 Running 0 21m
@@ -68,14 +68,14 @@ curl --resolve cafe.example.com:$GW_PORT:$GW_IP http://cafe.example.com:$GW_PORT
6868

6969
80% of the responses will come from `coffee-v1`:
7070

71-
```
71+
```console
7272
Server address: 10.12.0.18:80
7373
Server name: coffee-v1-7c57c576b-rfjsh
7474
```
7575

7676
20% of the responses will come from `coffee-v2`:
7777

78-
```
78+
```console
7979
Server address: 10.12.0.19:80
8080
Server name: coffee-v2-698f66dc46-vcb6r
8181
```

0 commit comments

Comments
 (0)