Skip to content

Commit e4e8829

Browse files
committed
Refactor blind sleep to instead wait for pods to be ready
1 parent a9d862c commit e4e8829

File tree

1 file changed

+16
-2
lines changed

1 file changed

+16
-2
lines changed

tests/suite/reconfig_test.go

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,14 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
132132

133133
Expect(createUniqueResources(resourceCount, "manifests/reconfig/cafe-routes.yaml")).To(Succeed())
134134

135-
time.Sleep(60 * time.Second)
135+
for i := 1; i <= resourceCount; i++ {
136+
ns := core.Namespace{
137+
ObjectMeta: metav1.ObjectMeta{
138+
Name: "namespace" + strconv.Itoa(i),
139+
},
140+
}
141+
Expect(resourceManager.WaitForPodsToBeReady(ctx, ns.Name)).To(Succeed())
142+
}
136143

137144
Expect(resourceManager.ApplyFromFiles([]string{"reconfig/gateway.yaml"}, reconfigNamespace.Name)).To(Succeed())
138145

@@ -154,7 +161,14 @@ var _ = Describe("Reconfiguration Performance Testing", Ordered, Label("reconfig
154161

155162
Expect(createUniqueResources(resourceCount, "manifests/reconfig/cafe.yaml")).To(Succeed())
156163

157-
time.Sleep(60 * time.Second)
164+
for i := 1; i <= resourceCount; i++ {
165+
ns := core.Namespace{
166+
ObjectMeta: metav1.ObjectMeta{
167+
Name: "namespace" + strconv.Itoa(i),
168+
},
169+
}
170+
Expect(resourceManager.WaitForPodsToBeReady(ctx, ns.Name)).To(Succeed())
171+
}
158172

159173
Expect(resourceManager.Apply([]client.Object{&reconfigNamespace})).To(Succeed())
160174
Expect(resourceManager.ApplyFromFiles(

0 commit comments

Comments
 (0)